[Bug 941758] New: grub-once isn't called at hibernate
http://bugzilla.opensuse.org/show_bug.cgi?id=941758 Bug ID: 941758 Summary: grub-once isn't called at hibernate Classification: openSUSE Product: openSUSE Factory Version: 201505* Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: bnc-team-screening@forge.provo.novell.com Reporter: tiwai@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Since the recent change of systemd, grub-once isn't called any longer, thus at thawing, the normal GRUB menu is shown instead of the direct boot to the target kernel. The regression was introduced in openSUSE:Factory/systemd changeset 215: Wed Feb 18 05:01:38 UTC 2015 - crrodriguez@opensuse.org .... - systemd-sleep-grub: moved to the grub2 package where it belongs as a suspend/resume hook (SR#286533) (drops prepare-suspend-to-disk.patch) However, SR#286533 was declined and it's lost since then. The fix would be either revert the change in systemd or put the hook properly into grub2 package. The latter method has a potential bug, however. systemd-sleep doesn't call hooks to restore when writing to /sys/power/state fails. That is, if we have a hook to set up grubenv, it'll left when the hibernation fails, and the next boot would go wrong. This didn't happen in the past because it invoked the grubenv setup in a different manner. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941758 Takashi Iwai <tiwai@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmuelle@suse.com, | |mchang@suse.com, | |systemd-maintainers@suse.de -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941758 http://bugzilla.opensuse.org/show_bug.cgi?id=941758#c1 --- Comment #1 from Michael Chang <mchang@suse.com> --- Here is the note from last review if considering it in grub2 package. 1. cleanup to not having any pm-util related environment variable 2. remove grub related part in the script 3 provide the package as conditional, maybe after some systemd version (or we may have conflicted file ?) 4. packaged as noarch subpackage and maybe "Supplements: packageand(systemd-sleep:grub2)" to install it if systemd-sleep and grub2 is to be installed , do not putting it in grub package. Thanks. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941758 Michael Chang <mchang@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugzilla.opensuse.or | |g/show_bug.cgi?id=941682 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941758 http://bugzilla.opensuse.org/show_bug.cgi?id=941758#c7 Michael Chang <mchang@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Michael Chang <mchang@suse.com> --- Hi, Close this bug as systemd-sleep-plugin subpackage has been added to grub2. Thanks. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941758 http://bugzilla.opensuse.org/show_bug.cgi?id=941758#c8 --- Comment #8 from Michael Chang <mchang@suse.com> --- *** Bug 941682 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941758 http://bugzilla.opensuse.org/show_bug.cgi?id=941758#c10 Thomas Leineweber <suse@tleine.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #10 from Thomas Leineweber <suse@tleine.de> --- Although sleep has been moved to a subpackage of grub, there are some remains in the systemd package (as shown in bug 991350): * The script /usr/bin/systemd-sleep-grub is called from the systemd-units /usr/lib/systemd/system/systemd-hibernate.service and /usr/lib/systemd/system/systemd-hybrid-hibernate.service
[Service] Type=oneshot ExecStart=/usr/bin/systemd-sleep-grub pre ExecStart=/usr/lib/systemd/systemd-sleep hibernate ExecStopPost=/usr/bin/systemd-sleep-grub post
* But this script has been removed with https://build.opensuse.org/request/show/407291 This error exists at least in Leap 42.2. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941758 http://bugzilla.opensuse.org/show_bug.cgi?id=941758#c11 --- Comment #11 from Thomas Leineweber <suse@tleine.de> --- I created a pull request on github with the fix for the SLE12-SP2 branch of systemd. It removes the calls to systemd-sleep-grub from the two units for hibernate. https://github.com/openSUSE/systemd/pull/2 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941758 http://bugzilla.opensuse.org/show_bug.cgi?id=941758#c14 Bernhard Wiedemann <bwiedemann@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED CC| |bwiedemann@suse.com Resolution|--- |FIXED --- Comment #14 from Bernhard Wiedemann <bwiedemann@suse.com> --- This seems to be long fixed. In 15.0 and later there is bug 1154783 though with a similar effect. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com