[Bug 1203468] New: xrdp broken when updating TW from build 20220813 to 20220908
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 Bug ID: 1203468 Summary: xrdp broken when updating TW from build 20220813 to 20220908 Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: x86-64 OS: openSUSE Tumbleweed Status: NEW Severity: Normal Priority: P5 - None Component: X11 Applications Assignee: screening-team-bugs@suse.de Reporter: jmscdba@gmail.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Updated several machines from TW 20220813 to 20220908 today and found that xrdp connections no longer work on any of the machines. The Connection Log is not real useful: Connecting to sesman on 127:0.0.1:3350 sesman connect ok sending login info to session manager.Please wait.. login successful for user denise on display 200 VNC started connecting Waiting 2000 ms for VNC to start... VNC connecting to 127.0.0.1.6100 VNC error - problem connecting some problem Error connecting to user session Comparing journal entries from build 20220813 where it was working and build 20220908 where it no longer works, I suspect that this is the source of the problem: Sep 15 12:52:27 xrdp-sesman[2328]: [mi] mieq: warning: overriding existing handler (nil) with 0x55a01f4cc210 for event 2 Sep 15 12:52:27 xrdp-sesman[2328]: [mi] mieq: warning: overriding existing handler (nil) with 0x55a01f4cc210 for event 3 Sep 15 12:52:27 xrdp-sesman[2343]: Failed to connect to bus: No medium found Reverting xrdp from xrdp-0.9.19-1.2.x86_64.rpm ( which is in 20220908 ) back to xrdp-0.9.19-1.1.x86_64.rpm ( which is in 20220813 ) resolves the issue. Looks like build 20220914 is using the same version as 20220908. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 Joe S <jmscdba@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sndirsch@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 http://bugzilla.opensuse.org/show_bug.cgi?id=1203468#c1 Joe S <jmscdba@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium CC| |sndirsch@suse.com --- Comment #1 from Joe S <jmscdba@gmail.com> --- Is anyone looking at this bug? It's been 1 and a half months and it seems like my report shows what change broke it From the bug report it seems pretty clear that the changes made between xrdp-0.9.19-1.1.x86_64.rpm ( which is in 20220813 ) and xrdp-0.9.19-1.2.x86_64.rpm ( which is in 20220908 ) is the source of the problem since reverting back to xrdp-0.9.19-1.1.x86_64.rpm resolves the issue and xrdp works fine with the prior version. Today I updated one of my machines to TW 20221024 which is still using the broken xrdp-0.9.19-1.2.x86_64.rpm version and as expected xrdp is still broken. Installing the prior verion which I had saved ( xrdp-0.9.19-1.1.x86_64.rpm ) once again provides a working xrdp environment. Do you need more details or do we need to add someone else to the bug report to look at the issue? Thank you for your time! -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 http://bugzilla.opensuse.org/show_bug.cgi?id=1203468#c2 --- Comment #2 from Stefan Dirsch <sndirsch@suse.com> --- Both versions use the same sources for xrdp, so I'm afraid it's the build environment that broke it. Not so easy to investigate ... but Felix needs to look at it anyway ... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 Hans-Peter Jansen <hpj@urpla.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hpj@urpla.net -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 http://bugzilla.opensuse.org/show_bug.cgi?id=1203468#c8 --- Comment #8 from Joe S <jmscdba@gmail.com> --- (In reply to Yifan Jiang from comment #6)
Meanwhile, I just accepted Mike's SR into the development branch.
Joe, are you possible to try if this mitigates the problem:
https://download.opensuse.org/repositories/X11:/RemoteDesktop/ openSUSE_Tumbleweed/
Yifan, Sure no problem. I have tested and I have mixed results to report. NOTE: I rebooted after every one of the package installs or removals * TW 20221024 Machine I installed the xrdp-0.9.20-114.1.x86_64.rpm that your provided. It displayed the light bulb and spinning gear like it was going to login but then it never gets to the desktop and there were no errors or messages. I removed xrdp-0.9.20-114.1.x86_64.rpm and then reinstalled xrdp-0.9.19-1.1.x86_64.rpm ( from 20220813 ) and it was working again. I removed xrdp-0.9.19-1.1.x86_64.rpm ( from 20220813 ) and then installed xrdp-0.9.20-114.1.x86_64.rpm and this time it worked. * TW 20220908 I tried the same steps on the 20220908 machine and it gets the same errors as reported in my 09/15/2022 19:15 UTC bug report message when using the xrdp-0.9.20-114.1.x86_64.rpm Does that help? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 http://bugzilla.opensuse.org/show_bug.cgi?id=1203468#c9 --- Comment #9 from Joe S <jmscdba@gmail.com> --- (In reply to Dominique Leuenberger from comment #7)
(In reply to Yifan Jiang from comment #5)
I am not sure how to revert to a precedent binary package since when there was no source update. But probably we need to do that if it is a general issue.
@Dominique, do you think there is a way to do it technically? Thanks!
That's not possible - we need to find out whats the difference between the two builds that resulted in this issue
I am sure there are parts to the process that I don't understand but I am surprised at your answer as I have seen different versions of a package available within a build before. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 http://bugzilla.opensuse.org/show_bug.cgi?id=1203468#c14 Stefan Willer <will69@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |will69@gmx.de --- Comment #14 from Stefan Willer <will69@gmx.de> --- The most recent xrdp uses a vanilla upstream config in /etc/pam.d/xrdp-sesman, which does not include /etc/pam.d/common*. If you rely on a special method of authentication configured via pam-config in those files (like sss), it won���t work with xrdp. Here���s a quickfix for that scenario: cd /etc/pam.d && cp samba xrdp-sesman The samba file is just a very basic config that has all the necessary includes. I do not know if it is optimal for xrdp. This should probably be changed when packaging xrdp for Tumbleweed. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 http://bugzilla.opensuse.org/show_bug.cgi?id=1203468#c21 --- Comment #21 from Daike Yu <yu.daike@suse.com> --- (In reply to Stefan Dirsch from comment #19)
Created attachment 862540 [details] xrdp-pamdir-suse.patch
Index: xrdp.spec =================================================================== --- xrdp.spec (revision 44) +++ xrdp.spec (working copy) @@ -52,6 +52,7 @@ Patch13: xrdp-bsc965647-allow-admin-choose-desktop.patch # PATCH-FEATURE-SLE xrdp-fate318398-change-expired-password.patch fate#318398 - fezhang@suse.com -- enable user to update expired password via PAM Patch14: xrdp-fate318398-change-expired-password.patch +Patch15: xrdp-pamdir-suse.patch
BuildRequires: autoconf BuildRequires: automake @@ -109,6 +110,9 @@ %patch12 -p1 %patch13 -p1 %patch14 -p1 +%endif +%if 0%{?suse_version} >= 1550 +%patch15 -p1 %endif
%build
So it seems that the path change caused install script failed to pick the correct rule. IMO this fix probably should be submitted to the upstream. I'll probably submit a PR later. Thanks for the help! -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 http://bugzilla.opensuse.org/show_bug.cgi?id=1203468#c22 --- Comment #22 from Stefan Dirsch <sndirsch@suse.com> --- (In reply to Daike Yu from comment #21)
(In reply to Stefan Dirsch from comment #19)
Created attachment 862540 [details] xrdp-pamdir-suse.patch
Index: xrdp.spec =================================================================== --- xrdp.spec (revision 44) +++ xrdp.spec (working copy) @@ -52,6 +52,7 @@ Patch13: xrdp-bsc965647-allow-admin-choose-desktop.patch # PATCH-FEATURE-SLE xrdp-fate318398-change-expired-password.patch fate#318398 - fezhang@suse.com -- enable user to update expired password via PAM Patch14: xrdp-fate318398-change-expired-password.patch +Patch15: xrdp-pamdir-suse.patch
BuildRequires: autoconf BuildRequires: automake @@ -109,6 +110,9 @@ %patch12 -p1 %patch13 -p1 %patch14 -p1 +%endif +%if 0%{?suse_version} >= 1550 +%patch15 -p1 %endif
%build
So it seems that the path change caused install script failed to pick the correct rule.
Exactly.
IMO this fix probably should be submitted to the upstream. I'll probably submit a PR later. Thanks for the help!
Yes. This should work. For Leap 15.x/sle the old rule should still work. There is still /etc/pam.d/common-account on these. pamdir="/etc/pam.d" [...] elif [ -s "$pamdir/common-account" ]; then if grep "^@include" "$pamdir/passwd" >/dev/null 2>&1; then rules="debian" else rules="suse" fi [...] -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 http://bugzilla.opensuse.org/show_bug.cgi?id=1203468#c25 Joe S <jmscdba@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #25 from Joe S <jmscdba@gmail.com> --- (In reply to Stefan Dirsch from comment #24)
This is already fixed in Tumbleweed.
------------------------------------------------------------------- Mon Nov 7 10:48:57 UTC 2022 - Daike Yu <yu.daike@suse.com>
- Add xrdp-update-pam.d-path.patch (bsc#1203468) + Update pam.d path in install scripts to allow correct rule guess.
Hi Stefan, Sorry to report that it is still not fixed. Today I updated from 20221101 to TW 20221202 and xrdp is still broken. After updating to TW 20221202, I Removed xrdp and xorgxrdp packages Removed my /etc/pam.d/xrdp-sesman Which was renamed to xrdp-sesman.rpmsave by the package removal Rebooted Installed xrdp and xorgxrdp packages Started and enabled the xrdp service Verified firewall had port open for zone Here is the xrdp.sesman file that was installed from 20221202 #%PAM-1.0 # # Really basic authentication set when nothing else is available # # You may need to edit this to suit your system depending on the # required functionality. # auth required pam_unix.so shadow auth required pam_env.so password required pam_unix.so account required pam_unix.so account required pam_nologin.so session required pam_unix.so Tried remote desktop to machine and get the SAME errors as initially reported ( here the are again ) The Connection Log is not real useful: Connecting to sesman on 127:0.0.1:3350 sesman connect ok sending login info to session manager.Please wait.. login successful for user denise on display 200 VNC started connecting Waiting 2000 ms for VNC to start... VNC connecting to 127.0.0.1.6100 VNC error - problem connecting some problem Error connecting to user session To resolve I did the following: Edit /etc/pam.d/xrdp-sessman and add session include common-session systemctl daemon-reload systemctl restart xrdp xrdp now working again. Seems that the fix is to add the line to xrdp-sesman which I included which wold resolve the issue. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 http://bugzilla.opensuse.org/show_bug.cgi?id=1203468#c26 --- Comment #26 from Joe S <jmscdba@gmail.com> --- Also when I did the zypper dup to 20221202 the following was displayed which may or may not be related ? Updating /etc/sysconfig/xrdp ... Too few arguments. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 http://bugzilla.opensuse.org/show_bug.cgi?id=1203468#c27 Stefan Dirsch <sndirsch@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |IN_PROGRESS --- Comment #27 from Stefan Dirsch <sndirsch@suse.com> --- Hmm. Seems the patch is only applied on SLE, but not on Tumbleweed. No idea why. [...] Patch15: xrdp-update-pam.d-path.patch [...] %prep %setup -q %patch1 -p1 %patch4 -p1 %patch5 -p1 %patch6 -p1 %if 0%{?sle_version} %patch11 -p1 %patch12 -p1 %patch13 -p1 %patch14 -p1 %patch15 -p1 %endif [...] -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 http://bugzilla.opensuse.org/show_bug.cgi?id=1203468#c28 --- Comment #28 from Joe S <jmscdba@gmail.com> --- (In reply to Stefan Dirsch from comment #27)
Hmm. Seems the patch is only applied on SLE, but not on Tumbleweed. No idea why.
So who can we report this too so that it gets included in TW? Seems like this would be the right place but obviously something is not triggering that to occur.... Thanks! -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 http://bugzilla.opensuse.org/show_bug.cgi?id=1203468#c29 --- Comment #29 from Daike Yu <yu.daike@suse.com> --- Fix submitted to X11:RemoteDesktop. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 http://bugzilla.opensuse.org/show_bug.cgi?id=1203468#c30 Stefan Dirsch <sndirsch@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #30 from Stefan Dirsch <sndirsch@suse.com> --- Thanks! https://build.opensuse.org/request/show/1040111 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1203468 http://bugzilla.opensuse.org/show_bug.cgi?id=1203468#c31 --- Comment #31 from Joe S <jmscdba@gmail.com> --- I just update from TW 20221202 to 20221205 which includes the patch. It properly created the /etc/pam.d/xrdp-sesman.rpmnew file. I replaced /etc/pam.d/xrdp-sesman with the rpmnew file, restarted the service and as expected everything is working. Thanks to all for your help in resolving this. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com