[Bug 891829] New: source_validator incorrectly parses conditionals in preamble
https://bugzilla.novell.com/show_bug.cgi?id=891829 https://bugzilla.novell.com/show_bug.cgi?id=891829#c0 Summary: source_validator incorrectly parses conditionals in preamble Classification: openSUSE Product: openSUSE.org Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: BuildService AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: sbrabec@suse.com QAContact: adrian@suse.com CC: ro@suse.com Found By: --- Blocker: --- Created an attachment (id=602295) --> (http://bugzilla.novell.com/attachment.cgi?id=602295) util-linux.spec file passed to rpmbuild When processing new util-linux package, I got following error: error: Duplicate License entries in package: (main package) Aborting: service call failed: /usr/lib/obs/service/source_validator --outdir /tmp/tmpUOqaab However rpmbuild -ba util-linux.spec does not see any problems of this spec file. This statement is apparently incorrect. Looking at the spec file, I see: One License tag inside "%if %build_util_linux" - this one should be active. Second License tag inside "%if %build_python_libmount" and inside %else of "%if %build_util_linux" - this should be inactive. Third License tag inside "%if %build_util_linux_systemd" and inside %else of "%if %build_util_linux" - this should be inactive. According to the initial evaluation of variables, we should have: %define build_util_linux 1 %define build_util_linux_systemd 0 %define build_python_libmount 0 %define verify_sig 0 But if I look into preprocessed /tmp/check_if_valid_source_dir-5rRp5R/tmp.spec, I see that all are supposed to be 1. Note that this bug is triggered by format_spec_file (see bug 891152), which forces placing License tags to each %if branch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=891829 https://bugzilla.novell.com/show_bug.cgi?id=891829#c1 --- Comment #1 from Stanislav Brabec <sbrabec@suse.com> 2014-08-13 22:21:30 CEST --- Created an attachment (id=602296) --> (http://bugzilla.novell.com/attachment.cgi?id=602296) temporary /tmp/check_if_valid_source_dir-5rRp5R/tmp.spec file -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=891829 https://bugzilla.novell.com/show_bug.cgi?id=891829#c2 Ruediger Oertel <ro@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Ruediger Oertel <ro@suse.com> 2014-08-13 23:36:39 UTC --- well, if it was not the License it would be the Summary ... changed source-validator to also deduplicate License and Summary entries changed in openSUSE:Tools/obs-service-source_validator submitted to factory and sle12 deployed on IBS and OBS -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=891829 https://bugzilla.novell.com/show_bug.cgi?id=891829#c4 --- Comment #4 from Bernhard Wiedemann <bwiedemann@suse.com> 2014-08-14 02:00:23 CEST --- This is an autogenerated message for OBS integration: This bug (891829) was mentioned in https://build.opensuse.org/request/show/244635 Factory / obs-service-source_validator -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=891829 https://bugzilla.novell.com/show_bug.cgi?id=891829#c6 --- Comment #6 from Bernhard Wiedemann <bwiedemann@suse.com> 2014-08-14 03:00:35 CEST --- This is an autogenerated message for OBS integration: This bug (891829) was mentioned in https://build.opensuse.org/request/show/244637 Factory / obs-service-source_validator -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=891829 https://bugzilla.novell.com/show_bug.cgi?id=891829#c7 --- Comment #7 from Bernhard Wiedemann <bwiedemann@suse.com> 2014-08-26 17:00:40 CEST --- This is an autogenerated message for OBS integration: This bug (891829) was mentioned in https://build.opensuse.org/request/show/246534 Factory / util-linux -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=891829 SMASH SMASH <smash_bz@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|maint:planned:update | -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com