[Bug 594310] New: rpm: using %defattr multiple times doesn't work as expected
http://bugzilla.novell.com/show_bug.cgi?id=594310 http://bugzilla.novell.com/show_bug.cgi?id=594310#c0 Summary: rpm: using %defattr multiple times doesn't work as expected Classification: openSUSE Product: openSUSE 11.3 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Development AssignedTo: pth@novell.com ReportedBy: vuntz@novell.com QAContact: qa@suse.de Found By: --- Blocker: --- gnome-games fails to build in Factory with this error: The following directories are not even executable by their owner: drw-rw-r-- 2 root root 0 Apr 5 22:45 /usr/share/gnome-games/glines drw-rw-r-- 2 root root 0 Apr 5 22:45 /usr/share/gnome-games/glines/pixmaps However, the directories are executable at the end of %install, so the executable bit gets lost when creating the rpm file. Looking at the %files section, we have this: %files -n glines -f glines.schemas_list %defattr (0755, games, games) %verify(not mode) %{_bindir}/glines %defattr (0664, games, games) %ghost %{_localstatedir}/games/glines.Large.scores %ghost %{_localstatedir}/games/glines.Medium.scores %ghost %{_localstatedir}/games/glines.Small.scores %defattr(-, root, root) %{_datadir}/applications/glines.desktop %{_datadir}/gnome-games/glines/ %{_datadir}/icons/hicolor/*/apps/gnome-glines.* %{_mandir}/man?/glines.* So it appears to me that the %defattr(-, root, root) line doesn't work as expected. And indeed, it works if I change the %files section to: %files -n glines -f glines.schemas_list %defattr(-, root, root) %{_datadir}/applications/glines.desktop %{_datadir}/gnome-games/glines/ %{_datadir}/icons/hicolor/*/apps/gnome-glines.* %{_mandir}/man?/glines.* %defattr (0755, games, games) %verify(not mode) %{_bindir}/glines %defattr (0664, games, games) %ghost %{_localstatedir}/games/glines.Large.scores %ghost %{_localstatedir}/games/glines.Medium.scores %ghost %{_localstatedir}/games/glines.Small.scores -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=594310 http://bugzilla.novell.com/show_bug.cgi?id=594310#c Vincent Untz <vuntz@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|pth@novell.com |mls@novell.com -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=594310 http://bugzilla.novell.com/show_bug.cgi?id=594310#c1 Michael Schröder <mls@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |INVALID --- Comment #1 from Michael Schröder <mls@novell.com> 2010-04-07 10:32:59 UTC --- Yes, '-' means do not change the last set value. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=594310 http://bugzilla.novell.com/show_bug.cgi?id=594310#c2 --- Comment #2 from Vincent Untz <vuntz@novell.com> 2010-04-07 11:04:48 UTC --- Err, that's highly confusing, then. The only documentation I can find is http://www.rpm.org/max-rpm-snapshot/s1-rpm-inside-files-list-directives.html and it says this about dash: "If a particular attribute does not need to be specified (usually because the file is installed with that attribute set properly), then that attribute may be replaced with a dash" (that's for %attr, not for %defattr, though). I'd expect this to work for %defattr too. Is there anyway to come back to "unset", then? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=594310 http://bugzilla.novell.com/show_bug.cgi?id=594310#c3 Michael Schröder <mls@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|INVALID | --- Comment #3 from Michael Schröder <mls@novell.com> 2010-04-07 14:20:21 UTC --- Oh wait, I just looked at old rpm-4.4.2 and it seems like the code in question was changed to make %attr(-...) go back to the defattr setting. I now consider this a regression that needs fixing. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=594310 http://bugzilla.novell.com/show_bug.cgi?id=594310#c4 andrea florio <andrea@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrea@opensuse.org --- Comment #4 from andrea florio <andrea@opensuse.org> 2010-06-28 10:57:59 UTC --- looks to be fixed in rpm 4.8.1 http://www.rpm.org/wiki/Releases/4.8.1 suse 11.3 RC1 ship 4.8 (.0 i guess) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=594310 http://bugzilla.novell.com/show_bug.cgi?id=594310#c5 Michael Schröder <mls@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |CLOSED Resolution| |FIXED --- Comment #5 from Michael Schröder <mls@novell.com> 2010-06-28 11:13:55 UTC --- Yes, they took my patch. Closing as FIXED. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com