[Bug 494232] New: Driver "benet" removed from staging, be2net merged in drivers/net (different versions/PCI-IDs)
http://bugzilla.novell.com/show_bug.cgi?id=494232 Summary: Driver "benet" removed from staging, be2net merged in drivers/net (different versions/PCI-IDs) Classification: openSUSE Product: openSUSE 11.2 Version: Alpha 0 Platform: x86 OS/Version: SuSE Other Status: NEW Severity: Enhancement Priority: P5 - None Component: Kernel AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: AxelKoellhofer@web.de QAContact: qa@suse.de Found By: --- Created an attachment (id=285317) --> (http://bugzilla.novell.com/attachment.cgi?id=285317) Patch for benet to compile with 2.6.29 User-Agent: Opera/9.64 (X11; Linux x86_64; U; de) Presto/2.1.1 I am playing around with building driver packages from Staging (i.e. trying to backport them to older openSUSE-versions, if possible). In 2.6.27 (openSUSE 11.1) a driver called "benet" was included, modinfo shows the following output: modinfo benet filename: /lib/modules/2.6.27.21-0.1-default/kernel/drivers/staging/benet/benet.ko license: GPL author: ServerEngines description: ServerEngines BladeEngine Network Driver Version 1.0.728 version: 1.0.728 srcversion: E870885A441CEB9BDB3C3F8 alias: pci:v000019A2d00000201sv*sd*bc*sc*i* depends: staging: Y vermagic: 2.6.27.21-0.1-default SMP mod_unload modversions parm: msix:Use MSI-x interrupts (uint) parm: rxbuf_size:Size of buffers to hold Rx data (uint) After installing openSUSE factory (11.2 Alpha0), I searched for new drivers in Staging and benet was gone. Quick search on the net gave me this result. http://lkml.indiana.edu/hypermail/linux/kernel/0903.2/01269.html The driver I found in "drivers/net" was called "be2net" and gives the following modinfo output: filename: /lib/modules/2.6.29-6-default/kernel/drivers/net/benet/be2net.ko license: GPL author: ServerEngines Corporation description: ServerEngines BladeEngine2 10Gbps NICDriver 2.0.348 version: 2.0.348 srcversion: 2A905AA5D1F40A3C95BC9F4 alias: pci:v000019A2d00000211sv*sd*bc*sc*i* depends: vermagic: 2.6.29-6-default SMP mod_unload modversions parm: rx_frag_size:Size of a fragment that holds rcvd data. (uint) To me this looks like two drivers for two different devices (PCI-IDs). I don't have the respective hardware (I'm just playing around with this Staging stuff), but I was able to patch "benet" to compile with 2.6.29 (see attachment). P.S. I also created a little patch to compile the new "be2net"-driver with openSUSE 11.1/11.0 (see second attachment), if there is any interest in merging be2net to Staging for older kernel versions. Reproducible: Always Steps to Reproduce: 1. 2. 3. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=494232
User AxelKoellhofer@web.de added comment
http://bugzilla.novell.com/show_bug.cgi?id=494232#c1
--- Comment #1 from Axel Köllhofer
http://bugzilla.novell.com/show_bug.cgi?id=494232
User gregkh@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=494232#c3
Greg Kroah-Hartman
http://bugzilla.novell.com/show_bug.cgi?id=494232
User AxelKoellhofer@web.de added comment
http://bugzilla.novell.com/show_bug.cgi?id=494232#c4
--- Comment #4 from Axel Köllhofer
The benet driver authors are the ones that asked the be2net driver to be removed from the tree, perhaps they just forgot to add the older device id.
Thanks for this information, Greg. I must admit that I posted here somehow hoping/expecting that you would respond.
Please contact the upstream developers about this issue.
Done. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=494232
User AxelKoellhofer@web.de added comment
http://bugzilla.novell.com/show_bug.cgi?id=494232#c5
--- Comment #5 from Axel Köllhofer
Short answer first : benet in staging was written for first generation BladeEgine ASIC (BE1) and be2net driver works for the second generation ASIC (BE2).
Now the long answer :
benet driver in the staging area supported the first generation BladeEngine device. Based on the comments in netdev, we decided that we can completely get rid of some sticky remnants of the earlier design that used a h/w abstraction only by totally rewriting the driver. We did that for the second generation BladeEngine ASIC (BE2) and found that maintaining compatibility for the BE1 would make the driver very ugly since descriptor formats had changed between the two generations. So, we dropped support for BE1 in be2net. To avoid confusion we requested GKH to drop the benet from the staging.
So as it looks, there won't be a driver for the first generation devices soon, I decided to offer the "benet"-driver as external modules via kmp-packages (benet-kmp-*flavor*) in my OBS-repo http://download.opensuse.org/repositories/home:/Akoellh/ in the hope they might be useful for people with this device. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com