[Bug 1187232] hplip-hpijs 3.20.11-2.1 free(): invalid pointer crash in hpcups
https://bugzilla.suse.com/show_bug.cgi?id=1187232 https://bugzilla.suse.com/show_bug.cgi?id=1187232#c2 --- Comment #2 from Johannes Meixner <jsmeix@suse.com> --- I cannot reproduce on my openSUSE Leap 15.2 x86_64 system what is described as "a simple way to reproduce" in https://bugs.launchpad.net/hplip/+bug/1901209 I had hplip-3.19.12 installed and did (long lines may show wrapped here): ------------------------------------------------------------- # rpm -qa | grep ^hplip hplip-sane-3.19.12-lp152.2.3.1.x86_64 hplip-3.19.12-lp152.2.3.1.x86_64 hplip-hpijs-3.19.12-lp152.2.3.1.x86_64 # mkdir /tmp/bug1187232 # cd /tmp/bug1187232 # cp /usr/share/cups/model/manufacturer-PPDs/hplip/hp-officejet_pro_1150c.ppd.gz . # gunzip hp-officejet_pro_1150c.ppd.gz # cp /usr/share/ghostscript/9.54.0/examples/text_graphic_image.pdf . # export PPD=/tmp/bug1187232/hp-officejet_pro_1150c.ppd # /usr/lib/cups/filter/pdftopdf 1 user title 1 options \ <text_graphic_image.pdf >pdftopdf_stdout.pdf DEBUG: pdftopdf: No FINAL_CONTENT_TYPE environment variable, could not determine whether to log pages or not, so turned off page logging. DEBUG: pdftopdf: Last filter determined by the PPD: None; FINAL_CONTENT_TYPE: (null) => pdftopdf will not log pages in page_log. DEBUG: PDF interactive form and annotation flattening done via QPDF # /usr/lib/cups/filter/gstoraster 1 user title 1 options \ <pdftopdf_stdout.pdf >gstoraster_stdout.CUPS_raster DEBUG: OUTFORMAT="<none>", so output format will be CUPS/PWG Raster DEBUG: Color Manager: Calibration Mode/Off DEBUG: Color Manager: Invalid printer name. DEBUG: Color Manager: Invalid input - Unable to find profile. DEBUG: Color Manager: ICC Profile: None DEBUG: Ghostscript using Any-Part-of-Pixel method to fill paths. DEBUG: Ghostscript command line: gs -dQUIET -dSAFER -dNOPAUSE -dBATCH -dNOINTERPOLATE -dNOMEDIAATTRS -dShowAcroForm -sstdout=%stderr -sOutputFile=%stdout -sDEVICE=cups -sMediaType=Plain -sOutputType=0 -r300x300 -dMediaPosition=7 -dDEVICEWIDTHPOINTS=612 -dDEVICEHEIGHTPOINTS=792 -dcupsBitsPerColor=8 -dcupsColorOrder=0 -dcupsColorSpace=1 -dcupsInteger0=2 -scupsString0=PlainNormalColor -scupsPageSizeName=Letter -I/usr/share/cups/fonts -c '<</.HWMargins[18.000000 36.000000 18.000000 9.000000] /Margins[0 0]>>setpagedevice' -f -_ DEBUG: envp[0]="LS_COLORS=no=00:fi=00:di=01;34:ln=00;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=41;33;01:ex=00;32:*.cmd=00;32:*.exe=01;32:*.com=01;32:*.bat=01;32:*.btm=01;32:*.dll=01;32:*.tar=00;31:*.tbz=00;31:*.tgz=00;31:*.rpm=00;31:*.deb=00;31:*.arj=00;31:*.taz=00;31:*.lzh=00;31:*.lzma=00;31:*.zip=00;31:*.zoo=00;31:*.z=00;31:*.Z=00;31:*.gz=00;31:*.bz2=00;31:*.tb2=00;31:*.tz2=00;31:*.tbz2=00;31:*.xz=00;31:*.avi=01;35:*.bmp=01;35:*.dl=01;35:*.fli=01;35:*.gif=01;35:*.gl=01;35:*.jpg=01;35:*.jpeg=01;35:*.mkv=01;35:*.mng=01;35:*.mov=01;35:*.mp4=01;35:*.mpg=01;35:*.pcx=01;35:*.pbm=01;35:*.pgm=01;35:*.png=01;35:*.ppm=01;35:*.svg=01;35:*.tga=01;35:*.tif=01;35:*.webm=01;35:*.webp=01;35:*.wmv=01;35:*.xbm=01;35:*.xcf=01;35:*.xpm=01;35:*.aiff=00;32:*.ape=00;32:*.au=00;32:*.flac=00;32:*.m4a=00;32:*.mid=00;32:*.mp3=00;32:*.mpc=00;32:*.ogg=00;32:*.voc=00;32:*.wav=00;32:*.wma=00;32:*.wv=00;32:" DEBUG: envp[1]="HOSTTYPE=x86_64" DEBUG: envp[2]="XAUTHLOCALHOSTNAME=linux-h9wr" DEBUG: envp[3]="XKEYSYMDB=/usr/X11R6/lib/X11/XKeysymDB" DEBUG: envp[4]="LANG=POSIX" DEBUG: envp[5]="WINDOWMANAGER=/usr/bin/gnome" DEBUG: envp[6]="LESS=-M -i" DEBUG: envp[7]="DISPLAY=:0" DEBUG: envp[8]="JAVA_ROOT=/usr/lib64/jvm/jre-11-openjdk" DEBUG: envp[9]="HOSTNAME=linux-h9wr" DEBUG: envp[10]="OLDPWD=/root" DEBUG: envp[11]="CONFIG_SITE=/usr/share/site/x86_64-unknown-linux-gnu" DEBUG: envp[12]="CSHEDIT=emacs" DEBUG: envp[13]="GPG_TTY=/dev/pts/2" DEBUG: envp[14]="AUDIODRIVER=pulseaudio" DEBUG: envp[15]="LESS_ADVANCED_PREPROCESSOR=no" DEBUG: envp[16]="COLORTERM=1" DEBUG: envp[17]="JAVA_HOME=/usr/lib64/jvm/jre-11-openjdk" DEBUG: envp[18]="ALSA_CONFIG_PATH=/etc/alsa-pulse.conf" DEBUG: envp[19]="MACHTYPE=x86_64-suse-linux" DEBUG: envp[20]="QEMU_AUDIO_DRV=pa" DEBUG: envp[21]="MINICOM=-c on" DEBUG: envp[22]="QT_SYSTEM_DIR=/usr/share/desktop-data" DEBUG: envp[23]="OSTYPE=linux" DEBUG: envp[24]="USER=root" DEBUG: envp[25]="PAGER=less" DEBUG: envp[26]="MORE=-sl" DEBUG: envp[27]="PWD=/tmp/bug1187232" DEBUG: envp[28]="HOME=/root" DEBUG: envp[29]="LC_CTYPE=en_US.UTF-8" DEBUG: envp[30]="HOST=linux-h9wr" DEBUG: envp[31]="XNLSPATH=/usr/share/X11/nls" DEBUG: envp[32]="XDG_DATA_DIRS=/root/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share:/usr/share" DEBUG: envp[33]="PROFILEREAD=true" DEBUG: envp[34]="FROM_HEADER=" DEBUG: envp[35]="MAIL=/var/spool/mail/root" DEBUG: envp[36]="PPD=/tmp/bug1187232/hp-officejet_pro_1150c.ppd" DEBUG: envp[37]="LESSKEY=/etc/lesskey.bin" DEBUG: envp[38]="TERM=xterm" DEBUG: envp[39]="SHELL=/bin/bash" DEBUG: envp[40]="LS_OPTIONS=-A -N --color=tty -T 0" DEBUG: envp[41]="XCURSOR_THEME=DMZ" DEBUG: envp[42]="PYTHONSTARTUP=/etc/pythonstart" DEBUG: envp[43]="SHLVL=1" DEBUG: envp[44]="MANPATH=/usr/share/man:/usr/local/man" DEBUG: envp[45]="LOGNAME=root" DEBUG: envp[46]="XAUTHORITY=/root/.xauthW4NA1N" DEBUG: envp[47]="JRE_HOME=/usr/lib64/jvm/java-11-openjdk-11" DEBUG: envp[48]="XDG_CONFIG_DIRS=/etc/xdg" DEBUG: envp[49]="PATH=/sbin:/usr/sbin:/usr/local/sbin:/root/bin:/usr/local/bin:/usr/bin:/bin" DEBUG: envp[50]="JAVA_BINDIR=/usr/lib64/jvm/jre-11-openjdk/bin" DEBUG: envp[51]="SDL_AUDIODRIVER=pulse" DEBUG: envp[52]="G_BROKEN_FILENAMES=1" DEBUG: envp[53]="HISTSIZE=10000" DEBUG: envp[54]="HISTFILESIZE=100000" DEBUG: envp[55]="CPU=x86_64" DEBUG: envp[56]="CVS_RSH=ssh" DEBUG: envp[57]="_=/usr/lib/cups/filter/gstoraster" INFO: Start rendering... INFO: Processing page 1... INFO: Processing page 2... INFO: Rendering completed /usr/lib/cups/filter/hpcups 1 user title 1 options \ <gstoraster_stdout.CUPS_raster \
hpcups_stdout.hplip-3.19.12.pcl
PAGE: 1 1 # ls -l pdftopdf_stdout.pdf gstoraster_stdout.CUPS_raster \ hpcups_stdout.hplip-3.19.12.pcl ... 22408200 Jun 14 14:24 gstoraster_stdout.CUPS_raster ... 1377317 Jun 14 14:25 hpcups_stdout.hplip-3.19.12.pcl ... 133504 Jun 14 14:22 pdftopdf_stdout.pdf # file pdftopdf_stdout.pdf gstoraster_stdout.CUPS_raster \ hpcups_stdout.hplip-3.19.12.pcl pdftopdf_stdout.pdf: PDF document, version 1.7 gstoraster_stdout.CUPS_raster: Cups Raster version 3, Little Endian, 300x300 dpi, 2400x3112 pixels 8 bits/color 24 bits/pixel ColorOrder=Chunky ColorSpace=RGB hpcups_stdout.hplip-3.19.12.pcl: HP PCL printer data ------------------------------------------------------------- I upgraded to HPLIP 3.20.11 from the OBS Printing project ------------------------------------------------------------- # osc getbinaries Printing hplip openSUSE_Leap_15.2 x86_64 # rpm -Uhv hplip-3.20.11-lp152.232.1.x86_64.rpm \ hplip-hpijs-3.20.11-lp152.232.1.x86_64.rpm \ hplip-sane-3.20.11-lp152.232.1.x86_64.rpm warning: hplip-3.20.11-lp152.232.1.x86_64.rpm: Header V3 DSA/SHA1 Signature, key ID 98c4529d: NOKEY Preparing... ################################# [100%] Updating / installing... 1:hplip-hpijs-3.20.11-lp152.232.1 ################################# [ 17%] 2:hplip-sane-3.20.11-lp152.232.1 ################################# [ 33%] 3:hplip-3.20.11-lp152.232.1 ################################# [ 50%] Cleaning up / removing... 4:hplip-3.19.12-lp152.2.3.1 ################################# [ 67%] 5:hplip-sane-3.19.12-lp152.2.3.1 ################################# [ 83%] 6:hplip-hpijs-3.19.12-lp152.2.3.1 ################################# [100%] # rpm -qa | grep ^hplip hplip-sane-3.20.11-lp152.232.1.x86_64 hplip-3.20.11-lp152.232.1.x86_64 hplip-hpijs-3.20.11-lp152.232.1.x86_64 ------------------------------------------------------------- Then I did re-run the hpcups filter ------------------------------------------------------------- # /usr/lib/cups/filter/hpcups 1 user title 1 options \ <gstoraster_stdout.CUPS_raster \
hpcups_stdout.hplip-3.20.11.pcl
PAGE: 1 1 # ls -l hpcups_stdout.* ... 1377317 Jun 14 14:25 hpcups_stdout.hplip-3.19.12.pcl ... 1377317 Jun 14 14:29 hpcups_stdout.hplip-3.20.11.pcl # diff -s hpcups_stdout.hplip-3.19.12.pcl \ hpcups_stdout.hplip-3.20.11.pcl Files hpcups_stdout.hplip-3.19.12.pcl and hpcups_stdout.hplip-3.20.11.pcl are identical ------------------------------------------------------------- So on my openSUSE Leap 15.2 x86_64 system the hpcups filter of HPLIP 3.19.12 and HPLIP 3.20.11 produced identical output. This matches that the souces of the hpcups filter did almost not change from HPLIP 3.19.12 to HPLIP 3.20.11 ------------------------------------------------------------- # diff -r -U0 hplip-3.19.12/prnt/hpcups/ \ hplip-3.20.11/prnt/hpcups/ diff -r -U0 hplip-3.19.12/prnt/hpcups/CommonDefinitions.h hplip-3.20.11/prnt/hpcups/CommonDefinitions.h --- hplip-3.19.12/prnt/hpcups/CommonDefinitions.h 2019-12-10 06:00:33.000000000 +0100 +++ hplip-3.20.11/prnt/hpcups/CommonDefinitions.h 2020-11-30 01:03:52.000000000 +0100 @@ -468,0 +469 @@ + int args_duplex_mode; diff -r -U0 hplip-3.19.12/prnt/hpcups/Hbpl1_Wrapper.cpp hplip-3.20.11/prnt/hpcups/Hbpl1_Wrapper.cpp --- hplip-3.19.12/prnt/hpcups/Hbpl1_Wrapper.cpp 2019-12-10 06:00:33.000000000 +0100 +++ hplip-3.20.11/prnt/hpcups/Hbpl1_Wrapper.cpp 2020-11-30 01:03:52.000000000 +0100 @@ -174 +174 @@ - PCLmPageContent.duplexDisposition = simplex; + PCLmPageContent.duplexDisposition = (duplexDispositionEnum)o_Hbpl1->m_JA.args_duplex_mode; diff -r -U0 hplip-3.19.12/prnt/hpcups/HPCupsFilter.cpp hplip-3.20.11/prnt/hpcups/HPCupsFilter.cpp --- hplip-3.19.12/prnt/hpcups/HPCupsFilter.cpp 2019-12-10 06:00:33.000000000 +0100 +++ hplip-3.20.11/prnt/hpcups/HPCupsFilter.cpp 2020-11-30 01:03:52.000000000 +0100 @@ -524,0 +525,13 @@ + + if((strstr(argv[5],"Duplex=DuplexTumble")) || (strstr(argv[5],"Duplex=DuplexNoTumble"))) + + { + m_JA.args_duplex_mode = 2; + + } + + else + { + m_JA.args_duplex_mode = 0; + + } ------------------------------------------------------------- -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@suse.com