[Bug 557430] New: osc 'api' incorrectly adds trailing '/'
http://bugzilla.novell.com/show_bug.cgi?id=557430 http://bugzilla.novell.com/show_bug.cgi?id=557430#c0 Summary: osc 'api' incorrectly adds trailing '/' Classification: openSUSE Product: openSUSE.org Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: BuildService AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: jnelson-suse@jamponi.net QAContact: adrian@novell.com Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4) Gecko/20091016 SUSE/3.5.4-1.1.2 Firefox/3.5.4 Near lin 2922 of commandline.py: if not url.startswith('http'): if not url.startswith('/'): url = '/' + url url = conf.config['apiurl'] + url should read: if not url.startswith('http'): if not url.startswith('/') and not conf.config['apiurl'].endswith('/'): url = '/' + url url = conf.config['apiurl'] + url because apiurl probably already ends in '/', and the server barfs if the URL starts with '//'. it's not pretty. big mess. need a mop. Reproducible: Always Steps to Reproduce: 1. 2. 3. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=557430 http://bugzilla.novell.com/show_bug.cgi?id=557430#c shuang qiu <sqiu@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sqiu@novell.com AssignedTo|bnc-team-screening@forge.pr |adrian@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=557430 http://bugzilla.novell.com/show_bug.cgi?id=557430#c1 Marcus Hüwe <suse-tux@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |suse-tux@gmx.de --- Comment #1 from Marcus Hüwe <suse-tux@gmx.de> 2009-12-10 19:42:49 UTC --- No this check is not needed - it's guaranteed that conf.config['apiurl'] doesn't end with a trailing slash (see conf.py). Which osc version are you using? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=557430 http://bugzilla.novell.com/show_bug.cgi?id=557430#c2 --- Comment #2 from Jon Nelson <jnelson-suse@jamponi.net> 2009-12-15 02:03:09 UTC --- osc-0.120-2.1.x86_64 At least with that version I am /quite/ sure the check is necessary: I can add a "print url" and it clearly outputs two '/' characters after the host. However, 0.124 doesn't exhibit the same behavior. Unfortunately, 0.124 has some other issue that prevents me from using it on this machine (the HTTPS issue). Since it appears to be fixed in 0.124, this bug can be closed (for now). -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=557430 http://bugzilla.novell.com/show_bug.cgi?id=557430#c3 --- Comment #3 from Marcus Hüwe <suse-tux@gmx.de> 2010-01-07 18:25:14 UTC --- (In reply to comment #2)
Unfortunately, 0.124 has some other issue that prevents me from using it on this machine (the HTTPS issue).
About which HTTPS issue are you talking (did you file a bug?)? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=557430 http://bugzilla.novell.com/show_bug.cgi?id=557430#c4 --- Comment #4 from Jon Nelson <jnelson-suse@jamponi.net> 2010-01-07 18:58:34 UTC --- The m2crypto / "https over proxy" issue. Perhaps it has been resolved, now. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=557430 http://bugzilla.novell.com/show_bug.cgi?id=557430#c5 --- Comment #5 from Marcus Hüwe <suse-tux@gmx.de> 2010-01-07 19:25:23 UTC --- Created an attachment (id=335437) --> (http://bugzilla.novell.com/attachment.cgi?id=335437) experimental patch I wrote a small (experimental!) patch which enables proxy support again. But it's really untested and it uses the default M2Crypto.httpslib.ProxyHTTPSConnection class, so there might be issues with self-signed certificates etc. This needs some further investigation. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=557430 http://bugzilla.novell.com/show_bug.cgi?id=557430#c6 --- Comment #6 from Marcus Hüwe <suse-tux@gmx.de> 2010-01-09 10:16:34 UTC --- Btw. yesterday I committed a patch which should fully enable proxy support again (see http://gitorious.org/opensuse/osc/commit/52b22b19a51ac81f27cecdbf30829e3ec69...) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=557430 http://bugzilla.novell.com/show_bug.cgi?id=557430#c7 Marcus Hüwe <suse-tux@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #7 from Marcus Hüwe <suse-tux@gmx.de> 2010-02-02 21:48:28 UTC --- I think we can close this bug (if not please reopen). -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com