https://bugzilla.novell.com/show_bug.cgi?id=447434 User sbrabec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=447434#c1 Stanislav Brabec <sbrabec@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |coolo@novell.com --- Comment #1 from Stanislav Brabec <sbrabec@novell.com> 2008-11-24 11:46:29 MST --- To Coolo: As version 1.0.0 does not support Flash 10 well (and several new features does not support at all, e. g. windowless mode), I propose to update after running a test suite (to verify that clicks, menu and focus work in all major plugins). In past, I rejected update to version 1.1.2, as there was regression (impossible to get Flash menu). Now it seems to be fixed. nspluginwrapper is a complex application and any backporting is more dangerous than update. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=447434 User coolo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=447434#c2 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|coolo@novell.com | --- Comment #2 from Stephan Kulow <coolo@novell.com> 2008-11-25 03:22:42 MST --- I got many complaints about flash on x86_64, so I would be a favor of any change that imrpves the situation -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=447434 User sbrabec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=447434#c4 --- Comment #4 from Stanislav Brabec <sbrabec@novell.com> 2008-11-26 05:40:00 MST --- Reply from Gwenole Beauchesne: Thanks for spotting this bug. The situation is even worse than that: 1) I am actually getting crashes because I should make NPN_ReleaseObject() calls asynchronous 2) The XEMBED hack will also require Gtk equivalent to the Xt focus machinery. I normally have that in some patches already from older experiments. 3) In XEMBED hack mode, it should be best to avoid Firefox use the GtkXtBin object because it starts another 25 ms timer that is not necessary for Gtk plugins. i.e. it's not really a power efficient thing to awake the plugin if we know it has nothing to do in the first place. Besides, commit rev 733 is actually wrong and should be reverted. Then (1) can be implemented in two ways: (i) schedule the NPN_ReleaseObject() invoke through an idle function. This is not very efficient if we have to create/destroy the idle source each time an async NPN_ReleaseObject() is needed. (ii) schedule it through an internal "pipe" with a GSource listening on it and then dispatching the async call (i) is very simple to implement, (ii) is longer but it should be useful to implement a more correct NPP_HandleEvent() at the same time and actually get modal Gtk windows working with windowless plugins... Lastly, I am starting to wonder if I shouldn't actually revert the XEMBED hack mode and let distributors fix Firefox instead. The very minimal thing to do is to allow calls to NPP_SetWindow() with NULL NPWindow::window fields. And, if someone is motivated enough, a better fix should be done in Gtk2, IMHO. If any of those is done, then USE_XEMBED_HACK can be disabled and everything should work again correctly. I don't like workarounds, they generally come back into your face sooner or later, and badly in general. What you have just reported to me is a clear example. :-( Note: (2) and (3) have the same cause (the need for the XEMBED "hack mode"). (1) is another bug. Regards, Gwenole. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=447434 Stanislav Brabec <sbrabec@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.