[Bug 1038403] New: NetworkManager: Usage of systemctrl enable should be changed to %sytemd_add_pre/post
http://bugzilla.suse.com/show_bug.cgi?id=1038403 Bug ID: 1038403 Summary: NetworkManager: Usage of systemctrl enable should be changed to %sytemd_add_pre/post Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Other Assignee: sckang@suse.com Reporter: behlert@suse.com QA Contact: qa-bugs@suse.de CC: fcrozat@suse.com Found By: --- Blocker: --- "systemctl preset-all" is intended to return service states to a factory state based on presets. But currently we can see breakages in some products due to services that are not following the guidelines as described in https://en.opensuse.org/openSUSE:Systemd_packaging_guidelines#Enabling_syste... The package NetworkManager was identified to use "systemctl enable" in its spec-file, and it should get replaced by the proper use of %sytemd_add_pre/post and preset. Please check your package, thanks. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1038403 Stefan Behlert <behlert@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://fate.suse.com/32214 | |0 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1038403 http://bugzilla.suse.com/show_bug.cgi?id=1038403#c1 --- Comment #1 from Jonathan Kang <sckang@suse.com> --- (In reply to Stefan Behlert from comment #0)
"systemctl preset-all" is intended to return service states to a factory state based on presets. But currently we can see breakages in some products due to services that are not following the guidelines as described in
https://en.opensuse.org/openSUSE: Systemd_packaging_guidelines#Enabling_systemd_unit_files
Does this support condition check? We need to enable NetworkManager under certain circumstances. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1038403 http://bugzilla.suse.com/show_bug.cgi?id=1038403#c2 --- Comment #2 from Swamp Workflow Management <swamp@suse.de> --- This is an autogenerated message for OBS integration: This bug (1038403) was mentioned in https://build.opensuse.org/request/show/704415 Factory / NetworkManager -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1038403 http://bugzilla.suse.com/show_bug.cgi?id=1038403#c3 Jonathan Kang <sckang@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Jonathan Kang <sckang@suse.com> --- fixed. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1038403 http://bugzilla.suse.com/show_bug.cgi?id=1038403#c5 --- Comment #5 from Jonathan Kang <songchuan.kang@suse.com> --- (In reply to Dominique Leuenberger from comment #4)
This results in 'fun' issues as seen in https://openqa.opensuse.org/tests/1087298#step/yast2_lan/13
systemctl is-active NetworkManager claims NM is an enabled service. AS can be seen in the 'first_boot' test of this test run, NM is indeed enabled (see the nm-applet in the tray) - but YaST is not aware that networking was switched to NEtworkManager and does expect to be able to configure wicked (which is also running)
According to y2log, network.service became the alias of wicked.service instead of NetworkManager.service. So wicked thought NetworkManager is not running. Looking into it. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1038403 http://bugzilla.suse.com/show_bug.cgi?id=1038403#c7 Knut Alejandro Anderssen González <knut.anderssen@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |knut.anderssen@suse.com --- Comment #7 from Knut Alejandro Anderssen González <knut.anderssen@suse.com> --- (In reply to Jonathan Kang from comment #6)
Looks like the systemd preset "conflicts" with Yast. Yast has a set of rules to determine which network service to use(desktop environment makes a defference).
It really conflicts with YaST?, I mean, each backend should conflict with each other, that is, both should not be running at the same time. YaST could show a warning and could ask the user if wanted to disable the service that is not linked to network.service...
So maybe the systemd preset won't make any sense in such a scenario, or something (stopping and disabling NM if it's running)should be done if we want to use the systemd preset.
-- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1038403 http://bugzilla.suse.com/show_bug.cgi?id=1038403#c8 --- Comment #8 from Jonathan Kang <songchuan.kang@suse.com> --- (In reply to Knut Alejandro Anderssen González from comment #7)
(In reply to Jonathan Kang from comment #6)
Looks like the systemd preset "conflicts" with Yast. Yast has a set of rules to determine which network service to use(desktop environment makes a defference).
It really conflicts with YaST?, I mean, each backend should conflict with each other, that is, both should not be running at the same time.
A bit explaination about this bug, with systemd presets, NetworkManager is enabled all the time. In a tumbleweed with xfce as the desktop environment, NetworkManager and wicked are both installed. And when users open yast network, no dialog pops up saying that network is controlled by NetworkManager. I meant the way systemd preset enables NetworkManager conflicts with how yast network module choose to enable which service(wicked or NetworkManager). And sure, they should conflict with each other. But there should be a central place to manage this. I'm thinking about either 1. Not implementing the systemd preset for NetworkManager at all. 2. yast network module should disable NetworkManager and start wicked at certain circumstances, for example in xfce, wicked is preferred as the network manager. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1038403 David Diaz <dgonzalez@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://trello.com/c/sHkqLN | |4q/3344-osdistribution-p5-1 | |141433-get-no-hint-that-net | |work-connection-is-made-by- | |networkmanager-when-start-y | |ast-network-management CC| |dgonzalez@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1038403 http://bugzilla.suse.com/show_bug.cgi?id=1038403#c9 --- Comment #9 from David Diaz <dgonzalez@suse.com> --- Hi!
(In reply to Knut Alejandro Anderssen González from comment #7)
(In reply to Jonathan Kang from comment #6)
Looks like the systemd preset "conflicts" with Yast. Yast has a set of rules to determine which network service to use(desktop environment makes a defference).
It really conflicts with YaST?, I mean, each backend should conflict with each other, that is, both should not be running at the same time.
A bit explaination about this bug, with systemd presets, NetworkManager is enabled all the time. In a tumbleweed with xfce as the desktop environment, NetworkManager and wicked are both installed. And when users open yast network, no dialog pops up saying that network is controlled by NetworkManager.
I meant the way systemd preset enables NetworkManager conflicts with how yast network module choose to enable which service(wicked or NetworkManager). And sure, they should conflict with each other. But there should be a central place to manage this.
I'm thinking about either 1. Not implementing the systemd preset for NetworkManager at all. 2. yast network module should disable NetworkManager and start wicked at certain circumstances, for example in xfce, wicked is preferred as the network manager.
As Knut said in comment #7, we at YaST team only can take care about
show a warning and could ask the user if wanted to disable the service that is not linked to network.service
I linked our Trello card for this purpose. Thanks! -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1038403 http://bugzilla.suse.com/show_bug.cgi?id=1038403#c10 --- Comment #10 from Jonathan Kang <songchuan.kang@suse.com> --- (In reply to David Diaz from comment #9)
As Knut said in comment #7, we at YaST team only can take care about
show a warning and could ask the user if wanted to disable the service that is not linked to network.service
I linked our Trello card for this purpose.
Thanks!
Is it possible to disable NetworkManager when NM is not supposed to be used? The systemd preset simply enables NM by default in all circumstances. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1038403 https://bugzilla.suse.com/show_bug.cgi?id=1038403#c11 Jonathan Kang <songchuan.kang@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #11 from Jonathan Kang <songchuan.kang@suse.com> --- This has been fixed in openSUSE:Factory. Closing. -- You are receiving this mail because: You are on the CC list for the bug.
participants (2)
-
bugzilla_noreply＠novell.com -
bugzilla_noreply＠suse.com