[Bug 295947] New: iptables: broken specfile
https://bugzilla.novell.com/show_bug.cgi?id=295947 Summary: iptables: broken specfile Product: openSUSE 10.3 Version: Alpha 5 Platform: x86 OS/Version: All Status: NEW Severity: Major Priority: P5 - None Component: Network AssignedTo: prusnak@novell.com ReportedBy: jengelh@gmx.de QAContact: qa@suse.de CC: bnc-team-screening@forge.provo.novell.com Found By: Beta-Customer The specfile for iptables 1.3.8 contains: for file in extensions/*.c; do sed -i 's:_init(:static __attribute__((constructor)) _init(:' $file done This is _totally_ bogus and must be removed. Many functions are void _init(void) {} expanding that would yield void static __attribute__((constructor)) _init(void) {} and I am not sure "void static" is a valid combination ("static void" is). Also, the sed line totally breaks functions that contain _init in their name, e.g. static void connlimit_init(struct ipt_entry_match *match, unsigned int *nfc) Last but not least, replacing _init with __attribute__((constructor)) is already done inside iptables: include/xtables.h: #define _init __attribute__((constructor)) my_init so please do not break it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=295947#c1
Pavol Rusnak
https://bugzilla.novell.com/show_bug.cgi?id=295947
Jan Engelhardt
participants (1)
-
bugzilla_noreply@novell.com