http://bugzilla.suse.com/show_bug.cgi?id=1066090 Marcus Meissner changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bnc-team-screening@forge.pr |rguenther@suse.com |ovo.novell.com | -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1066090 http://bugzilla.suse.com/show_bug.cgi?id=1066090#c2 Bin Liu changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(bliu@suse.com) | --- Comment #2 from Bin Liu --- Hi, is this what you want? sam.c: In function ‘sam_cmap_update_key’: sam.c:155:46: warning: ‘%s’ directive output may be truncated writing 8 bytes into a region of size between 1 and 255 [-Wformat-truncation=] snprintf(key_name, CMAP_KEYNAME_MAXLEN, "%s%s", sam_internal_data.cmap_pid_path, ^~ "recovery"); ~~~~~~~~~~ sam.c:155:3: note: ‘snprintf’ output between 9 and 263 bytes into a destination of size 255 snprintf(key_name, CMAP_KEYNAME_MAXLEN, "%s%s", sam_internal_data.cmap_pid_path, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ "recovery"); the code is as following: char key_name[CMAP_KEYNAME_MAXLEN]; switch (key) { case SAM_CMAP_KEY_RECOVERY: svalue = ssvalue[SAM_RP_MASK (sam_internal_data.recovery_policy)]; snprintf(key_name, CMAP_KEYNAME_MAXLEN, "%s%s", sam_internal_data.cmap_pid_path, "recovery"); you can find the code at[1] [1]https://build.opensuse.org/package/show/home:BinLiu/corosync-master -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1066090 http://bugzilla.suse.com/show_bug.cgi?id=1066090#c4 Bin Liu changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(bliu@suse.com) | --- Comment #4 from Bin Liu --- (In reply to Richard Biener from comment #3)

Please provide preprocessed source.

The project you link to doesn't even build pass the configure stage.

It needs kronosnet, which is also in my home project[1], the build failure is because [1] is not in openSUSE repo yet. I just build the package [1]locally on Tumbweed and then build corosync. In fact the waring part has nothing to do with kronosnet. It is just a warning from gcc by using snprintf, and I just want to make the warning disappear. If you think the issue is not a bug, feel free to close. thanks. [1]https://build.opensuse.org/package/show/home:BinLiu/kronosnet -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1066090 http://bugzilla.suse.com/show_bug.cgi?id=1066090#c6 --- Comment #6 from Bin Liu --- (In reply to Richard Biener from comment #5)

I can't tell if the issue is a bug in GCC or a bug in corosync. This is what I need a testcase for. A testcase is preprocessed source that I can investigate locally without all the corosync/kronosnet code.

You can get preprocessed source by appending -v -save-temps to the compiler command that provokes the warning, then look for a .i (or .ii if C++) file with the same basename as the source file. Please attach that file to the bug and paste the full output of the compiler command (the -v will print extra diagnostics that are useful for me).

Thanks.

Sorry, can you tell me How I add this "-v -save-temps" option when I use make, by adding this to CFLAGS? Or any other operations? -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1066090 http://bugzilla.suse.com/show_bug.cgi?id=1066090#c8 --- Comment #8 from Bin Liu --- Sorry for the latency, I also find another warning: corosync-quorumtool.c:527:8: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=] "%s,%s,%s", ^~~~~~~~~~ corosync-quorumtool.c:526:6: note: ‘snprintf’ output between 7 and 10 bytes into a destination of size 9 snprintf(buf, sizeof(buf) - 1, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ "%s,%s,%s", ~~~~~~~~~~~ info[i].flags & VOTEQUORUM_INFO_QDEVICE_ALIVE?"A":"NA", ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ info[i].flags & VOTEQUORUM_INFO_QDEVICE_CAST_VOTE?"V":"NV", ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ info[i].flags & VOTEQUORUM_INFO_QDEVICE_MASTER_WINS?"MW":"NMW"); after adding "-v -save-temps", here is the output: #gcc -DHAVE_CONFIG_H -I. -I../include/corosync -I../include -I../include -I../include/corosync -I../include/corosync -g -O2 -fPIC -DPIC -fPIE -O3 -ggdb3 -Wall -Wshadow -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wwrite-strings -Wcast-align -Wbad-function-cast -Wmissing-format-attribute -Wformat=2 -Wformat-security -Wformat-nonliteral -Wno-long-long -Wno-strict-aliasing -v -save-temps -c -o corosync-cfgtool.o corosync-cfgtool.c gcc -DHAVE_CONFIG_H -I. -I../include/corosync -I../include -I../include -I../include/corosync -I../include/corosync -g -O2 -fPIC -DPIC -fPIE -O3 -ggdb3 -Wall -Wshadow -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wwrite-strings -Wcast-align -Wbad-function-cast -Wmissing-format-attribute -Wformat=2 -Wformat-security -Wformat-nonliteral -Wno-long-long -Wno-strict-aliasing -v -save-temps -c -o corosync-cfgtool.o corosync-cfgtool.c Using built-in specs. COLLECT_GCC=gcc OFFLOAD_TARGET_NAMES=hsa:nvptx-none Target: x86_64-suse-linux Configured with: ../configure --prefix=/usr --infodir=/usr/share/info --mandir=/usr/share/man --libdir=/usr/lib64 --libexecdir=/usr/lib64 --enable-languages=c,c++,objc,fortran,obj-c++,ada,go --enable-offload-targets=hsa,nvptx-none=/usr/nvptx-none, --without-cuda-driver --enable-checking=release --disable-werror --with-gxx-include-dir=/usr/include/c++/7 --enable-ssp --disable-libssp --disable-libvtv --disable-libcc1 --enable-plugin --with-bugurl=http://bugs.opensuse.org/ --with-pkgversion='SUSE Linux' --with-slibdir=/lib64 --with-system-zlib --enable-__cxa_atexit --enable-libstdcxx-allocator=new --disable-libstdcxx-pch --enable-version-specific-runtime-libs --with-gcc-major-version-only --enable-linker-build-id --enable-linux-futex --enable-gnu-indirect-function --program-suffix=-7 --without-system-libunwind --enable-multilib --with-arch-32=x86-64 --with-tune=generic --build=x86_64-suse-linux --host=x86_64-suse-linux Thread model: posix gcc version 7.2.1 20171005 [gcc-7-branch revision 253439] (SUSE Linux) COLLECT_GCC_OPTIONS='-D' 'HAVE_CONFIG_H' '-I' '.' '-I' '../include/corosync' '-I' '../include' '-I' '../include' '-I' '../include/corosync' '-I' '../include/corosync' '-g' '-O2' '-D' 'PIC' '-fPIE' '-O3' '-ggdb3' '-Wall' '-Wshadow' '-Wmissing-prototypes' '-Wmissing-declarations' '-Wstrict-prototypes' '-Wpointer-arith' '-Wwrite-strings' '-Wcast-align' '-Wbad-function-cast' '-Wsuggest-attribute=format' '-Wformat=2' '-Wformat-security' '-Wformat-nonliteral' '-Wno-long-long' '-Wno-strict-aliasing' '-v' '-save-temps' '-c' '-o' 'corosync-cfgtool.o' '-mtune=generic' '-march=x86-64' /usr/lib64/gcc/x86_64-suse-linux/7/cc1 -E -quiet -v -I . -I ../include/corosync -I ../include -I ../include -I ../include/corosync -I ../include/corosync -dD -D HAVE_CONFIG_H -D PIC corosync-cfgtool.c -mtune=generic -march=x86-64 -Wall -Wshadow -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wwrite-strings -Wcast-align -Wbad-function-cast -Wsuggest-attribute=format -Wformat=2 -Wformat-security -Wformat-nonliteral -Wno-long-long -Wno-strict-aliasing -fPIE -g -ggdb3 -fworking-directory -O2 -O3 -fpch-preprocess -o corosync-cfgtool.i ignoring duplicate directory "../include" ignoring duplicate directory "../include/corosync" ignoring duplicate directory "../include/corosync" #include "..." search starts here: #include <...> search starts here: . ../include/corosync ../include /usr/lib64/gcc/x86_64-suse-linux/7/include /usr/local/include /usr/lib64/gcc/x86_64-suse-linux/7/include-fixed /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/include /usr/include End of search list. COLLECT_GCC_OPTIONS='-D' 'HAVE_CONFIG_H' '-I' '.' '-I' '../include/corosync' '-I' '../include' '-I' '../include' '-I' '../include/corosync' '-I' '../include/corosync' '-g' '-O2' '-D' 'PIC' '-fPIE' '-O3' '-ggdb3' '-Wall' '-Wshadow' '-Wmissing-prototypes' '-Wmissing-declarations' '-Wstrict-prototypes' '-Wpointer-arith' '-Wwrite-strings' '-Wcast-align' '-Wbad-function-cast' '-Wsuggest-attribute=format' '-Wformat=2' '-Wformat-security' '-Wformat-nonliteral' '-Wno-long-long' '-Wno-strict-aliasing' '-v' '-save-temps' '-c' '-o' 'corosync-cfgtool.o' '-mtune=generic' '-march=x86-64' /usr/lib64/gcc/x86_64-suse-linux/7/cc1 -fpreprocessed corosync-cfgtool.i -quiet -dumpbase corosync-cfgtool.c -mtune=generic -march=x86-64 -auxbase-strip corosync-cfgtool.o -g -ggdb3 -O2 -O3 -Wall -Wshadow -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wwrite-strings -Wcast-align -Wbad-function-cast -Wsuggest-attribute=format -Wformat=2 -Wformat-security -Wformat-nonliteral -Wno-long-long -Wno-strict-aliasing -version -fPIE -o corosync-cfgtool.s GNU C11 (SUSE Linux) version 7.2.1 20171005 [gcc-7-branch revision 253439] (x86_64-suse-linux) compiled by GNU C version 7.2.1 20171005 [gcc-7-branch revision 253439], GMP version 6.1.2, MPFR version 3.1.6, MPC version 1.0.3, isl version isl-0.18-GMP GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072 GNU C11 (SUSE Linux) version 7.2.1 20171005 [gcc-7-branch revision 253439] (x86_64-suse-linux) compiled by GNU C version 7.2.1 20171005 [gcc-7-branch revision 253439], GMP version 6.1.2, MPFR version 3.1.6, MPC version 1.0.3, isl version isl-0.18-GMP GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072 Compiler executable checksum: 64496092bc8bea8dc24eaabb54fcae78 COLLECT_GCC_OPTIONS='-D' 'HAVE_CONFIG_H' '-I' '.' '-I' '../include/corosync' '-I' '../include' '-I' '../include' '-I' '../include/corosync' '-I' '../include/corosync' '-g' '-O2' '-D' 'PIC' '-fPIE' '-O3' '-ggdb3' '-Wall' '-Wshadow' '-Wmissing-prototypes' '-Wmissing-declarations' '-Wstrict-prototypes' '-Wpointer-arith' '-Wwrite-strings' '-Wcast-align' '-Wbad-function-cast' '-Wsuggest-attribute=format' '-Wformat=2' '-Wformat-security' '-Wformat-nonliteral' '-Wno-long-long' '-Wno-strict-aliasing' '-v' '-save-temps' '-c' '-o' 'corosync-cfgtool.o' '-mtune=generic' '-march=x86-64' /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/as -v -I . -I ../include/corosync -I ../include -I ../include -I ../include/corosync -I ../include/corosync --64 -o corosync-cfgtool.o corosync-cfgtool.s GNU assembler version 2.29.1 (x86_64-suse-linux) using BFD version (GNU Binutils; openSUSE Tumbleweed) 2.29.1 COMPILER_PATH=/usr/lib64/gcc/x86_64-suse-linux/7/:/usr/lib64/gcc/x86_64-suse-linux/7/:/usr/lib64/gcc/x86_64-suse-linux/:/usr/lib64/gcc/x86_64-suse-linux/7/:/usr/lib64/gcc/x86_64-suse-linux/:/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ LIBRARY_PATH=/usr/lib64/gcc/x86_64-suse-linux/7/:/usr/lib64/gcc/x86_64-suse-linux/7/../../../../lib64/:/lib/../lib64/:/usr/lib/../lib64/:/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/lib/:/usr/lib64/gcc/x86_64-suse-linux/7/../../../:/lib/:/usr/lib/ COLLECT_GCC_OPTIONS='-D' 'HAVE_CONFIG_H' '-I' '.' '-I' '../include/corosync' '-I' '../include' '-I' '../include' '-I' '../include/corosync' '-I' '../include/corosync' '-g' '-O2' '-D' 'PIC' '-fPIE' '-O3' '-ggdb3' '-Wall' '-Wshadow' '-Wmissing-prototypes' '-Wmissing-declarations' '-Wstrict-prototypes' '-Wpointer-arith' '-Wwrite-strings' '-Wcast-align' '-Wbad-function-cast' '-Wsuggest-attribute=format' '-Wformat=2' '-Wformat-security' '-Wformat-nonliteral' '-Wno-long-long' '-Wno-strict-aliasing' '-v' '-save-temps' '-c' '-o' 'corosync-cfgtool.o' '-mtune=generic' '-march=x86-64' -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1066090 Bin Liu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1066090 http://bugzilla.suse.com/show_bug.cgi?id=1066090#c14 Bin Liu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #14 from Bin Liu --- close this bug as sr to OBS got accepted. -- You are receiving this mail because: You are on the CC list for the bug.