[Bug 465113] New: kernel/scripts: various
https://bugzilla.novell.com/show_bug.cgi?id=465113 Summary: kernel/scripts: various Product: openSUSE 11.2 Version: unspecified Platform: All OS/Version: Linux Status: NEW Severity: Normal Priority: P5 - None Component: Kernel AssignedTo: dgollub@novell.com ReportedBy: jengelh@medozas.de QAContact: qa@suse.de Found By: Beta-Customer scripts/compute-PATCHVERSION.sh does not play well when SRCVERSION is something like "2.6.25.20" -- it creates an RPMVERSION of 2.6.2520, which is wrong. set -- $(IFS=.; echo $SRCVERSION) VERSION=$1 PATCHLEVEL=$2 SUBLEVEL=$3 EXTRAVERSION=$4 Needs to be done differently; similar problem will arise when using, e.g. SRCVERSION="2.6.25-mm1" where the -mm1 will not end up in EXTRAVERSION but the SUBLEVEL. The other thing I noticed is that "<RELEASE>" in kernel-binary.spec.in will not get substituted/removed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465113 User jengelh@medozas.de added comment https://bugzilla.novell.com/show_bug.cgi?id=465113#c1 --- Comment #1 from Jan Engelhardt <jengelh@medozas.de> 2009-01-11 18:55:52 MST --- Argh, yet another headcase... # All supported modules which are not core modules belong in kernel-default. comm -3 <(sort %my_builddir/supported-modules) \ <(sort %my_builddir/base-modules) \ > %my_builddir/main-modules causes leading spaces to be emitted into main-modules, and symsets.pl does not strip them so objdump really chokes and dies on it. objdump: ' /lib/modules/2.6.28-default/kernel/arch/x86/kernel/cpuid.ko' not found objdump returned an error Were the scripts actually tested? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465113 User jblunck@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465113#c2 --- Comment #2 from Jan Blunck <jblunck@novell.com> 2009-01-21 08:12:41 MST --- Created an attachment (id=266537) --> (https://bugzilla.novell.com/attachment.cgi?id=266537) Proposed patch Does that patch help your problem with compute-PATCHVERSION.sh ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465113 User jblunck@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465113#c3 --- Comment #3 from Jan Blunck <jblunck@novell.com> 2009-01-21 08:15:24 MST --- The "<RELEASE>" string doesn't get substituted since it is interpreted by the openSUSE Buildservice. The scripts are constantly test since SUSE 4.2 ;) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465113 User jengelh@medozas.de added comment https://bugzilla.novell.com/show_bug.cgi?id=465113#c4 Jan Engelhardt <jengelh@medozas.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lnussel@novell.com --- Comment #4 from Jan Engelhardt <jengelh@medozas.de> 2009-01-21 08:40:44 MST --- Well that's pretty awkward. Why does not OBS just replace whatever is in the release string instead of relying on <RELEASE>? The use of <RELEASE> just breaks about any non-OBS building, and that's truly horrible, even if I only care about lbuild. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465113 User jengelh@medozas.de added comment https://bugzilla.novell.com/show_bug.cgi?id=465113#c5 --- Comment #5 from Jan Engelhardt <jengelh@medozas.de> 2009-01-21 08:46:31 MST --- Created an attachment (id=266548) --> (https://bugzilla.novell.com/attachment.cgi?id=266548) better patch And no, the patch does not quite do the right thing either -- consider "2.6.23a.15". Here is a better patch that does The Right Thing™. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465113 User jengelh@medozas.de added comment https://bugzilla.novell.com/show_bug.cgi?id=465113#c6 Jan Engelhardt <jengelh@medozas.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #266548|0 |1 is obsolete| | --- Comment #6 from Jan Engelhardt <jengelh@medozas.de> 2009-01-21 08:49:20 MST --- Created an attachment (id=266550) --> (https://bugzilla.novell.com/attachment.cgi?id=266550) patch Spoke to soon. But, all that was missing was a ",4". Added now. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465113 User jengelh@medozas.de added comment https://bugzilla.novell.com/show_bug.cgi?id=465113#c7 --- Comment #7 from Jan Engelhardt <jengelh@medozas.de> 2009-01-21 08:52:03 MST --- I give up. That's why I don't do shell. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465113 Daniel Gollub <dgollub@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dgollub@novell.com AssignedTo|dgollub@novell.com |jblunck@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465113 User jblunck@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465113#c8 Jan Blunck <jblunck@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jblunck@novell.com |dgollub@novell.com --- Comment #8 from Jan Blunck <jblunck@novell.com> 2009-01-21 09:11:26 MST --- Re comment #4: Because we put non numeric $EXTRAVERSION into the rpm release instead of the version. Therefore the OBS needs to know what to substitute. BTW: I don't want to have alphanumeric SUBLEVEL versions therefore I won't take your patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465113 Jan Blunck <jblunck@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|dgollub@novell.com |jblunck@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465113 User jengelh@medozas.de added comment https://bugzilla.novell.com/show_bug.cgi?id=465113#c9 --- Comment #9 from Jan Engelhardt <jengelh@medozas.de> 2009-01-21 09:23:53 MST --- Upstream is to decide what goes into a SUBLEVEL or not. Though it never happened, I think, in my humble opinion, that it is most wise and foresighted to split, or substitute, on non-words rather than only-dots. $ echo '2.6.29a.15-rc1' | perl -lpe 's/^(\w+)\W+(\w+)\W+(\w+)(.*)/$1 $2 $3 $4/' 2 6 29a .15-rc1 $ echo '2.6.29-rc1' | perl -lpe 's/^(\w+)\W+(\w+)\W+(\w+)(.*)/$1 $2 $3 $4/' 2 6 29 -rc1 I hope this regex now does the job, correctly so. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465113 Jan Blunck <jblunck@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #266550|0 |1 is patch| | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com