[Bug 529515] New: pcp-2.5.0-129.13: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=529515 Summary: pcp-2.5.0-129.13: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package pcp-2.5.0-129.13 For source code file pcp-2.5.0/src/pmdas/sendmail/sendmail.c around line 320 is the source code for the function do_sendmail_cf. I notice the following line of code if ((fp = fopen("/etc/sendmail.cf", "r")) == NULL) { but I notice no matching call to fclose. This looks like a resource leak to me. Suggest add call to fclose. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=529515 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |rw@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=529515 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=529515#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:54:56 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=529515 https://bugzilla.novell.com/show_bug.cgi?id=529515#c2 Raymund Will <rw@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |UPSTREAM --- Comment #2 from Raymund Will <rw@suse.com> 2012-09-21 16:22:23 UTC --- Factory has been updated to 'pcp-3.6.5' in the meantime... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com