[Bug 820454] New: [PATCH] systemd assertion fail on running systemd-nspawn on /var/tmp/build-root
https://bugzilla.novell.com/show_bug.cgi?id=820454 https://bugzilla.novell.com/show_bug.cgi?id=820454#c0 Summary: [PATCH] systemd assertion fail on running systemd-nspawn on /var/tmp/build-root Classification: openSUSE Product: openSUSE Factory Version: 13.1 Milestone 0 Platform: Other OS/Version: Other Status: NEW Severity: Critical Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: mvyskocil@suse.com QAContact: qa-bugs@suse.de Found By: --- Blocker: --- Hi Frederic, during a well known IO performance topic, I wanted to check what happens in case something bad happens to systemd as PID1. I did not want to bother with making a full lxc container, so I've just called osc build -x gdb -x strace -x systemd on devel:libraries:c_c++/zlib source code. However the nspawn got aborted with systemd-nspawn -D /var/tmp/build-root /bin/systemd Spawning namespace container on /var/tmp/build-root (console is /dev/pts/5). /etc/localtime is not a symlink, not updating container timezone. systemd 202 running in system mode. (+PAM +LIBWRAP +AUDIT +SELINUX +IMA +SYSVINIT +LIBCRYPTSETUP +GCRYPT +ACL +XZ) Detected virtualization 'systemd-nspawn'. Welcome to Linux! /etc/mtab is not a symlink or not pointing to /proc/self/mounts. This is not supported anymore. Please make sure to replace this file by a symlink to avoid incorrect or misleading mount(8) output. Assertion 'u' failed at src/core/unit.c:1835, function unit_add_dependency_by_name(). Aborting. Caught <ABRT>, dumped core as pid 8. Freezing execution. Looking at core, it was easy to find a guilty code, the backtrace look like #7 0x00000000004785da in unit_add_dependency_by_name (u=0x0, d=d@entry=UNIT_WANTS, name=name@entry=0x48e582 "remote-fs-pre.target", path=path@entry=0x0, add_reference=add_reference@entry=true) at src/core/unit.c:1835 #8 0x0000000000425326 in sysv_parse_insserv_conf (mgr=mgr@entry=0x23cd540, filename=0x48e53a "/etc/insserv.conf") at src/core/service.c:3553 #9 0x0000000000425a05 in sysv_facility_in_insserv_conf (mgr=0x23cd540) at src/core/service.c:3612 #10 service_enumerate (m=0x23cd540) at src/core/service.c:3778 #11 0x000000000040f374 in manager_enumerate (m=0x23cd540) at src/core/manager.c:740 #12 0x0000000000411208 in manager_startup (m=0x23cd540, serialization=0x0, fds=0x7f31e9c25020) at src/core/manager.c:853 #13 0x000000000040aaaf in main (argc=1, argv=0x7fff36cc9878) at src/core/main.c:1629 so the line with a bug is in #ifdef HAVE_SYSV_COMPAT static void sysv_parse_insserv_conf(Manager *mgr, const char* filename) { ... u = manager_get_unit(mgr, SPECIAL_REMOTE_FS_TARGET); unit_add_dependency_by_name(u, UNIT_WANTS, SPECIAL_REMOTE_FS_PRE_TARGET, NULL, true); free (facility); So I'd say attached (untested) fix will help to prevent the issue. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820454 https://bugzilla.novell.com/show_bug.cgi?id=820454#c1 --- Comment #1 from Michal Vyskocil <mvyskocil@suse.com> 2013-05-17 15:13:30 UTC --- Created an attachment (id=539845) --> (http://bugzilla.novell.com/attachment.cgi?id=539845) fix an abortion in such case -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820454 https://bugzilla.novell.com/show_bug.cgi?id=820454#c Michal Vyskocil <mvyskocil@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |fcrozat@suse.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820454 https://bugzilla.novell.com/show_bug.cgi?id=820454#c2 --- Comment #2 from Frederic Crozat <fcrozat@suse.com> 2013-05-17 15:35:57 UTC --- oops, blame me for incorrectly rebasing my own patch.. I'll look at it.. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820454 https://bugzilla.novell.com/show_bug.cgi?id=820454#c3 --- Comment #3 from Frederic Crozat <fcrozat@suse.com> 2013-05-17 16:08:01 UTC --- test package with a fixed patch should be available in home:fcrozat:branches:Base:System / systemd in a few minutes.. please test -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820454 https://bugzilla.novell.com/show_bug.cgi?id=820454#c4 --- Comment #4 from Michal Vyskocil <mvyskocil@suse.com> 2013-05-20 07:04:49 UTC --- Tested with your package and original /etc/innserv.conf and crash is over, feel free to close. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820454 https://bugzilla.novell.com/show_bug.cgi?id=820454#c5 --- Comment #5 from Frederic Crozat <fcrozat@suse.com> 2013-05-21 09:01:00 UTC --- Thanks, pushed with sr 176236 I really need to rewrite this entire patch to use systemd-generator instead.. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820454 https://bugzilla.novell.com/show_bug.cgi?id=820454#c6 --- Comment #6 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-05-21 12:00:08 CEST --- This is an autogenerated message for OBS integration: This bug (820454) was mentioned in https://build.opensuse.org/request/show/176241 Factory / systemd -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820454 https://bugzilla.novell.com/show_bug.cgi?id=820454#c7 Frederic Crozat <fcrozat@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #7 from Frederic Crozat <fcrozat@suse.com> 2013-05-21 10:05:09 UTC --- (forgot to close it) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820454 https://bugzilla.novell.com/show_bug.cgi?id=820454#c8 Frederic Crozat <fcrozat@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #8 from Frederic Crozat <fcrozat@suse.com> 2013-06-12 10:59:11 UTC --- requesting maintenance update for 12.3 : mr #178808 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820454 https://bugzilla.novell.com/show_bug.cgi?id=820454#c9 Frederic Crozat <fcrozat@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEEDINFO InfoProvider| |maintenance@opensuse.org --- Comment #9 from Frederic Crozat <fcrozat@suse.com> 2013-06-12 10:59:58 UTC --- got confirmation bug was present in 12.3 as well, not only in 12.3, so I've backported the fix. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820454 https://bugzilla.novell.com/show_bug.cgi?id=820454#c10 Benjamin Brunner <bbrunner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |REOPENED InfoProvider|maintenance@opensuse.org | --- Comment #10 from Benjamin Brunner <bbrunner@suse.com> 2013-06-13 05:36:19 CEST --- Update started for 12.3 (openSUSE:Maintenance:1776). Thanks for your submission. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820454 https://bugzilla.novell.com/show_bug.cgi?id=820454#c11 Benjamin Brunner <bbrunner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #11 from Benjamin Brunner <bbrunner@suse.com> 2013-06-20 09:09:10 CEST --- Update released for openSUSE 12.3. Resolved fixed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820454 https://bugzilla.novell.com/show_bug.cgi?id=820454#c12 --- Comment #12 from Swamp Workflow Management <swamp@suse.de> 2013-06-20 08:06:19 UTC --- openSUSE-RU-2013:1057-1: An update that has four recommended fixes can now be installed. Category: recommended (moderate) Bug References: 808144,808319,809420,820454 CVE References: Sources used: openSUSE 12.3 (src): systemd-195-13.29.1, systemd-mini-195-13.29.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com