[Bug 858233] New: Patch openSUSE-2013-1034 breaks xfs_growfs
https://bugzilla.novell.com/show_bug.cgi?id=858233 https://bugzilla.novell.com/show_bug.cgi?id=858233#c0 Summary: Patch openSUSE-2013-1034 breaks xfs_growfs Classification: openSUSE Product: openSUSE 12.3 Version: Final Platform: x86-64 OS/Version: openSUSE 12.3 Status: NEW Severity: Normal Priority: P5 - None Component: Kernel AssignedTo: kernel-maintainers@forge.provo.novell.com ReportedBy: koersen@gmail.com QAContact: qa-bugs@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36 Recently I migrated all my filesystems to XFS. This works just fine, but I found I could not grow a filesystem while using kernel 3.7.10-1.24.1-desktop. After downgrading to 3.7.10-1.16-desktop xfs_growfs works. Symtoms while using kernel 3.7.10-1.24.1-desktop: xfs_growfs error message: xfs_growfs: XFS_IOC_FSGROWFSDATA xfsctl failed: Cannot allocate memory Message in system log: Jan 07 12:55:58 linux-zvf1.ka.haagnet.net kernel: XFS (dm-5): _xfs_buf_find: Block out of range: block 0x4000001, EOFS 0x4000000 Reproducible: Always Steps to Reproduce: 1.create a logical volume 2.create an xfs filesystem on the volume 3.enlarge the logical volume 4.run xfs_growfs on the filesystem Actual Results: xfs_growfs: XFS_IOC_FSGROWFSDATA xfsctl failed: Cannot allocate memory error in syslog: Jan 07 12:55:58 linux-zvf1.ka.haagnet.net kernel: XFS (dm-5): _xfs_buf_find: Block out of range: block 0x4000001, EOFS 0x4000000 Expected Results: Enlarged filesystem No errors Works with kernel 3.7.10-1.16-desktop -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c1
Paul Neuwirth
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c2
Urs Beyerle
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c3
Robert Boßecker
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c4
Takashi Iwai
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c5
--- Comment #5 from wouter koersen
Does openSUSE 13.1 work for you instead?
Sorry, I don't have 13.1 yet. If you can't reproduce the error using the steps described in the bug report it seems like it's fixed. The XFS version on 12.3 is: xfs-1.1.2-5.1.1.x86_64 (in rpm -qi). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c6
--- Comment #6 from Robert Boßecker
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c
Robert Boßecker
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c7
--- Comment #7 from Robert Boßecker
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c8
Takashi Iwai
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c9
Urs Beyerle
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c10
--- Comment #10 from Robert Boßecker
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c11
Takashi Iwai
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c12
--- Comment #12 from Marcus Meissner
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c13
Mark Tinguely
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c
Takashi Iwai
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c18
Takashi Iwai
I would not remove the patch!
Revert: xfs: fix _xfs_buf_find oops on blocks beyond the filesystem end
it opens you up to NULL pointer dereferences on huge block numbers.
xfs_growfs() cannot call xfs_buf_find(). In earlier kernels it did via xfs_buf_get(). The commit, fd23683c, in v3.7-rc1-42-gfd23683 changed those to direct reads.
You mean 3.8-rc1, right? If it were 3.7-rc1, it should have been already fixed :) I backported that commit and the previous one to apply cleanly, and revert the revert. The test kernel packages are being built in OBS home:tiwai:bnc858233 repo. Please test whether this fixes the issue. Once when confirmed, I'll push this to git tree. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c19
--- Comment #19 from Mark Tinguely
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c20
--- Comment #20 from Takashi Iwai
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c22
--- Comment #22 from wouter koersen
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c23
Takashi Iwai
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c24
--- Comment #24 from wouter koersen
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c25
--- Comment #25 from Urs Beyerle
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c26
--- Comment #26 from Takashi Iwai
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c27
--- Comment #27 from Urs Beyerle
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c28
--- Comment #28 from Takashi Iwai
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c
Swamp Workflow Management
https://bugzilla.novell.com/show_bug.cgi?id=858233
https://bugzilla.novell.com/show_bug.cgi?id=858233#c29
--- Comment #29 from Swamp Workflow Management
http://bugzilla.novell.com/show_bug.cgi?id=858233
Swamp Workflow Management
participants (1)
-
bugzilla_noreply@novell.com