http://bugzilla.suse.com/show_bug.cgi?id=1116023 http://bugzilla.suse.com/show_bug.cgi?id=1116023#c1 Lee Duncan changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED --- Comment #1 from Lee Duncan --- work has begun -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1116023 Lee Duncan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lduncan@suse.com -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1116023 http://bugzilla.suse.com/show_bug.cgi?id=1116023#c4 --- Comment #4 from Lee Duncan --- (In reply to Franck Bui from comment #3)

If you need help in this task you're welcomed to ask. I will be pleased to help.

I would appreciate that! I am making these changes in the upstream project, first, of course, and that is in progress. I have not submitted this as a pull request yet, but I have pushed my branch on github. See

https://github.com/gonzoleeman/mhvtl

Branch: "use-systemd". If you would like to pull that code and comment, I'd love your input. You can compare it with the "master" branch to see my changes, which were (I believe) in just two commits, one of which was very large. It uses a generator, two regular service files, and two templates! And it seems to work! Once that upstream code is accepted (possibly after changes), I plan on upgrading our Factory package. There _should_ be no function changes (not counting a few small bug fixes). Our SPEC file is a bit different from the package-vanilla version, so it'll take me a couple of days to package and test it, once I get there. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1116023 http://bugzilla.suse.com/show_bug.cgi?id=1116023#c6 Lee Duncan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fbui@suse.com Flags| |needinfo?(fbui@suse.com) --- Comment #6 from Lee Duncan --- (In reply to Franck Bui from comment #5)

(In reply to Lee Duncan from comment #4)

...

...

https://github.com/gonzoleeman/mhvtl

I added few comments, which I hope are relevant (since I've no idea of what mhvtl is :P ).

Thank you for your comments. I made two changes, but I have a question. Should the overall "thing" you turn on or off for mhvtl be called "mhvtl.service" or "mhvtl.target". I'm good either way. I started with ".target", but then running "systemctl enable mhvtl" does not find "mhvtl.target". -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1116023 http://bugzilla.suse.com/show_bug.cgi?id=1116023#c8 --- Comment #8 from Franck Bui --- (In reply to Lee Duncan from comment #6)

I started with ".target", but then running "systemctl enable mhvtl" does not find "mhvtl.target".

I think that if you omit the unit type suffix then systemctl assumes a unit of type "service". So you should try "systemctl enable mhvtl.target". -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1116023 http://bugzilla.suse.com/show_bug.cgi?id=1116023#c10 --- Comment #10 from Franck Bui --- (In reply to Lee Duncan from comment #9)

Let me know if you want to test (again) what I currently have.

I can have a look if you want. Just let me know where I can see the files. Thanks ! -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1116023 http://bugzilla.suse.com/show_bug.cgi?id=1116023#c12 --- Comment #12 from Franck Bui --- Hi Lee, I gave a quick look at Mark's repo and this looks pretty good. I have one question though. Both vtllibrary@.service.in [1] and vtltape@.service.in services have: [Unit] ... Before=multi-user.target [Service] ... [Install] WantedBy=mhvtl.target I'm not sure to understand why it uses "Before=multi-user.target". I would have expected to see "Before=mhvtl.target" instead and only mhvtl.target would have been oredered before "multi-user.target"... Thanks. [1] https://github.com/markh794/mhvtl/blob/master/etc/vtllibrary%40.service.in -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1116023 http://bugzilla.suse.com/show_bug.cgi?id=1116023#c14 Lee Duncan changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #14 from Lee Duncan --- This has been updated in Factory, Tumbleweed, and Leap 15.1, including fixing the comment from @Franck, so marking as resolved. -- You are receiving this mail because: You are on the CC list for the bug.