[Bug 359523] New: New UI builtin - UI::PendingUILayers :)
https://bugzilla.novell.com/show_bug.cgi?id=359523 Summary: New UI builtin - UI::PendingUILayers :) Product: openSUSE 11.0 Version: Alpha 2 Platform: Other OS/Version: Other Status: NEW Severity: Enhancement Priority: P5 - None Component: YaST2 AssignedTo: tgoettlicher@novell.com ReportedBy: locilka@novell.com QAContact: jsrain@novell.com CC: jsrain@novell.com, coolo@novell.com, mvidner@novell.com, visnov@novell.com Found By: --- Although this is an enhancement request, it seems to be critical, and/but quite simple feature :) Bug 359235 reveals, that calling one YaST module under another one (or Progress callbacks, etc.) can break the the driving YaST module UI. Imagine this situation: * Module A opens a WizardWindow (1) * Module A calls module B * Module B opens a new WizardWindow (2) * Module B finishes without closing it (2) * Module A expects WizardWindow (1) active but the active window is (2) instead. I'd like to have a new (?) UI built-in that would return number of pending UI layers. In this case, installation could control (somehow) whether every called module closes dialogs that it opens (or close it itself). This is vitally important and according to yast-developers it should take about two hours :)))) So, I'm trying to request (PLEASE ;)) this without FATE. Thx L. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=359523
User sh@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=359523#c1
Stefan Hundhammer
https://bugzilla.novell.com/show_bug.cgi?id=359523
User sh@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=359523#c2
Stefan Hundhammer
https://bugzilla.novell.com/show_bug.cgi?id=359523
User locilka@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=359523#c3
--- Comment #3 from Lukas Ocilka
https://bugzilla.novell.com/show_bug.cgi?id=359523
User sh@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=359523#c4
--- Comment #4 from Stefan Hundhammer
I still consider this a valid enhancement request. I've already tried to implement such feature that kept closing dialogs unless the main dialog was found however this didn't work because you never know how many layers are active below the current one. You can easily close the last one.
Besides my remarks from above that this is utterly evil, this is just as easy as the code suggested above in comment #1: Give your dialog a specific widget ID somewhere and close dialogs until there is a dialog with that ID. This one is yours. BUT it's still evil:
Your suggestion works for known cases only (e.g., we know that packager sometimes leaves another dialog layer open) it doesn't work for unknown dialogs left (DSL? Firewall? whatever).
How can there be such a dialog left open and you are back in your code? That's a bug in that other code. If you call another YCP module, that other module is required to clean up whatever it did. This rule is so basic in software development that I really find it amazing that we have to discuss this.
Additionally modules can always not only open a new dialog layer but also change the current dialog content (the very same dialog layer).
Well, yes: That's why it must be clear whose responsibility it is to restore the old status, no matter if that means closing windows that have been opened or restoring wizard content that was changed. If that doesn't work, we have severe problems. They should be fixed where they occur, not worked around by some generic clean-up code that does something by heuristics. That would be broken by design. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=359523
User mvidner@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=359523#c5
--- Comment #5 from Martin Vidner
https://bugzilla.novell.com/show_bug.cgi?id=359523
User locilka@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=359523#c6
--- Comment #6 from Lukas Ocilka
participants (1)
-
bugzilla_noreply@novell.com