[Bug 743202] New: /usr/lib/obs/service/download_files prevents 'osc build' before upload
https://bugzilla.novell.com/show_bug.cgi?id=743202 https://bugzilla.novell.com/show_bug.cgi?id=743202#c0 Summary: /usr/lib/obs/service/download_files prevents 'osc build' before upload Classification: Internal Novell Products Product: openSUSE Build Service Version: 2.3 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: osc AssignedTo: adrian@suse.com ReportedBy: jw@suse.com QAContact: adrian@suse.com Found By: --- Blocker: --- I am upstream of package perl-File-Unpack, and try to prepare a new version 0.49 of the package. I have been using 'osc build' to test my packages before I upload to cpan. This is no longer possible. osc build now fails with the following error message: Run source service: /usr/lib/obs/service/download_files --outdir /tmp/tmpNno9Xl ERROR: Fail to download http://search.cpan.org/CPAN/authors/id/J/JN/JNW/File-Unpack-0.49.tar.gz This cannot work, because the whole point of a build test is to catch a faulty release *before* uploading. The new 'service' spoils this use case. This is with obs-service-download_files-0.1-5.1.1.noarch The 'service' should print a warning only and continue, when building locally. The 'service' should print a warning only and continue, when building for my home project. Workaround: always use osc build --noservice osc ci --skip-local-service-run (Also note how these options are inconsistent) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=743202 https://bugzilla.novell.com/show_bug.cgi?id=743202#c1 Adrian Schröter <adrian@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID --- Comment #1 from Adrian Schröter <adrian@suse.com> 2012-01-25 11:05:44 UTC --- The point of them is to validate that you are using official tar balls. So, just do not use full URLs for temporary builds and add them again when you have released the tar ball. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=743202 https://bugzilla.novell.com/show_bug.cgi?id=743202#c Juergen Weigert <jw@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |743547 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=743202 https://bugzilla.novell.com/show_bug.cgi?id=743202#c2 Juergen Weigert <jw@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |coolo@suse.com Resolution|INVALID | Severity|Normal |Major --- Comment #2 from Juergen Weigert <jw@suse.com> 2012-01-29 21:05:34 UTC --- This is more serious, than I though: If the upstream tarball exists, and I am correcting a minor documentation typo, the typo is silently reintroduced by the /usr/lib/obs/service/download_files service. The tarball in my local build directory gets replaced by older tarball The only hint is this line in the build log: Run source service: /usr/lib/obs/service/download_files --outdir /tmp/tmpUTLw5Z File-Unpack-0.51.tar.gz /home/testy/src/obs/home:jnweiger:branches:devel:languages:perl/perl-File-Unpack/File-Unpack-0.51.tar.gz differ: byte 1, line 1 .. which just confirms that I am introducing a change. Exactly what I intended. But in reality, the following happens - The tar ball no longer differs. - My changes are tossed away (with possibly surprising build results) - No backup was made, I have to recreate my work.
From the above I see several reasons to reopen and raise to Major issue.
In addition, once the packager learns that the system is fighting against his updates, the documented counter measures do not work: osc build --noservice --local-package Still runs the service and changes the tarball back. The only possible workaround appears to be osc build --offline Temporarily changing the full URLs is not an option for me. It adds a second build cycle after the upload reaches the cpan mirrors. The timing of this is unpredictable. The chances of neglecting (or simply forgetting) the second rebuild for just an URL repair are very high. Thus the service cannot fulfill its purpose. I am not having fun submitting my packages now. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=743202 https://bugzilla.novell.com/show_bug.cgi?id=743202#c3 Juergen Weigert <jw@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspiers@suse.com --- Comment #3 from Juergen Weigert <jw@suse.com> 2012-02-08 15:10:59 UTC --- adding Adam for reference, as we just discussed this briefly. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=743202 https://bugzilla.novell.com/show_bug.cgi?id=743202#c4 Adrian Schröter <adrian@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|adrian@suse.com |jw@suse.com --- Comment #4 from Adrian Schröter <adrian@suse.com> 2013-03-04 10:19:05 UTC --- Which changes are tossed away? Something in the tar ball? Changes in spec file or changes should not be affected. I can not test it atm myself, because the upstream project seems to have removed the tar ball, only an older release exists upstream atm. Actually, this is exactly the case where we wanted to have this check failing, notifing us that upstream is doing interessting stuff which needs to be sorted out. Maybe the 0.58 release was broken or hacked and we should revert as well? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=743202 https://bugzilla.novell.com/show_bug.cgi?id=743202#c5 --- Comment #5 from Juergen Weigert <jw@suse.com> 2013-10-13 20:26:46 UTC --- changes in the tar ball of coourse. The service blindly pull the upstream tar ball and overwrites the one I provided There should be a prominent warning, if this happens by design. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=743202 https://bugzilla.novell.com/show_bug.cgi?id=743202#c6 Adrian Schröter <adrian@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |INVALID --- Comment #6 from Adrian Schröter <adrian@suse.com> 2013-10-14 12:59:46 UTC --- sorry, but if you configure download_files that way it is the purpose of it to do exactly this. you can also configure it to run only manually or only on server or just fail if it does now match. But if you do not want to compare or update the sources, just do not use it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com