http://bugzilla.opensuse.org/show_bug.cgi?id=925961 Dieter Jurzitza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |WORKSFORME Flags|needinfo?(dieter.jurzitza@t | |-online.de) | --- Comment #20 from Dieter Jurzitza --- Your assumptions were totally right - I removed the three lines (took my 5 minutes plus 2 days compile time :-)) and acerhdf is functional again. Could not observe any side effects so far, acerhdf does now what it is and was expected to do. So I add two patches, one for the three lines you readily mentioned and one for series.conf - I've been putting the patch into patches.suse.tar.bz2, you'll probably find a better place for this. Nevertheless, many thanks for your support - and if there is a kernel update currently pending it would be great if this could find it's way into ... Have a good start into the new week, take care Dieter Jurzitza -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=925961 --- Comment #22 from Dieter Jurzitza --- Created attachment 631535 --> http://bugzilla.opensuse.org/attachment.cgi?id=631535&action=edit This is needed to make acerhdf behave again as used to, before. This modification as suggested by Jeadn Delvare reverts the behaviour of the kernel so acerhdf does what it is excpected to, again. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=925961 Jean Delvare changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |FIXED --- Comment #24 from Jean Delvare --- Fix committed to the openSUSE 13.2 kernel branch, so the next maintenance update will include it. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=925961 --- Comment #25 from Rui Zhang --- hmmm, I think I'm trying to fix the bug in another way, please refer to patches at https://patchwork.kernel.org/patch/6166681/ https://patchwork.kernel.org/patch/6166691/ https://patchwork.kernel.org/patch/6166701/ with these three patches, it should work even with step_wise governor, and I'd like to push these patches to 4.1 and 3.18 - 4.0 stable kernel. about commit 178c2490b99f898efc06d1ad75cadc84f13021a6, are you going to revert it in suse kernel, or upstream stable kernel? -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=925961 --- Comment #27 from Rui Zhang --- (In reply to Jean Delvare from comment #26)

Rui, thanks for looking into this.

I am not familiar enough with the thermal subsystem to review your patches. Also I don't own an Acer laptop myself so I can't test if they would solve the problem that was reported here. But I have to say I have some doubts that they would actually help. My understanding of the problem is that the acerhdf wanted to be called back even when the step_wise governor considered that no change in cooling was needed, and the optimization broke that mechanism/assumption.

If you believe that the problem would actually be solved by your patches, please explain how, as it isn't obvious to me. This is mostly theoretical though, as I don't think that your 3 patches qualify for stable kernels. They are large and somewhat intrusive, so they could come with regressions or side effects. I wouldn't take the risk of applying them to the openSUSE 13.2 kernel. Reverting the optimization as I did feels much safer.

I did send a patch reverting 178c2490b99f898efc06d1ad75cadc84f13021a6 to the stable kernel mailing list, with suggestion to apply it to kernel branches v3.12 to v3.17. You were Cc'd.

Yes, IMO, the patch should be applied to all stable kernel as it is actually a bug in step_wise governor. and I will rework the three patches above on top of the fix then. can you please resend with cc: all stable kernel? -- You are receiving this mail because: You are on the CC list for the bug.