[Bug 390752] New: MozillaFirefox doesn't follow the branding policy
https://bugzilla.novell.com/show_bug.cgi?id=390752 Summary: MozillaFirefox doesn't follow the branding policy Product: openSUSE 11.0 Version: Factory Platform: All URL: http://en.opensuse.org/SUSE_Package_Conventions/Branding OS/Version: openSUSE 11.0 Status: NEW Severity: Normal Priority: P5 - None Component: Firefox AssignedTo: maw@novell.com ReportedBy: lrupp@novell.com QAContact: qa@suse.de CC: aj@novell.com, wolfgang@rosenauer.org Found By: --- As long as the MozillaFirefox package comes with customized bookmarks, default-prefs.js (and perhaps also an disabled update function), it should follow the new branding guidelines described here: http://en.opensuse.org/SUSE_Package_Conventions/Branding -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=390752 User wolfgang@rosenauer.org added comment https://bugzilla.novell.com/show_bug.cgi?id=390752#c1 --- Comment #1 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2008-05-15 07:09:11 MST --- Are bookmarks and default prefs the only "branding" related things you have in mind? (update function is a bit different IMHO) Should we ship an "upstream" branding package in addition to an openSUSE (and later SLE) one? Who makes sure that every branding package complies with Mozilla's trademark policies? The name of the package itself is "branding" in the sense of their trademark policy. We are not talking about 11.0 timeframe, do we? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=390752 User lrupp@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=390752#c2 Lars Vogdt <lrupp@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lrupp@novell.com, coolo@novell.com --- Comment #2 from Lars Vogdt <lrupp@novell.com> 2008-05-15 07:18:56 MST --- (In reply to comment #1 from Wolfgang Rosenauer)
Are bookmarks and default prefs the only "branding" related things you have in mind?
I haven't looked deeper into this - just looked at the latest changelog entry from AJ. Don't know if the firefox.schemas should also be placed in the branding package - but the bookmarks and default prefs in any case.
(update function is a bit different IMHO)
Yes, sorry. I'm fine with leaving it out.
Should we ship an "upstream" branding package in addition to an openSUSE (and later SLE) one?
Yes.
Who makes sure that every branding package complies with Mozilla's trademark policies?
The packager? ;-) The "upstream" branding should already comply - even so the openSUSE one, as this is the default for openSUSE. If we add further branding packages for SLE, they should be checked by the legal department.
The name of the package itself is "branding" in the sense of their trademark policy.
You mean: MozillaFirefox-branding-openSUSE MozillaFirefox-branding-upstream ?
We are not talking about 11.0 timeframe, do we?
Adding coolo to CC for this question. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=390752 User lrupp@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=390752#c3 --- Comment #3 from Lars Vogdt <lrupp@novell.com> 2008-05-15 07:21:28 MST --- BTW: MozillaThunderbird contains also a suse-default-prefs.js - should I open a new bug for this? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=390752 User coolo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=390752#c4 --- Comment #4 from Stephan Kulow <coolo@novell.com> 2008-05-15 07:25:37 MST --- branding policy is not a very strict policy for 11.0, no. It will be one for 11.1 though -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=390752 User wolfgang@rosenauer.org added comment https://bugzilla.novell.com/show_bug.cgi?id=390752#c5 --- Comment #5 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2008-05-15 07:58:05 MST --- Ok, just for the record: Not everything what probably should be branded can easily be branded since it hides (and must hide) in patches. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=390752 Michael Wolf <maw@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maw@novell.com Severity|Normal |Enhancement Component|Firefox |Firefox Priority|P5 - None |P2 - High Product|openSUSE 11.0 |openSUSE 11.1 Target Milestone|--- |Alpha 0 for Fix| | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=390752 User wolfgang@rosenauer.org added comment https://bugzilla.novell.com/show_bug.cgi?id=390752#c6 --- Comment #6 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2008-07-26 03:36:30 MDT --- (In reply to comment #2 from Lars Vogdt)
The name of the package itself is "branding" in the sense of their trademark policy.
You mean: MozillaFirefox-branding-openSUSE MozillaFirefox-branding-upstream ?
No, the package name Firefox and the used logos (in the browser) are trademarked branding. So all branding packages must be assured to comply with Mozilla's trademark policies since otherwise the package looses its permission and wouldn't be allowed to ship. Michael, what are your plans on that? I could probably look at that. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=390752 User vuntz@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=390752#c7 Vincent Untz <vuntz@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vuntz@novell.com --- Comment #7 from Vincent Untz <vuntz@novell.com> 2008-07-29 09:33:42 MDT --- I tried to implement the branding policy. You can find the packages here: MozillaFirefox & MozillaFirefox-branding-upstream: https://build.opensuse.org/package/show?package=MozillaFirefox&project=home%3Avuntz%3Abranches%3AGNOME%3AFactory MozillaFirefox-branding-openSUSE: https://build.opensuse.org/package/show?package=MozillaFirefox-branding-openSUSE&project=home%3Avuntz%3Afactory-playground FWIW, what's in MozillaFirefox-branding-openSUSE is: %{progdir}/defaults/preferences/firefox-openSUSE.js %{progdir}/defaults/profile/bookmarks.html %{progdir}/browserconfig.properties %{progdir}/searchplugins/* What's in MozillaFirefox-branding-upstream: %{progdir}/browserconfig.properties %{progdir}/defaults/profile/bookmarks.html I didn't test the packages, but the main issue I can see right now is that moving firefox-openSUSE.js to MozillaFirefox-branding-openSUSE might break stuff when it comes to the vendor version (we'll have 11.1-1 instead of 3.0-11, eg) -- note that we might also want to change the vendor from SUSE to openSUSE. (I also didn't change anything in PDB) Can people look at this? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=390752 User wolfgang@rosenauer.org added comment https://bugzilla.novell.com/show_bug.cgi?id=390752#c8 --- Comment #8 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2008-07-29 14:50:31 MDT --- Thanks for looking into it. (In reply to comment #7 from Vincent Untz)
I didn't test the packages, but the main issue I can see right now is that
I will roll that (or at least parts of it) into the mozilla:beta repository tomorrow or so for testing.
moving firefox-openSUSE.js to MozillaFirefox-branding-openSUSE might break stuff when it comes to the vendor version (we'll have 11.1-1 instead of 3.0-11, eg) -- note that we might also want to change the vendor from SUSE to openSUSE.
I liked the shorter "SUSE" name. The UA string is already long enough but if needed that could be changed to openSUSE. (Keep in mind that SUSE has been used for a long time now and third parties may rely on that keyword. It shouldn't be changed just for fun but only if it's a strong requirement. BUT: This vendor name and versioning shouldn't go the any branding package IMHO. It is branding basically but it is an identifier most interesting for the overall flavour of Firefox (build environment, patches etc.) and not only for the look and feel "branding". Applying the upstream branding doesn't mean that the build isn't done by "SUSE" (or "openSUSE"). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=390752 User vuntz@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=390752#c9 --- Comment #9 from Vincent Untz <vuntz@novell.com> 2008-07-29 16:15:16 MDT --- Wolfgang: yeah, makes sense (for firefox-openSUSE.js). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=390752 User wolfgang@rosenauer.org added comment https://bugzilla.novell.com/show_bug.cgi?id=390752#c10 Wolfgang Rosenauer <wolfgang@rosenauer.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #10 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2008-08-23 03:15:06 MDT --- New MozillaFirefox package already in Factory. MozillaFirefox-branding-openSUSE still sitting somewhere waiting for something. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com