[Bug 679459] New: mtools/mcopy (FAT32) access invalid memory
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c0 Summary: mtools/mcopy (FAT32) access invalid memory Classification: openSUSE Product: openSUSE 11.4 Version: Final Platform: All OS/Version: SuSE Other Status: NEW Severity: Major Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: bwiedemann@novell.com QAContact: qa@suse.de CC: snwint@novell.com, pgajdos@novell.com Found By: Development Blocker: --- mcopy as called by syslinux fails because it accesses invalid memory when operating on FAT32 Steps To Reproduce: dd if=/dev/zero of=/tmp/test bs=1M count=50 mkdosfs -F 32 /tmp/test syslinux /tmp/test strace -f shows that this calls execve("/usr/bin/mcopy", ["mcopy", "-D", "o", "-D", "O", "-o", "-", "s:/ldlinux.sys"], [/* 59 vars */]) = 0 Actual Results: *** glibc detected *** mcopy: free(): invalid pointer: 0x000000000063ea20 *** ======= Backtrace: ========= /lib64/libc.so.6(+0x733b6)[0x7f4e12c713b6] mcopy[0x408745] .. 7fff1eb1f000-7fff1eb42000 rw-p 00000000 00:00 0 [stack] 7fff1ebff000-7fff1ec00000 r-xp 00000000 00:00 0 [vdso] ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0 [vsyscall] syslinux: failed to create ldlinux.sys Expected Results: should work as it does for FAT16 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c1 Bernhard Wiedemann <bwiedemann@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Other |Other Version|Final |Factory Product|openSUSE 11.4 |openSUSE 11.5 --- Comment #1 from Bernhard Wiedemann <bwiedemann@novell.com> 2011-03-14 23:00:24 CET --- Closer inspection showed this working for 11.4-GM but broken for Factory. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c zj jia <zjjia@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zjjia@novell.com AssignedTo|bnc-team-screening@forge.pr |pgajdos@novell.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c2 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |NEEDINFO InfoProvider| |bwiedemann@novell.com --- Comment #2 from Petr Gajdos <pgajdos@novell.com> 2011-03-15 14:03:53 UTC --- I cannot reproduce it. Could you please provide rpm -q dosfstools mtools syslinux output? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c3 Bernhard Wiedemann <bwiedemann@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|bwiedemann@novell.com | --- Comment #3 from Bernhard Wiedemann <bwiedemann@novell.com> 2011-03-15 15:14:36 CET --- dosfstools-3.0.10-10.2.x86_64 mtools-4.0.15-6.1.x86_64 syslinux-3.86-9.1.x86_64 glibc-2.11.3-15.2.x86_64 kernel-desktop-2.6.38-2.1.x86_64 (rc7) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c4 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Petr Gajdos <pgajdos@novell.com> 2011-03-15 16:15:05 UTC --- Ok, I see the crash as well, I will look into it soon. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c5 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |bwiedemann@novell.com --- Comment #5 from Petr Gajdos <pgajdos@novell.com> 2011-03-17 10:30:27 UTC --- Could you please test newly built packages from Base:System? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c6 --- Comment #6 from Petr Gajdos <pgajdos@novell.com> 2011-03-17 16:32:18 UTC --- For your convenience http://download.opensuse.org/repositories/Base:/System/openSUSE_Factory/x86_... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c7 Bernhard Wiedemann <bwiedemann@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|bwiedemann@novell.com | --- Comment #7 from Bernhard Wiedemann <bwiedemann@novell.com> 2011-03-18 13:16:53 CET --- found it working with Base:System made this script to include in my automated tests: http://openqa.opensuse.org/opensuse/qatests/qa_syslinux.sh -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c8 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |maint-coord@suse.de --- Comment #8 from Petr Gajdos <pgajdos@novell.com> 2011-03-21 07:48:40 UTC --- Thanks Bernhard. Will we do an update? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c9 --- Comment #9 from Bernhard Wiedemann <bwiedemann@novell.com> 2011-03-21 09:35:37 CET --- Petr, does the bug occur on 11.4 for you? As I wrote in comment 1, I only saw it on Factory. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c10 --- Comment #10 from Petr Gajdos <pgajdos@novell.com> 2011-03-21 09:09:46 UTC --- I didn't test and I actually don't know why that bug hadn't arosen till now. But the dangerous code is in all versions we support as far as I can tell. infoSector->signature3 is unsigned char [2] (compare with ->signature1 and ->signature2), but set is with set_dword() -- like ->signature1 and ->signature2 are. Look at set_word() and set_dword() definitions in msdos.h for details. I propose following patch: Index: mtools-4.0.15/fat.c =================================================================== --- mtools-4.0.15.orig/fat.c +++ mtools-4.0.15/fat.c @@ -468,7 +468,7 @@ void fat_write(Fs_t *This) set_dword(infoSector->signature2, INFOSECT_SIGNATURE2); set_dword(infoSector->pos, This->last); set_dword(infoSector->count, This->freeSpace); - set_dword(infoSector->signature3, 0xaa55); + set_word(infoSector->signature3, 0xaa55); if(forceWriteSector(This, (char *)infoSector, This->infoSectorLoc, 1) != (signed int) This->sector_size) fprintf(stderr,"Trouble writing the info sector\n"); -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |maint:planned:update -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c12 Christian Dengler <cdengler@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- InfoProvider|maint-coord@suse.de |maintenance@opensuse.org --- Comment #12 from Christian Dengler <cdengler@novell.com> 2011-03-22 13:59:44 UTC --- For openSUSE handling over to openSUSE maintenance ;-) +1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|maintenance@opensuse.org | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |maintenance@opensuse.org -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c13 --- Comment #13 from Petr Gajdos <pgajdos@novell.com> 2011-03-22 16:11:13 UTC --- Factory: sr#64870 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c14 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |meissner@novell.com --- Comment #14 from Marcus Meissner <meissner@novell.com> 2011-03-24 08:03:18 UTC --- should get updated +1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c15 --- Comment #15 from Petr Gajdos <pgajdos@novell.com> 2011-03-24 08:09:53 UTC --- 11.4: sr#65067 11.3: sr#65068 11.2: sr#65069 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c16 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:planned:update |maint:running:39678:low --- Comment #16 from Swamp Workflow Management <swamp@suse.com> 2011-03-25 13:59:28 UTC --- The SWAMPID for this issue is 39678. This issue was rated as low. Please submit fixed packages until 2011-04-22. Also create a patchinfo file using this link: https://swamp.suse.de/webswamp/wf/39678 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c17 Christian Dengler <cdengler@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|maintenance@opensuse.org | --- Comment #17 from Christian Dengler <cdengler@novell.com> 2011-03-25 13:59:44 UTC --- update started. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 - Medium |P4 - Low -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c18 Christian Dengler <cdengler@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #18 from Christian Dengler <cdengler@novell.com> 2011-04-08 15:28:29 UTC --- patchinfo provided. Update should be available shortly in the update-test repo for testing. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c19 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:39678:low |maint:running:39678:low | |maint:released:11.4:40076 --- Comment #19 from Swamp Workflow Management <swamp@suse.com> 2011-04-13 17:50:56 UTC --- Update released for: mtools, mtools-debuginfo, mtools-debugsource, mtools-doc, mtools-floppyd, mtools-floppyd-debuginfo Products: openSUSE 11.4 (debug, i586, x86_64) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:39678:low |maint:released:11.4:40076 |maint:released:11.4:40076 | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=679459 https://bugzilla.novell.com/show_bug.cgi?id=679459#c SMASH SMASH <smash_bz@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:released:11.4:40076 |maint:released:11.4:40076 | |maint:planned:update -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com