[Bug 279866] New: No QA for patch descriptions
https://bugzilla.novell.com/show_bug.cgi?id=279866 Summary: No QA for patch descriptions Product: openSUSE 10.2 Version: Final Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: Maintenance AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: suse-beta@cboltz.de QAContact: qa@suse.de Perhaps you remember bug 188011 where I reported a broken patch description. Today you released a new patch with the useless description This update fixes the patch of the last security-update. There were more not-so-good patch descriptions in the last months, but this is the worst one ever. Missing information: - What package? - What was fixed? I propose to do QA not only on the packages, but also on the patch description. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=279866 ------- Comment #1 from suse-beta@cboltz.de 2007-06-01 02:33 MST ------- Created an attachment (id=143449) --> (https://bugzilla.novell.com/attachment.cgi?id=143449&action=view) screenshot -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=279866 thomas@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX ------- Comment #2 from thomas@novell.com 2007-06-01 05:21 MST ------- Indeed this is bad but it is a missing feature in the GUI of the updater. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=279866 thomas@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX | ------- Comment #3 from thomas@novell.com 2007-06-01 05:31 MST ------- reopen and reassign it -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=279866 thomas@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |jsuchome@novell.com |screening@forge.provo.novell| |.com | Status|REOPENED |NEW ------- Comment #4 from thomas@novell.com 2007-06-01 05:32 MST ------- I guess it is the GUI of yast2-online-update-frontend... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=279866 thomas@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |security-team@suse.de Severity|Major |Normal -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=279866 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jsuchome@novell.com |dmacvicar@novell.com ------- Comment #5 from jsuchome@novell.com 2007-06-01 05:49 MST ------- No it is not, it's opensuse-updater -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=279866 suse-beta@cboltz.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aj@novell.com ------- Comment #6 from suse-beta@cboltz.de 2007-06-02 12:43 MST ------- (In reply to comment #5)
No it is not, it's opensuse-updater
Yes and no. Yes, the screenshot shows opensuse-updater. No, it isn't a bug in opensuse-updater and/or YaST. The patch itsself comes with this useless title: ftp://ftp.suse.com/pub/suse/update/10.2/repodata/patch-ImageMagick-3448.xml <summary lang="en">This update fixes the patch of the last security-update.</summary> <summary lang="de">Update von ImageMagick.</summary> (As you can see, the german title is a bit better because it contains at least the package name. However, it doesn't explain _what_ was changed. And it completely misses the content of the english title...) Again: The _patch description_ is buggy - not in a technical sence of course, but it's completely useless as is. Since this isn't the first time this happened (see bug 188011 for an example), I titled this bug "No QA for patch descriptions" instead of "description of patch xy useless". And I mean it exactly that way - the QA for the patch description obviously doesn't exist :-( -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=279866 ------- Comment #7 from thomas@novell.com 2007-06-04 00:40 MST ------- The patch description says: <description lang="en">This update of ImageMagick fixes a bug in the patch for the last security update for CVE-2007-1797. </description> What do you mean by "buggy"? The text you cited is just the summary. I see no bug, typo, whatever here. If you need more information use another frontend (i.e. the ZenUpdater). P.S.: We have a proofread action item in our update process. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=279866 ------- Comment #8 from suse-beta@cboltz.de 2007-06-04 11:24 MST ------- (In reply to comment #7)
The patch description says: <description lang="en">This update of ImageMagick fixes a bug in the patch for the last security update for CVE-2007-1797. </description>
What do you mean by "buggy"?
As I wrote: the summary is nearly useless.
The text you cited is just the summary.
And it is all that opensuse-updater shows.
I see no bug, typo, whatever here. If you need more information use another frontend (i.e. the ZenUpdater).
I'm afraid you miss the point. The _summary_ should contain the most important information - that's why it is called summary ;-) . And IMHO it is important _what_ (which package) was fixed. The description is a bit hidden: - YaST shows it for the selected patch, so you have to click each patch to see it for all available patches. - opensuse-updater doesn't show the summary anywhere - in zen-updater, you need to click on "details" IIRC (besides the fact that is is gone in 10.3 and many people don't use it on 10.1/10.2) Of course the long description contains all the details, but the summary is what people see first. Real-world question: Imagine a newspaper that states "something happened" in big letters on the title page, with another headline "it happened!", hiding the event somewhere in the text, and of course without photos. Would you buy this newspaper and/or read these articles?
P.S.: We have a proofread action item in our update process.
Then please add the following to your checklist: - "the summary should contain the package title" - "the summary should give a short overview about what was changed" - "german and english text should have the same meaning" -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=279866 tschmidt@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tschmidt@novell.com ------- Comment #9 from tschmidt@novell.com 2007-06-04 13:48 MST ------- I can add these guidelines to the patchinfo creation and proofread steps in swamp. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=279866 thomas@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|No QA for patch descriptions|opensuse-updater lacks good patch description ------- Comment #10 from thomas@novell.com 2007-06-05 01:01 MST ------- This becomes surreal, there is not reason to adapt a working and sane update process to a feature-lacking update tool. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=279866 hmuelle@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Comment #17 from hmuelle@novell.com 2007-06-06 04:27 MST ------- We should go with a definition like: SUMMARY: <main packagename>: Bugfix description I say "like" cause for more complex issues there might be more than one main packages. I have good idea how to put this into a definition. If it is complex update containing serveral main packages, the summary could get really long - e.g. (not check exact package names): SUMMARY: apache, openssl, perl, php, ruby: Fixing several issue related to cross site scripting Any comments/ideas: SUMMARY: <pac1>, <pac2>, <pac3>, ..., <pacn>: bugfix description There might be a few execptions like kernel, which normally gets many bugfixes in one update. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=279866#c18 Harald Mueller-Ney <hmuelle@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |meissner@novell.com --- Comment #18 from Harald Mueller-Ney <hmuelle@novell.com> 2007-07-04 05:37:05 MST --- It ssems are all fine with this proposal. Marcus, any comments? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866#c19 Harald Mueller-Ney <hmuelle@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gp@novell.com --- Comment #19 from Harald Mueller-Ney <hmuelle@novell.com> 2007-07-06 02:02:50 MST --- *** Bug 271686 has been marked as a duplicate of this bug. *** https://bugzilla.novell.com/show_bug.cgi?id=271686 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866#c20 Harald Mueller-Ney <hmuelle@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Normal |Major Info Provider|meissner@novell.com |gp@novell.com --- Comment #20 from Harald Mueller-Ney <hmuelle@novell.com> 2007-07-06 02:05:29 MST --- Increasing to major to match the duplicate. Gerald, any feedback to proposal in comment #17? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866#c21 Gerald Pfeifer <gp@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|gp@novell.com | --- Comment #21 from Gerald Pfeifer <gp@novell.com> 2007-07-06 04:36:34 MST --- Yes, this is exactly what I had in mind! We also should enforce this technically if possibly, as to avoid deviations (and add a warning if the description becomes so long as to probably being cut off in the UI). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866#c22 --- Comment #22 from Christian Boltz <suse-beta@cboltz.de> 2007-08-14 14:29:08 MST --- It seems the policy isn't in place yet... Today there's a new patch "Fixed CVE-2007-4091". Am I expected to google for the CVE number to find out which package will be updated? ;-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866#c23 Harald Mueller-Ney <hmuelle@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|hmuelle@novell.com |ro@novell.com Status|ASSIGNED |NEW --- Comment #23 from Harald Mueller-Ney <hmuelle@novell.com> 2007-08-15 02:05:25 MST --- Can we add a check to "check_patchinfo" to show a warning/error for the summary and indications field? SUMMARY: <pac1>, <pac2>, <pac3>, ..., <pacn>: <brief bugfix description> Where pac1 to pacN is the list of "master" packages. <brief bugfix description> is a freetext. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866#c27 --- Comment #27 from Thomas Schmidt <tschmidt@novell.com> 2007-08-28 12:47:10 MST --- The opensuseupdater-kde from beta2 shows the package name as an extra column. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866#c28 Ruediger Oertel <ro@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|ro@novell.com |jkress@novell.com --- Comment #28 from Ruediger Oertel <ro@novell.com> 2007-09-03 09:31:32 MST --- this sounds like the way to go. Joerg: can the same be done for opensuse-updater-gnome (or has this even been done already ?) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866#c29 Jörg Kreß <jkress@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tgoettlicher@novell.com --- Comment #29 from Jörg Kreß <jkress@novell.com> 2007-09-03 09:53:21 MST --- opensuse-updater-gnome doesn't have the same detailed view, as the changes to the backend broke the old code base that much that it couldn't be fixed for 10.3 in time. The Details button calls YaST in the GNOME version. The simple view doesn't show any detailed information (which was the goal). The detailed view of updater-kde essentially shows the information that zypper (more precisely: zypp-checkpatches) provides us. @Thomas Goettlicher: Do you agree here? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866#c30 --- Comment #30 from Thomas Göttlicher <tgoettlicher@novell.com> 2007-09-04 01:07:45 MST --- Jörg, you are right. opensuseupdater-kde's detail view shows the information that is provided by zypp-checkpatches-wrapper. And zypp-checkpatches-wrapper calls zypper. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866#c31 Jörg Kreß <jkress@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |LATER --- Comment #31 from Jörg Kreß <jkress@novell.com> 2007-09-04 01:38:18 MST --- After a little 1:1 discussion with Thomas, I change this to LATER as and keep it assigned to me as a reminder. REASONS: * There was no time to get a working version of the detailed view of opensuse-updater-gnome ready for 10.3. * As this is solely about what information is presented where AFAI understand, it can surely be done and will be done in the future. Everything discussed here will be considered for the rewrite of the gnome updater for 10.3+. * But: the start of this bug is about wrong information in the wrong fields as we understand it. If the information about the patch is not correct we can't really do anything about it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866 User lnussel@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=279866#c32 Ludwig Nussel <lnussel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|LATER | --- Comment #32 from Ludwig Nussel <lnussel@novell.com> 2008-03-06 08:20:13 MST --- Joeg has left the building. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866 Ludwig Nussel <lnussel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jkress@novell.com |dmacvicar@novell.com Status|REOPENED |NEW -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866 User ast@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=279866#c33 Anja Stock <ast@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ast@novell.com | AssignedTo|dmacvicar@novell.com |bnc-team-gnome@forge.provo.novell.com --- Comment #33 from Anja Stock <ast@novell.com> 2008-04-01 04:14:45 MST --- Who is in charge for this package now? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866 User jpr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=279866#c34 JP Rosevear <jpr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-gnome@forge.provo.novell.com |dmacvicar@novell.com --- Comment #34 from JP Rosevear <jpr@novell.com> 2008-04-02 17:56:05 MST --- Duncan's team. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866 User dmacvicar@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=279866#c35 Duncan Mac-Vicar <dmacvicar@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #35 from Duncan Mac-Vicar <dmacvicar@novell.com> 2008-07-07 06:53:19 MDT --- gnome uses packagekit which also provides descriptions. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=279866 User suse-beta@cboltz.de added comment https://bugzilla.novell.com/show_bug.cgi?id=279866#c36 Christian Boltz <suse-beta@cboltz.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED --- Comment #36 from Christian Boltz <suse-beta@cboltz.de> 2008-08-10 14:18:57 MDT --- Checking / proofreading of patch infos seems to work - the patch summaries usually are descriptive in the last months. -> VERIFIED - and thanks for writing better patch descriptions ;-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com