[Bug 1188741] New: [Staging] snappy 1.1.9 breaks build of ceph
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 Bug ID: 1188741 Summary: [Staging] snappy 1.1.9 breaks build of ceph Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Other Assignee: screening-team-bugs@suse.de Reporter: dimstar@opensuse.org QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Snappy 1.1.9 has been submitted for inclusion into Tumbleweed https://build.opensuse.org/request/show/907347 In the staging project, we have identified ceph no longer building with this updated snappy version [ 1362s] [ 39%] Building CXX object src/rgw/CMakeFiles/rgw_common.dir/rgw_formats.cc.o [ 1365s] In file included from /home/abuild/rpmbuild/BUILD/ceph-16.2.5-29-g97c2c82c2f5/src/compressor/snappy/CompressionPluginSnappy.h:20, [ 1365s] from /home/abuild/rpmbuild/BUILD/ceph-16.2.5-29-g97c2c82c2f5/src/compressor/snappy/CompressionPluginSnappy.cc:20: [ 1365s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-29-g97c2c82c2f5/src/compressor/snappy/SnappyCompressor.h: In member function 'virtual int SnappyCompressor::decompress(ceph::buffer::v15_2_0::list::const_iterator&, size_t, ceph::bufferlist&, boost::optional<int>)': [ 1365s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-29-g97c2c82c2f5/src/compressor/snappy/SnappyCompressor.h:100:13: error: 'uint32' is not a member of 'snappy' [ 1365s] 100 | snappy::uint32 res_len = 0; [ 1365s] | ^~~~~~ [ 1365s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-29-g97c2c82c2f5/src/compressor/snappy/SnappyCompressor.h:102:52: error: 'res_len' was not declared in this scope [ 1365s] 102 | if (!snappy::GetUncompressedLength(&source_1, &res_len)) { [ 1365s] | ^~~~~~~ [ 1365s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-29-g97c2c82c2f5/src/compressor/snappy/SnappyCompressor.h:106:25: error: 'res_len' was not declared in this scope [ 1365s] 106 | ceph::bufferptr ptr(res_len); [ 1365s] | ^~~~~~~ [ 1365s] make[2]: *** [src/compressor/snappy/CMakeFiles/ceph_snappy.dir/build.make:76: src/compressor/snappy/CMakeFiles/ceph_snappy.dir/CompressionPluginSnappy.cc.o] Error 1 The responsible change in snappy was identified to be https://github.com/google/snappy/commit/231b8be07655f6d887dde850c85fa3c64eac... Seems like ceph needs to catch up -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 Dominique Leuenberger <dimstar@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddiss@suse.com, | |holgi@suse.com, | |lmb@suse.com, | |mlatimer@suse.com, | |ncutler@suse.com, | |tserong@suse.com Assignee|screening-team-bugs@suse.de |ceph-bugs@suse.de -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c1 Nathan Cutler <ncutler@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS Assignee|ceph-bugs@suse.de |ncutler@suse.com --- Comment #1 from Nathan Cutler <ncutler@suse.com> --- Looks like upstream issue https://tracker.ceph.com/issues/50934 I submitted https://github.com/ceph/ceph/pull/42507 to fix, but it is unlikely to be accepted in this form. At this point, since this patch is needed on TW only and will break the build if applied anywhere else, it looks like I'll need to apply it via the spec file. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c2 Nathan Cutler <ncutler@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dimstar@opensuse.org Flags| |needinfo?(dimstar@opensuse. | |org) --- Comment #2 from Nathan Cutler <ncutler@suse.com> --- @Dominique How could I do a local build against snappy 1.1.9? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c3 Dominique Leuenberger <dimstar@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(dimstar@opensuse. | |org) | --- Comment #3 from Dominique Leuenberger <dimstar@opensuse.org> --- (In reply to Nathan Cutler from comment #2)
@Dominique How could I do a local build against snappy 1.1.9?
osc build --alternative-project openSUSE:Factory:Staging:F -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c4 --- Comment #4 from Nathan Cutler <ncutler@suse.com> --- (In reply to Dominique Leuenberger from comment #3)
(In reply to Nathan Cutler from comment #2)
@Dominique How could I do a local build against snappy 1.1.9?
osc build --alternative-project openSUSE:Factory:Staging:F
Fails with: [ 28s] ERROR: /usr/bin/dracut not found [ 28s] warning: %posttrans(kmod-29-4.1.x86_64) scriptlet failed, exit status 1 [ 28s] ERROR: /usr/bin/dracut not found [ 28s] warning: %posttrans(libhandle1-5.12.0-3.2.x86_64) scriptlet failed, exit status 1 [ 28s] ERROR: /usr/bin/dracut not found [ 28s] warning: %posttrans(udev-mini-248.3-5.1.x86_64) scriptlet failed, exit status 1 [ 28s] ERROR: /usr/bin/dracut not found [ 28s] warning: %posttrans(cryptsetup-2.3.6-4.4.x86_64) scriptlet failed, exit status 1 [ 32s] now finalizing build dir... [ 32s] initializing rpm db... [ 32s] su: cannot open session: Module is unknown [ 32s] Error: TOPDIR empty But that's OK - I will push a submission presently, anyway. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c5 --- Comment #5 from Nathan Cutler <ncutler@suse.com> ---
osc build --alternative-project openSUSE:Factory:Staging:F
Adding --clean got me past the failure. Local build now running. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c6 --- Comment #6 from Nathan Cutler <ncutler@suse.com> ---
Local build now running
[ 481s] virtual memory exhausted: Cannot allocate memory Now trying to figure out why I get this on a machine with 24 GiB of RAM. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c7 --- Comment #7 from Nathan Cutler <ncutler@suse.com> --- [ 481s] cc1plus: out of memory allocating 8168 bytes after a total of 17965056 bytes That looks like 17.5 GB of memory. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c8 --- Comment #8 from Nathan Cutler <ncutler@suse.com> --- [ 481s] cc1plus: out of memory allocating 8168 bytes after a total of 17965056 bytes Sorry, not GB... that looks like 17 MiB of memory?? But I think the reason for the OOM is that the machine can't handle compiling Ceph at -j8: [ 70s] + make -j8 Not sure why the parallelism calculation fails here. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c9 --- Comment #9 from Nathan Cutler <ncutler@suse.com> --- Anyway, it seems to build fine. https://build.opensuse.org/request/show/908673 is the Factory SR. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c10 Nathan Cutler <ncutler@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #10 from Nathan Cutler <ncutler@suse.com> --- Closing under the assumption that the patch works as advertised. I trust Dominique will reopen if there is any issue with it. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c11 Dominique Leuenberger <dimstar@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #11 from Dominique Leuenberger <dimstar@opensuse.org> --- (In reply to Nathan Cutler from comment #10)
Closing under the assumption that the patch works as advertised. I trust Dominique will reopen if there is any issue with it.
Of course I will - and DO Staging:F has been attempted to build with ceph 16.2.5.111+ga5b472dfcf8 but failed: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:F... [ 6280s] [ 48%] Building CXX object src/rgw/CMakeFiles/rgw_common.dir/rgw_datalog.cc.o [ 6296s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/rgw/rgw_kms.cc: In function 'void add_name_val_to_obj(const char*, std::string&, rapidjson::GenericValue<Encoding, Allocator>&, A&) [with E = rapidjson::UTF8<>; A = ZeroPoolAllocator]': [ 6296s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/rgw/rgw_kms.cc:85:29: warning: 'r' may be used uninitialized in this function [-Wmaybe-uninitialized] [ 6296s] 85 | if (r && old) memcpy(r, p, nw); [ 6296s] | ~~~~~~^~~~~~~~~~ [ 6296s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/rgw/rgw_kms.cc:82:15: note: 'r' was declared here [ 6296s] 82 | void *r; [ 6296s] | ^ [ 6296s] [ 48%] Building CXX object src/rgw/CMakeFiles/rgw_common.dir/cls_fifo_legacy.cc.o [ 6314s] [ 48%] Building CXX object src/rgw/CMakeFiles/rgw_common.dir/rgw_lua_utils.cc.o [ 6333s] [ 48%] Building CXX object src/rgw/CMakeFiles/rgw_common.dir/rgw_lua.cc.o [ 6334s] [ 48%] Building CXX object src/rgw/CMakeFiles/rgw_common.dir/rgw_lua_request.cc.o [ 6357s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/rgw/cls_fifo_legacy.cc: In member function 'void rgw::cls::fifo::FIFO::_update_meta(const DoutPrefixProvider*, const rados::cls::fifo::update&, rados::cls::fifo::objv, bool*, uint64_t, librados::v14_2_0::AioCompletion*)': [ 6357s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/rgw/cls_fifo_legacy.cc:578:8: warning: unused variable 'r' [-Wunused-variable] [ 6357s] 578 | auto r = ioctx.aio_operate(oid, Updater::call(std::move(updater)), &op); [ 6357s] | ^ [ 6357s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/rgw/cls_fifo_legacy.cc: In member function 'void rgw::cls::fifo::FIFO::read_meta(const DoutPrefixProvider*, uint64_t, librados::v14_2_0::AioCompletion*)': [ 6357s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/rgw/cls_fifo_legacy.cc:1292:8: warning: unused variable 'r' [-Wunused-variable] [ 6357s] 1292 | auto r = ioctx.aio_exec(oid, Reader::call(std::move(reader)), fifo::op::CLASS, [ 6357s] | ^ [ 6389s] [ 48%] Built target rgw_common [ 6389s] make: *** [Makefile:146: all] Error 2 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c12 --- Comment #12 from Nathan Cutler <ncutler@suse.com> --- OK, the actual error is: [ 5204s] In file included from /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/compressor/snappy/CompressionPluginSnappy.h:20, [ 5204s] from /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/compressor/snappy/CompressionPluginSnappy.cc:20: [ 5204s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/compressor/snappy/SnappyCompressor.h: In member function 'virtual int SnappyCompressor::decompress(ceph::buffer::v15_2_0::list::const_iterator&, size_t, ceph::bufferlist&, boost::optional<int>)': [ 5204s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/compressor/snappy/SnappyCompressor.h:103:13: error: 'uint32_t' is not a member of 'snappy' [ 5204s] 103 | snappy::uint32_t res_len = 0; [ 5204s] | ^~~~~~~~ [ 5204s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/compressor/snappy/SnappyCompressor.h:103:13: note: suggested alternatives: [ 5204s] In file included from /usr/include/stdint.h:37, [ 5204s] from /usr/lib64/gcc/x86_64-suse-linux/11/include/stdint.h:9, [ 5204s] from /usr/include/c++/11/bits/atomic_base.h:36, [ 5204s] from /usr/include/c++/11/atomic:41, [ 5204s] from /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/common/ceph_context.h:18, [ 5204s] from /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/compressor/snappy/CompressionPluginSnappy.cc:19: [ 5204s] /usr/include/bits/stdint-uintn.h:26:20: note: 'uint32_t' [ 5204s] 26 | typedef __uint32_t uint32_t; [ 5204s] | ^~~~~~~~ [ 5204s] /usr/include/bits/stdint-uintn.h:26:20: note: 'uint32_t' [ 5204s] /usr/include/bits/stdint-uintn.h:26:20: note: 'uint32_t' [ 5204s] /usr/include/bits/stdint-uintn.h:26:20: note: 'uint32_t' [ 5204s] In file included from /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/compressor/snappy/CompressionPluginSnappy.h:20, [ 5204s] from /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/compressor/snappy/CompressionPluginSnappy.cc:20: [ 5204s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/compressor/snappy/SnappyCompressor.h:106:52: error: 'res_len' was not declared in this scope [ 5204s] 106 | if (!snappy::GetUncompressedLength(&source_1, &res_len)) { [ 5204s] | ^~~~~~~ [ 5204s] /home/abuild/rpmbuild/BUILD/ceph-16.2.5-111-ga5b472dfcf8/src/compressor/snappy/SnappyCompressor.h:110:25: error: 'res_len' was not declared in this scope [ 5204s] 110 | ceph::bufferptr ptr(res_len); [ 5204s] | ^~~~~~~ [ 5204s] make[2]: *** [src/compressor/snappy/CMakeFiles/ceph_snappy.dir/build.make:76: src/compressor/snappy/CMakeFiles/ceph_snappy.dir/CompressionPluginSnappy.cc.o] Error 1 I will make another submission. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c13 --- Comment #13 from Nathan Cutler <ncutler@suse.com> --- Patch 2.0: https://build.opensuse.org/request/show/909439 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c14 --- Comment #14 from Nathan Cutler <ncutler@suse.com> --- @Dominique - would it make sense to put the SR directly into Staging:F this time, so we don't accept a non-working patch? Although I am more confident this time that the patch will work, I have not yet been able to get it to build locally. The latest attempt crashed and burned as follows: smithfarm@geras:~/filesystems:ceph:pacific/ceph> osc build --clean --alternative-project openSUSE:Factory:Staging:F Multiple build description files found: smithfarm@geras:~/filesystems:ceph:pacific/ceph> echo $? 2 which, on the face of it, looks like a bug? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1188741 http://bugzilla.opensuse.org/show_bug.cgi?id=1188741#c15 Nathan Cutler <ncutler@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #15 from Nathan Cutler <ncutler@suse.com> --- This time, I saw that both ceph and snappy 1.1.9 succeeded in the same project (openSUSE:Factory:Staging:F), so I think the bug can be declared fixed. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com