[Bug 229781] New: balsa-2.3.13-22: comparison with string literal
https://bugzilla.novell.com/show_bug.cgi?id=229781 Summary: balsa-2.3.13-22: comparison with string literal Product: openSUSE 10.3 Version: unspecified Platform: All OS/Version: SuSE Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de I just tried to compile package balsa-2.3.13-22. The compiler said toolbar-factory.c:320: warning: comparison with string literal The source code is if (toolbar_buttons[button].pixmap_id == BALSA_PIXMAP_SEND && balsa_app.always_queue_sent_mail) but linux:/usr/src/packages/SPECS # find ../BUILD/balsa-2.3.13/ -name \*.h -print | xargs fgrep BALSA_PIXMAP_SEND ./BUILD/balsa-2.3.13/src/balsa-icons.h:#define BALSA_PIXMAP_SEND "balsa_send" Suggest new code if ((strcmp( toolbar_buttons[button].pixmap_id, BALSA_PIXMAP_SEND) == 0) && balsa_app.always_queue_sent_mail) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=229781 mhorvath@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |sbrabec@novell.com |screening@forge.provo.novell| |.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=229781 ------- Comment #1 from sndirsch@novell.com 2007-01-16 15:30 MST ------- Feel free to close as duplicate of Bug #233655. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=229781 mvaner@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|sbrabec@novell.com |mvaner@novell.com Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=229781 mvaner@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #2 from mvaner@novell.com 2007-02-20 10:57 MST ------- Comparing in proper way (by strcmp) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply@novell.com