[Bug 854694] New: libvirt unit virsystemd test crashing on factory
https://bugzilla.novell.com/show_bug.cgi?id=854694 https://bugzilla.novell.com/show_bug.cgi?id=854694#c0 Summary: libvirt unit virsystemd test crashing on factory Classification: openSUSE Product: openSUSE Factory Version: 13.2 Milestone 0 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: fstrba@suse.com ReportedBy: cbosdonnat@suse.com QAContact: qa-bugs@suse.de Found By: --- Blocker: --- Created an attachment (id=571084) --> (http://bugzilla.novell.com/attachment.cgi?id=571084) crash backtrace Steps to reproduce: * git clone git://libvirt.org/libvirt.git * zypper si -d libvirt * zypper in make gcc * cd libvirt * ./autogen.sh * make check During make check tests/virsystemd will crash on factory (not on 13.1). The backtrace is attached to this bug. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=854694 https://bugzilla.novell.com/show_bug.cgi?id=854694#c1 Fridrich Strba <fstrba@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #1 from Fridrich Strba <fstrba@suse.com> 2013-12-17 08:55:52 UTC --- OK, so this is libvirt problem here. Dbus, since 1.7.6 initializes the threading any time a lock is requested and the threading is not initialized. This initialization is done in the last resort by dbus_threads_init_default() call, which normally takes care of the initialization. However, in the virtsystemdtest, namely in tests/virsystemdmock.c:34, the symbol is interposed by a stub that does nothing, but returns TRUE. Dbus thinks that the threading is now initialized and dereferences a NULL pointer with obvious result. I if-zeroed the stub in the test and the tests now pass just fine. I am attaching the trivial patch to do it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=854694 https://bugzilla.novell.com/show_bug.cgi?id=854694#c2 --- Comment #2 from Fridrich Strba <fstrba@suse.com> 2013-12-17 08:57:22 UTC --- Created an attachment (id=572073) --> (http://bugzilla.novell.com/attachment.cgi?id=572073) A patch to if-zero a stub that interposes dbus' threading initialization. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=854694 https://bugzilla.novell.com/show_bug.cgi?id=854694#c3 --- Comment #3 from Fridrich Strba <fstrba@suse.com> 2013-12-17 08:59:52 UTC --- BTW, the tests/virsystemdmock has some more dbus stubs. Maybe people that know why they are there should have a look and re-evaluate their usefulness. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=854694 https://bugzilla.novell.com/show_bug.cgi?id=854694#c4 Cédric Bosdonnat <cbosdonnat@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | AssignedTo|fstrba@suse.com |cbosdonnat@suse.com --- Comment #4 from Cédric Bosdonnat <cbosdonnat@suse.com> 2013-12-17 09:59:14 UTC --- Reopening and taking it to fix the bug on the libvirt side. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=854694 https://bugzilla.novell.com/show_bug.cgi?id=854694#c5 Cédric Bosdonnat <cbosdonnat@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #5 from Cédric Bosdonnat <cbosdonnat@suse.com> 2014-01-14 07:51:08 UTC --- Fixed both upstream and in Factory -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com