[Bug 472046] New: Add patch to xorg-server to fix a bug
https://bugzilla.novell.com/show_bug.cgi?id=472046 Summary: Add patch to xorg-server to fix a bug Classification: openSUSE Product: openSUSE 11.1 Version: Final Platform: Other OS/Version: openSUSE 11.1 Status: NEW Severity: Major Priority: P5 - None Component: X.Org AssignedTo: sndirsch@novell.com ReportedBy: lmedinas@gmail.com QAContact: xorg-maintainer-bugs@forge.provo.novell.com Found By: --- User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.5) Gecko/2008121300 SUSE/3.0.5-1.1 Firefox/3.0.5 Hi Xorg server contains a bug that was fixed in git master that was discovered by a development version of gnome-screensaver. Since the gnome team is trying to push GNOME 2.26 to 11.1 it would be good to add this patch to xorg-server as an update and just also be fixed in Factory. Thanks More information on: [1] - http://mail.gnome.org/archives/desktop-devel-list/2009-January/msg00315.html [2] - https://bugzilla.redhat.com/show_bug.cgi?id=474586 Reproducible: Always Steps to Reproduce: 1. 2. 3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User sndirsch@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c1 Stefan Dirsch <sndirsch@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium AssignedTo|sndirsch@novell.com |eich@novell.com --- Comment #1 from Stefan Dirsch <sndirsch@novell.com> 2009-02-03 11:04:20 MST --- I think this is something for Egbert to review. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 Luc Verhaegen <lverhaegen@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://cgit.freedesktop.org | |/xorg/xserver/commit/?id=1f | |4fb0225b CC| |lverhaegen@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User captain.magnus@opensuse.org added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c2 Magnus Boman <captain.magnus@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |captain.magnus@opensuse.org --- Comment #2 from Magnus Boman <captain.magnus@opensuse.org> 2009-02-06 13:32:55 MST --- I updated from Factory (latest X) and used latest GNOME from GNOME:Factory (2.25.90) and this happens even on the login screen now. I packaged a new Xorg with the patch in my home and X didn't use 100% cpu anymore. Please add this patch to both 11.1 and Factory -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User eich@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c3 --- Comment #3 from Egbert Eich <eich@novell.com> 2009-02-09 02:55:22 MST --- I've got severe issues with this patch: 1. (minor) + timeout = min(timeout, XSyncValueLow32 (value)); and + timeout = min(timeout, 0); why min()? It's a define, timeout and XSyncValueLow32() are unsigned, in the first case it's initialized to -1 in the latter to some value, therefore the result is always clear. This doesn't change the behavior of the function. 2. if (pIdleTimeValueLess && XSyncValueLessOrEqual (idle, *pIdleTimeValueLess)) { - AdjustWaitForDelay (wt, 0); .... + if (trig->CheckTrigger(trig, old_idle)) { + AdjustWaitForDelay(wt, 0); + break; + } } else if (pIdleTimeValueGreater) { ... } changes the function: AdjustWaitForDelay(wt, 0) in the original form was called whenever the first condition was true. Therefore the second test for pIdleTimeValueGreater was not required. However in the new version it may not have been called while the test for pIdleTimeValueGreater may still succeed. Thus we may end up not calling it at all although it should have been called. This the else should be removed and the 'break' after the AdjustWaitForDelay(wt, 0); should be replaced by: IdleTimeCounter->value = old_idle; return; 3. I don't see why we need to check for the trigger in this function. The greater and less brackets should have been set by SyncComputeBracketValues() so that djustWaitForDelay() only gets called when CheckTrigger for at least one Trigger would return true. I think the point of of having these brackets is exactly to not have to loop over all triggers every time IdleTimeBlockHandle() is called. I suspect the bug to be elsewhere however the investigation wasn't done thoroughly enough. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User vuntz@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c7 --- Comment #7 from Vincent Untz <vuntz@novell.com> 2009-02-09 07:05:19 MST --- Magnus said: (In reply to comment #2)
I updated from Factory (latest X) and used latest GNOME from GNOME:Factory (2.25.90) and this happens even on the login screen now.
And now the bug is P3. So. A bug making the CPU load 100% in Factory (because the packages in G:F will hit Factory really soon now) is P3? Something is wrong here. [I can understand why we might want to not push a 11.1 update, but for Factory...] -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User sndirsch@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c8 --- Comment #8 from Stefan Dirsch <sndirsch@novell.com> 2009-02-09 08:08:58 MST --- As you said, it's factory and not 11.1.
Something is wrong here. Yes, that's you.
[I can understand why we might want to not push a 11.1 update, but for Factory...]
Thanks for not trying to force us to apply a wrong patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User vuntz@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c9 --- Comment #9 from Vincent Untz <vuntz@novell.com> 2009-02-09 08:22:42 MST --- (In reply to comment #8)
As you said, it's factory and not 11.1.
Are you saying we don't care if Factory is not usable?
Something is wrong here. Yes, that's you.
[I can understand why we might want to not push a 11.1 update, but for Factory...]
Thanks for not trying to force us to apply a wrong patch.
It's a patch from upstream that got committed upstream. So we'll end up with it anyway. Applying it now will make things usable for Factory users now instead of having to wait, that's my only point. (also, was a bug opened upstream to try to explain why the patch was wrong and to get things fixed the right way?) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User sndirsch@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c10 --- Comment #10 from Stefan Dirsch <sndirsch@novell.com> 2009-02-09 08:33:30 MST ---
(also, was a bug opened upstream to try to explain why the patch was wrong and to get things fixed the right way?)
Feel free to open one. JFYI, Egbert did the analysis today. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User eich@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c11 --- Comment #11 from Egbert Eich <eich@novell.com> 2009-02-10 06:48:51 MST --- I will try to investigate the problem to see if I can come up with a better fix. What do I have to do for it? Install FACTORY with GNOME? Anything else? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User sndirsch@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c12 Stefan Dirsch <sndirsch@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |lmedinas@gmail.com --- Comment #12 from Stefan Dirsch <sndirsch@novell.com> 2009-02-10 07:09:55 MST --- Egbert, before you begin to investigate, could you verify that it isn't already investigated in Bug #473302? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User captain.magnus@opensuse.org added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c13 --- Comment #13 from Magnus Boman <captain.magnus@opensuse.org> 2009-02-10 14:48:27 MST --- Egbert, You don't need Factory. Just install GNOME from GNOME:Factory (http://widehat.opensuse.org/repositories/GNOME:/Factory/openSUSE_11.1/) on your 11.1 install. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 Stefan Dirsch <sndirsch@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|lmedinas@gmail.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User lmedinas@gmail.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c14 Luis Medinas <lmedinas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmedinas@gmail.com --- Comment #14 from Luis Medinas <lmedinas@gmail.com> 2009-02-17 20:43:16 MST --- It seems we are having some things missing here. We are only asking to add an upstream patch to fix this bug that will be present on 11.1 and Factory. If you care about a correct fix, contact who fixed (ajax) or submit a better fix on upstream. This is a critical bug that all GNOME 2.26 users will be notice. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User sndirsch@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c17 Stefan Dirsch <sndirsch@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|sndirsch@novell.com |eich@novell.com --- Comment #17 from Stefan Dirsch <sndirsch@novell.com> 2009-02-27 10:09:18 MST --- I'm going to switch to Xserver 1.6 for Factory anyway. Reassigning back to Egbert to further investigate upstream. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User sndirsch@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c18 Stefan Dirsch <sndirsch@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lchiquitto@novell.com --- Comment #18 from Stefan Dirsch <sndirsch@novell.com> 2009-02-28 10:07:29 MST --- *** Bug 480368 has been marked as a duplicate of this bug. *** https://bugzilla.novell.com/show_bug.cgi?id=480368 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User sndirsch@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c19 Stefan Dirsch <sndirsch@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matz@novell.com --- Comment #19 from Stefan Dirsch <sndirsch@novell.com> 2009-02-28 10:07:49 MST --- *** Bug 473302 has been marked as a duplicate of this bug. *** https://bugzilla.novell.com/show_bug.cgi?id=473302 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User aj@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c20 --- Comment #20 from Andreas Jaeger <aj@novell.com> 2009-03-03 06:42:07 MST --- This should be fixed for FACTORY with the update to 1.6 which is now in factory. For 11.1 it's still open. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User sndirsch@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c21 Stefan Dirsch <sndirsch@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jmatejek@novell.com --- Comment #21 from Stefan Dirsch <sndirsch@novell.com> 2009-03-03 09:07:27 MST --- *** Bug 481511 has been marked as a duplicate of this bug. *** https://bugzilla.novell.com/show_bug.cgi?id=481511 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User sndirsch@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c24 Stefan Dirsch <sndirsch@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Joachim.Reichelt@helmholtz- | |hzi.de --- Comment #24 from Stefan Dirsch <sndirsch@novell.com> 2009-03-21 22:52:03 MST --- *** Bug 485056 has been marked as a duplicate of this bug. *** https://bugzilla.novell.com/show_bug.cgi?id=485056 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User captain.magnus@opensuse.org added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c25 --- Comment #25 from Magnus Boman <captain.magnus@opensuse.org> 2009-03-21 23:41:18 MST --- So... With all the dupes, and the fact that you didn't change to code, that came from upstream, in Factory, why can't you guys release this as a patch? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User eich@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c26 --- Comment #26 from Egbert Eich <eich@novell.com> 2009-03-23 08:42:23 MST --- Created an attachment (id=281207) --> (https://bugzilla.novell.com/attachment.cgi?id=281207) Fix. I checked the patch and made some fixes to it. Besides there were more issues in the SYNC extension code which I also addressed. This patch applies to the to of GIT head. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User eich@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c27 Egbert Eich <eich@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|eich@novell.com |sndirsch@novell.com --- Comment #27 from Egbert Eich <eich@novell.com> 2009-03-23 08:43:23 MST --- Reassigning to Stefan for integration. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=472046 User sndirsch@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=472046#c28 Stefan Dirsch <sndirsch@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #28 from Stefan Dirsch <sndirsch@novell.com> 2009-03-23 10:35:47 MST --- Patch applied to Factory and X11:XOrg. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com