[Bug 897497] New: kiwi: EFI boot removes EFI partition rather than root partition on lxroot resize
https://bugzilla.novell.com/show_bug.cgi?id=897497 https://bugzilla.novell.com/show_bug.cgi?id=897497#c0 Summary: kiwi: EFI boot removes EFI partition rather than root partition on lxroot resize Classification: openSUSE Product: openSUSE Factory Version: 201409* Platform: aarch64 OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Installation AssignedTo: ms@suse.com ReportedBy: agraf@suse.com QAContact: ms@suse.com Found By: --- Blocker: --- When kiwi tries to resize its lxroot partition, it always assumes we're looking at partition 1 when we don't have a boot partition. However, this is wrong. In the EFI case, partition 1 is the EFI partition and partition 2 is our root partition, all without any boot partition. I don't quite understand why we're not just always using the RootPart parameter that the generation passed into us, but we should definitely trust it rather than a random 1 when it exists. diff --git a/system/boot/armv7l/oemboot/suse-repart b/system/boot/armv7l/oemboot/suse-repart index 86f03c0..a4045d8 100755 --- a/system/boot/armv7l/oemboot/suse-repart +++ b/system/boot/armv7l/oemboot/suse-repart @@ -165,7 +165,7 @@ function OEMRepartStandard { #====================================== # clean/backup boot partition #-------------------------------------- - if [ "$haveBootPartition" = "yes" ];then + if [ "$kiwi_RootPart" ];then pID=$kiwi_RootPart rootParam=$pID fi -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=897497 https://bugzilla.novell.com/show_bug.cgi?id=897497#c1 Marcus Schaefer <ms@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |agraf@suse.com --- Comment #1 from Marcus Schaefer <ms@suse.com> 2014-09-19 14:24:59 UTC --- haveBootPartition should not be set in that case Could you attach the full log /var/log/boot.kiwi I can check then why this is the case Thanks -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=897497 https://bugzilla.novell.com/show_bug.cgi?id=897497#c2 Alexander Graf <agraf@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|agraf@suse.com | --- Comment #2 from Alexander Graf <agraf@suse.com> 2014-09-19 15:01:01 UTC --- Yes, it is not set. That's why it falls back to the default which is pID=1. Partition 1 is the EFI partition though, so instead of resizing lxroot, the initrd removes the EFI partition, gets confused and drops into a shell. I've already replaced the image, so giving you that log is a non-trivial thing to do :). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=897497 https://bugzilla.novell.com/show_bug.cgi?id=897497#c3 Marcus Schaefer <ms@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Marcus Schaefer <ms@suse.com> 2014-09-19 15:40:58 UTC --- ok no problem I agree to what you have said and fixed the code accordingly -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=897497 https://bugzilla.novell.com/show_bug.cgi?id=897497#c4 Marcus Schaefer <ms@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #4 from Marcus Schaefer <ms@suse.com> 2014-09-19 16:17:44 UTC --- commit e665b2afe122d6229ccafe18eed08df9c75bc4e3 Author: Marcus Schäfer <ms@suse.de> Date: Fri Sep 19 17:32:26 2014 +0200 Eliminate use of haveBootPartition variable in the initrd code kiwi provides exact information in the partition ID's variables created when the image is build in setupPartIDs. The indicator if a boot partition is in use was not set correctly by the existing function. The indicator for a boot partition should be the filesystem label set to 'BOOT' and the check if this partition is not equal to the root partition. In the repartition code the partition ID for the root partition is always defined correctly by the kiwi_RootPart variable and should not depend on any condition. That way there was no code left which requires and extra boolean haveBootPartition variable and also fixes the wrong pID assignment described in bug (bnc #897497) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com