[Bug 531682] New: WindowMaker-0.92.0-207.13: 2 * missing call to close
http://bugzilla.novell.com/show_bug.cgi?id=531682 Summary: WindowMaker-0.92.0-207.13: 2 * missing call to close Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package WindowMaker-0.92.0-207.13 For source code file WindowMaker-0.92.0/WINGs/wcolorpanel.c around line 3650 is the source code for the function fetchFile. I notice the following lines of code if ((src = open(srcFile, O_RDONLY|O_BINARY)) == 0) { and if ((dest = open( tmp, O_RDWR|O_CREAT|O_BINARY, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH)) but I fail to notice any matching call to close. This looks like a double resource leak to me. Suggest add two calls to close. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=531682 shuang qiu <sqiu@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sqiu@novell.com AssignedTo|bnc-team-screening@forge.pr |mhrusecky@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=531682 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=531682#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:55:04 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com