[Bug 841764] New: crm-shll failed to change property "stonith-enabled"
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c0 Summary: crm-shll failed to change property "stonith-enabled" Classification: openSUSE Product: openSUSE Factory Version: 13.1 Beta 1 Platform: x86-64 OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: High Availability AssignedTo: lmb@suse.com ReportedBy: lzhong@suse.com QAContact: qa-bugs@suse.de Found By: --- Blocker: --- I want to remove stonith-enabled item when it is false. The steps I took are: 1, crm configure 2, edit, do the change 3, commit and it shows crm(live)configure# commit INFO: apparently there is nothing to commit INFO: try changing something first And this item is still there. opensuse131-1:~ # rpm -qi crmsh Name : crmsh Version : 1.2.6 Release : 0.rc3.48.3 Architecture: x86_64 Install Date: Mon 16 Sep 2013 02:46:51 PM CST -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c Lars Marowsky-Bree <lmb@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium CC| |dmuhamedagic@suse.com, | |lmb@suse.com AssignedTo|lmb@suse.com |kgronlund@suse.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c1 Dejan Muhamedagic <dmuhamedagic@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tserong@suse.com --- Comment #1 from Dejan Muhamedagic <dmuhamedagic@suse.com> 2013-09-23 11:51:36 CEST --- I'm afraid that there's no way to remove individual properties lest one replaces the configuration using "load replace" :( I just realized that the other day. The properties are always merged on configuration edit, never replaced. It got introduced to enable use such as this: # crm configure property n=v I am really unsure how should removing single properties be implemented. Please note that hawk depends on this particular behaviour. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c Dejan Muhamedagic <dmuhamedagic@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|crm-shll failed to change |crmsh failed to modify |property "stonith-enabled" |property "stonith-enabled" -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c2 --- Comment #2 from Lars Marowsky-Bree <lmb@suse.com> 2013-09-23 10:51:36 UTC --- (In reply to comment #1)
I'm afraid that there's no way to remove individual properties lest one replaces the configuration using "load replace" :(
That doesn't seem to match what Lidong described. I just tried it on SLE HA 11 SP3 and this worked for me: # crm configure crm(live)configure# edit (I removed the stonith-enabled="true" line using the editor) crm(live)configure# commit And that shows the stonith-enabled line gone from the CIB afterwards as expected. So what Lidong describes appears to be a problem in Factory only? (Yes, "crm configure property foo=bar" assumes that a new one is created, and many scripts/hawk rely on this. We may need an extension to the "delete" command for the other scenario, which seems to be more of a feature request: # delete property stonith-enabled) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c3 --- Comment #3 from Tim Serong <tserong@suse.com> 2013-09-23 11:54:23 UTC --- Hawk uses `crm configure property foo=bar` for setting properties, but to remove them it invokes `crm_attribute --attr-name foo --delete-attr` once per property to remove (which is arguably inefficient, but was the only workable thing I was able to come up with at the time I implemented it). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c4 --- Comment #4 from Dejan Muhamedagic <dmuhamedagic@suse.com> 2013-09-23 15:05:18 CEST --- Yes, it's a regression introduced by me here: changeset: 1014:12acfbfe94c6 user: Dejan Muhamedagic <dejan@hello-penguin.com> date: Mon Jul 22 11:51:22 2013 +0200 summary: Medium: cibconfig: refactor elements edit operation Kristoffer, please let me know if you need help with this one. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c5 --- Comment #5 from Dejan Muhamedagic <dmuhamedagic@suse.com> 2013-09-23 15:27:27 CEST --- OK, I found where is the issue: the ui code (ui.py) doesn't pass any more to the configuration edit whether it's the update or replace. Only the latter would actually work in this case and it's gone. The critical part is in cibconfig.py: 2952 def update_from_cli(self, obj, cli_list): .. 2964 elif obj.obj_type in vars.nvset_cli_names: 2965 self.merge_from_cli(obj, cli_list) 2966 return True -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c6 --- Comment #6 from Kristoffer Gronlund <kgronlund@suse.com> 2013-09-23 15:41:11 UTC --- Proposed fix committed in http://hg.savannah.gnu.org/hgweb/crmsh/rev/3de16c20fbea -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c7 Dejan Muhamedagic <dmuhamedagic@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |lzhong@suse.com --- Comment #7 from Dejan Muhamedagic <dmuhamedagic@suse.com> 2013-09-24 09:55:18 CEST --- Thanks, Kristoffer, that's a good patch. I just set the default method to 'replace', as it should be. The edit regression test case amended to include adding and removing properties. This should be OK now. Lidong, can you please test and close if it works. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c8 --- Comment #8 from Lidong Zhong <lzhong@suse.com> 2013-09-24 08:48:48 UTC --- Thanks for the fix.Once this patch is submitted to network:ha-clustering:Factory, I will do the test. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c10 Lidong Zhong <lzhong@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |FIXED --- Comment #10 from Lidong Zhong <lzhong@suse.com> 2013-09-27 02:13:03 UTC --- Yes,it works.Thank you.Close it now. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c Lars Marowsky-Bree <lmb@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |RESOLVED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |maint:running:55800:moderat | |e -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c11 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:55800:moderat |maint:running:55800:moderat |e |e | |maint:released:sle11-sp3:55 | |801 --- Comment #11 from Swamp Workflow Management <swamp@suse.de> 2014-01-27 16:48:55 UTC --- Update released for: crmsh Products: SLE-HAE 11-SP3 (i386, ia64, ppc64, s390x, x86_64) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c12 --- Comment #12 from Swamp Workflow Management <swamp@suse.de> 2014-01-27 20:04:38 UTC --- SUSE-RU-2014:0141-1: An update that has two recommended fixes can now be installed. Category: recommended (moderate) Bug References: 841764,858257 CVE References: Sources used: SUSE Linux Enterprise High Availability Extension 11 SP3 (src): crmsh-1.2.6-0.27.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=841764 https://bugzilla.novell.com/show_bug.cgi?id=841764#c Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:55800:moderat |maint:released:sle11-sp3:55 |e |801 |maint:released:sle11-sp3:55 | |801 | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com