[Bug 763397] New: by-id device link incorrect for USB hard disk disk drive
https://bugzilla.novell.com/show_bug.cgi?id=763397 https://bugzilla.novell.com/show_bug.cgi?id=763397#c0 Summary: by-id device link incorrect for USB hard disk disk drive Classification: openSUSE Product: openSUSE 12.1 Version: Final Platform: x86-64 OS/Version: openSUSE 12.1 Status: NEW Severity: Minor Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: jdelvare@suse.com QAContact: qa-bugs@suse.de CC: rmilasan@suse.com, gregkh@linux.com Found By: Community User Blocker: --- The by-id device link created for my external Seagate hard disk drive looks wrong: scsi-SSeagate_FreeAgentDeskto_5QF4BSZV -> ../../sdc scsi-SSeagate_FreeAgentDeskto_5QF4BSZV-part1 -> ../../sdc1 I'd expect Seagate_FreeAgentDesktop, not SSeagate_FreeAgentDeskto. Looks like an off-by-one string copy. The sysfs attributes for this disk have the correct values: manufacturer:Seagate product:FreeAgentDesktop So I suspect a bug in some udev rule. The links looked different on openSUSE 11.4 but did not have this issue. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=763397 https://bugzilla.novell.com/show_bug.cgi?id=763397#c Petr Uzel <puzel@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |ASSIGNED AssignedTo|bnc-team-screening@forge.pr |puzel@suse.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=763397 https://bugzilla.novell.com/show_bug.cgi?id=763397#c1 --- Comment #1 from Jean Delvare <jdelvare@suse.com> 2012-05-22 09:13:20 UTC --- # /lib/udev/scsi_id --export --whitelisted -d /dev/sdc ID_SCSI=1 ID_VENDOR=Seagate ID_VENDOR_ENC=Seagate\x20 ID_MODEL=FreeAgentDesktop ID_MODEL_ENC=FreeAgentDesktop ID_REVISION=100D ID_TYPE=disk ID_SERIAL=1ST3320820AS_5QF4BSZV ID_SERIAL_SHORT=ST3320820AS_5QF4BSZV ID_SCSI_SERIAL= 5QF4BSZV # -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=763397 https://bugzilla.novell.com/show_bug.cgi?id=763397#c2 --- Comment #2 from Jean Delvare <jdelvare@suse.com> 2012-05-22 09:19:56 UTC --- And now the interesting one... # /lib/udev/scsi_id --whitelisted --replace-whitespace -p0x80 -d /dev/sdc SSeagate_FreeAgentDeskto_5QF4BSZV # -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=763397 https://bugzilla.novell.com/show_bug.cgi?id=763397#c3 --- Comment #3 from Jean Delvare <jdelvare@suse.com> 2012-05-22 13:29:09 UTC --- Created an attachment (id=491925) --> (http://bugzilla.novell.com/attachment.cgi?id=491925) Fix truncated model in by-id device links The bug has been there forever as far as I can see, and is still present upstream. I think it only affects devices with a model string of 16 characters or more, which would explain why nobody reported the bug before. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=763397 https://bugzilla.novell.com/show_bug.cgi?id=763397#c4 Robert Milasan <rmilasan@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |jdelvare@suse.com --- Comment #4 from Robert Milasan <rmilasan@suse.com> 2012-05-22 13:41:37 UTC --- Jean have you tested the patch? I mean it works as it should? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=763397 https://bugzilla.novell.com/show_bug.cgi?id=763397#c5 Jean Delvare <jdelvare@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|jdelvare@suse.com | --- Comment #5 from Jean Delvare <jdelvare@suse.com> 2012-05-22 13:58:05 UTC --- Yes, the patch works as intended, but... Actually if affects a lot more devices than I thought, both my internal SSD and HDD are affected as well, simply it's less visible because they have barbarian model strings in the first place. The only devices not affected would be devices with a model string ending with several spaces. The fix should be pushed upstream, but we can NOT do that kind of change in a released product, it could break partition mounting. I'm glad we don't use the faulty links by default for simple SATA drives, but I have no idea if they are used in other cases (SCSI/SAS, LVM, MD/DM, etc.) Thinking about it, the fix would have a huge impact, and we probably shouldn't apply it to Factory if we don't offer a complete migration path. If this is doable at all... Oh well, maybe I shouldn't have reported this bug in the first place... :/ -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=763397 https://bugzilla.novell.com/show_bug.cgi?id=763397#c6 --- Comment #6 from Petr Uzel <puzel@suse.com> 2012-05-22 14:34:47 UTC --- Thanks for the patch! (In reply to comment #5)
Thinking about it, the fix would have a huge impact, and we probably shouldn't apply it to Factory if we don't offer a complete migration path. If this is doable at all...
I think this should be pushed upstream and if and only if upstream accepts this, then eventually in Factory, not anywhere else. We are already having fun with changed by-id links between service packs.
Oh well, maybe I shouldn't have reported this bug in the first place... :/
Come on... :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=763397 https://bugzilla.novell.com/show_bug.cgi?id=763397#c7 --- Comment #7 from Jean Delvare <jdelvare@suse.com> 2012-05-23 07:33:11 UTC --- BTW, if my fix is accepted by upstream, then it's probably the right time to improve the readability of these links. Right now there is no guarantee that there will be a separator between the different components (vendor, model, serial number) of the by-id/scsi-* links. by-id/ata-* links for example do it properly AFAICS. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=763397 https://bugzilla.novell.com/show_bug.cgi?id=763397#c8 Petr Uzel <puzel@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 - Medium |P4 - Low --- Comment #8 from Petr Uzel <puzel@suse.com> 2012-05-25 14:09:33 UTC --- Patch submitted upstream. I'll check how readability of the links can be improved later. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=763397 https://bugzilla.novell.com/show_bug.cgi?id=763397#c9 Robert Milasan <rmilasan@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #9 from Robert Milasan <rmilasan@suse.com> 2013-04-05 07:41:47 UTC --- Fix in the newer version, closing this as RESOLVED/FIXED. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com