https://bugzilla.novell.com/show_bug.cgi?id=353297 User poeml@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=353297#c1 Peter Poeml changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |suse-tux@gmx.de Status|NEW |NEEDINFO Info Provider| |mfabian@novell.com --- Comment #1 from Peter Poeml 2008-01-22 04:35:02 MST --- This feature got lost with the rework in commit 2644. That commit made "diff" more svn like. Indeed, svn doesn't return 1 or 0 depending on the existance of local modifications. Do you really want to use "osc diff" (generating a diff) when you just want to know if there are local changes? Wouldn't it be easier to just check with "osc status | grep '^M'" ? That's more efficient, and it is a well-defined way. I was never for exiting 1, but I somehow got talked into it, and of course there weren't really reasons to not do it. Except that it causes work for somebody now ;) Would be interesting to gather opinions from the opensuse-buildservice mailing list about this. What do you think, Mike, apart from the fact that your script broke? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=353297 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=353297#c3 --- Comment #3 from Mike Fabian 2008-01-22 08:08:02 MST --- I have changed my script in the meantime to use if [ "$(osc diff)" != "" ] ; then instead of the osc diff if [ $? -ne 0 ] ; then I used previously. Therefore, my script works again and if you think that the return value of “osc diff” should be always 0 to make it more svn like, this is OK with me. I had just wondered whether the change in behaviour was intentional. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=353297 User poeml@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=353297#c5 Peter Poeml changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME --- Comment #5 from Peter Poeml 2008-02-19 05:40:27 MST --- I'll close this bug as worksforme then. If there are strong opinions about the behaviour, let's revisit it later and discuss it on the mailing list. Thanks for the report! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.