[Bug 524556] New: extreme-tuxracer-0.4-96.4: 2 * bad calls to C++ STL erase
http://bugzilla.novell.com/show_bug.cgi?id=524556 Summary: extreme-tuxracer-0.4-96.4: 2 * bad calls to C++ STL erase Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: Other OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package extreme-tuxracer-0.4-96.4. For source code file extremetuxracer-0.4/src/ppgltk/audio/audio_data.cpp, around line 440 is the source code for the function delete_unused_audio_data. I notice the following code soundTable.erase(sit); This looks wrong to me. The C++ STL iterator sit will be invalidated by this call. Suggest code rework. Similar problems a few lines further down with C++ STL iterator mit. musicTable.erase(mit); -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524556 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |mmaher@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524556 User mmaher@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=524556#c1 Maximilian Maher <mmaher@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |WONTFIX --- Comment #1 from Maximilian Maher <mmaher@novell.com> 2009-07-23 08:48:44 MDT --- We don't see any Problem with this Code that affect the game. Please contact the upstream developer: volker@planetpenguin.de -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524556 User dcb314@hotmail.com added comment http://bugzilla.novell.com/show_bug.cgi?id=524556#c2 David Binderman <dcb314@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|CLOSED |REOPENED Resolution|WONTFIX | --- Comment #2 from David Binderman <dcb314@hotmail.com> 2009-08-25 04:37:23 MDT --- (In reply to comment #1)
We don't see any Problem with this Code that affect the game.
Standard problem in C++ - erase invalidates iterators. See http://www.cplusplus.com/reference/stl/vector/erase/ -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524556 User mmaher@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=524556#c3 --- Comment #3 from Maximilian Maher <mmaher@novell.com> 2009-10-05 03:12:22 MDT ---
Please contact the upstream developer: volker@planetpenguin.de
Will inform upstream about this "bug". -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524556 User mmaher@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=524556#c4 Maximilian Maher <mmaher@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 - Medium |P5 - None Status|REOPENED |CLOSED Resolution| |UPSTREAM Severity|Normal |Enhancement --- Comment #4 from Maximilian Maher <mmaher@novell.com> 2009-10-05 03:13:25 MDT --- - -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com