[Bug 1180132] New: roundcubemail should recommend httpd, not require lighttpd
http://bugzilla.opensuse.org/show_bug.cgi?id=1180132 Bug ID: 1180132 Summary: roundcubemail should recommend httpd, not require lighttpd Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: x86-64 OS: openSUSE Tumbleweed Status: NEW Severity: Normal Priority: P5 - None Component: Apache Assignee: bnc-team-apache@forge.provo.novell.com Reporter: jimc@jfcarter.net QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Versions: roundcubemail-1.4.9-2.1.noarch (updated 2020-12-15, yesterday) lighttpd-1.4.55-4.1.x86_64 apache2-2.4.46-9.1.x86_64 roundcubemail newly requires lighttpd by name. On my webserver, Apache is the HTTP infrastructure that sends out RoundCube. I hit some snarl-ups with both lighttpd and apache2 installed together (my hacks, not your fault). I wanted to just de-install lighttpd, but roundcubemail has a hard requirement for it. So instead I'm fixing the snarl-up and letting lighttpd sit unused, until it's no longer required. Lighttpd is a nice package and I used it on a project where a lightweight webserver was needed, but in this case roundcubemail needs to defer to the sysop's choice of webserver. Could you please refer to "httpd" as the facility needed by roundcubemail rather than picking a specific one of the various available webservers? Both apache2 and lighttpd provide this generic facility, and I assume that nginx does also. Also, it's a little bizarre and inefficient to install roundcubemail on a different host from the webserver and then make it available to the webserver on a SAN-like kludge like NFS, but that kind of baroque storage architecture seems to be the name of the game in the enterprise today. I'd also like you to change "require" to "recommend" to accommodate situations like that. I'm surprised not to see any hits in a bug search for "roundcubemail lighttpd" that I could add a "mee too" comment to. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1180132 http://bugzilla.opensuse.org/show_bug.cgi?id=1180132#c2 Michael Str�der <michael@stroeder.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael@stroeder.com --- Comment #2 from Michael Str�der <michael@stroeder.com> --- Currently roundcubemail has Requires: http_daemon But this still seems to require lighttpd even if apache2 is installed. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1180132 http://bugzilla.opensuse.org/show_bug.cgi?id=1180132#c3 --- Comment #3 from Michael Str�der <michael@stroeder.com> --- I've submitted a fix to apache2 package (similar to what's done in nginx package): https://build.opensuse.org/request/show/865975 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1180132 http://bugzilla.opensuse.org/show_bug.cgi?id=1180132#c5 Arjen de Korte <suse+build@de-korte.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |suse+build@de-korte.org --- Comment #5 from Arjen de Korte <suse+build@de-korte.org> --- (In reply to Michael Str�der from comment #3)
I've submitted a fix to apache2 package (similar to what's done in nginx package):
This fix is incorrect. Roundcubemail requires mod_php_any, which is only provided by apache2-mod_php{7,8}, which in turn requires apache2-prefork. It makes absolutely no sense to also require httpd_daemon or httpd if there is only one webserver which can provide this dependency, so the correct fix would be to drop the http_daemon from roundcubemail. Besides that, if you allow to run on different webservers, they are going to need different configurations as well and I doubt the roundcubemail package is completely agostic towards the type of webserver used. It would be much better if roundcubemail would allow running on different webservers. Put the common stuff for all webservers would in the roundcube main package and the configurations for different combinations of webservers and PHP in subpackages. The main package would then require something each subpackage provides like (non-exhaustive list, but this should be a hint in the right direction). See https://en.opensuse.org/openSUSE:Packaging_PHP#Supporting_different_web_serv... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1180132 http://bugzilla.opensuse.org/show_bug.cgi?id=1180132#c6 --- Comment #6 from Michael Str�der <michael@stroeder.com> --- (In reply to Arjen de Korte from comment #5)
This fix is incorrect. Roundcubemail requires mod_php_any, which is only provided by apache2-mod_php{7,8}, which in turn requires apache2-prefork.
Could you please explain why roundcubemail has a hard require to lighttpd? BTW: roundcubemail with php8 is currently broken. Following your arguments this dependency on lighttpd is plain wrong. I do not claim to have full oversight here. Feel free to provide a better solution. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1180132 http://bugzilla.opensuse.org/show_bug.cgi?id=1180132#c7 --- Comment #7 from Arjen de Korte <suse+build@de-korte.org> --- (In reply to Michael Str�der from comment #6)
Could you please explain why roundcubemail has a hard require to lighttpd? BTW: roundcubemail with php8 is currently broken.
Yes, through the (wrong) http_daemon requirement.
Following your arguments this dependency on lighttpd is plain wrong.
It is, the roundcubemail only bundles an apache2 configuration, so it should require apache2 instead.
I do not claim to have full oversight here. Feel free to provide a better solution.
SR#866030 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1180132 http://bugzilla.opensuse.org/show_bug.cgi?id=1180132#c8 --- Comment #8 from Michael Str�der <michael@stroeder.com> --- (In reply to Arjen de Korte from comment #5)
Besides that, if you allow to run on different webservers, they are going to need different configurations as well and I doubt the roundcubemail package is completely agostic towards the type of webserver used.
How about dropping dependency on web server completely? Because if someone wants to configure roundcubemail running under control php-fpm it's not required to have use apache2-mod_php{7,8} with apache2-prefork. Yes, this needs a php-fpm config but this does not have to be part of the package. So I'd argue to only recommend installation of apache2-mod_php{7,8}. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1180132 http://bugzilla.opensuse.org/show_bug.cgi?id=1180132#c9 --- Comment #9 from Arjen de Korte <suse+build@de-korte.org> --- (In reply to Michael Str�der from comment #8)
How about dropping dependency on web server completely? Because if someone wants to configure roundcubemail running under control php-fpm it's not required to have use apache2-mod_php{7,8} with apache2-prefork.
Might be possible, but then you'd have to package the configuration files for apache in a separate package that would only be installed if apache2 was installed through Supplements: packageand(apache2:%{name}) You can find a real-world example in the wordpress package.
Yes, this needs a php-fpm config but this does not have to be part of the package.
No, but it might need some additional configuration files for php-fpm which you may want to install if PHP-FPM is used.
So I'd argue to only recommend installation of apache2-mod_php{7,8}.
That wouldn't be possible right now, as you're installing files in directories owned by apache2. Again, see https://en.opensuse.org/openSUSE:Packaging_PHP#Supporting_different_web_serv... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1180132 http://bugzilla.opensuse.org/show_bug.cgi?id=1180132#c10 --- Comment #10 from Michael Str�der <michael@stroeder.com> --- First things first: https://build.opensuse.org/request/show/866038 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1180132 http://bugzilla.opensuse.org/show_bug.cgi?id=1180132#c11 --- Comment #11 from Arjen de Korte <suse+build@de-korte.org> --- (In reply to Michael Str�der from comment #10)
First things first:
https://build.opensuse.org/request/show/866030 ;-) -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1180132 http://bugzilla.opensuse.org/show_bug.cgi?id=1180132#c12 --- Comment #12 from Michael Str�der <michael@stroeder.com> --- (In reply to Arjen de Korte from comment #11)
(In reply to Michael Str�der from comment #10)
First things first:
I fail to see the improvement. But I don't care for packaging academics. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1180132 http://bugzilla.opensuse.org/show_bug.cgi?id=1180132#c13 --- Comment #13 from Arjen de Korte <suse+build@de-korte.org> --- (In reply to Michael Str�der from comment #12)
I fail to see the improvement.
It adds php-cli as a BuildRequires, which will be needed once Tumbleweed moves from default php7 to php8 (but this will not be very soon, because of some major changes in PHP-8 that would probably break all existing packages). -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1180132 http://bugzilla.opensuse.org/show_bug.cgi?id=1180132#c14 --- Comment #14 from OBSbugzilla Bot <bwiedemann+obsbugzillabot@suse.com> --- This is an autogenerated message for OBS integration: This bug (1180132) was mentioned in https://build.opensuse.org/request/show/992584 Backports:SLE-15-SP3+Backports:SLE-15-SP4 / roundcubemail -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@suse.com