https://bugzilla.novell.com/show_bug.cgi?id=231711 Summary: krusader-1.70.1-36: comparison with string literal Product: openSUSE 10.3 Version: unspecified Platform: All OS/Version: SuSE Other Status: NEW Severity: Normal Priority: P5 - None Component: KDE AssignedTo: kde-maintainers@suse.de ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de I just tried to compile package krusader-1.70.1-36 The compiler said /usr/src/packages/BUILD/krusader-1.70.1/krusader/Konfigurator/kgcolors.cpp:589: warning: comparison with string literal The source code is if( name == "KDE Default" || name == "Enable Alternate Background" || name == "Show Current Item Always" ) I agree with the compiler. Suggest new code if( (strcmp( name, "KDE Default") == 0) || (strcmp( name, "Enable Alternate Background") == 0) || (strcmp( name, "Show Current Item Always") == 0)) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.