[Bug 961982] New: osc ci mangles my spec file
http://bugzilla.novell.com/show_bug.cgi?id=961982 Bug ID: 961982 Summary: osc ci mangles my spec file Classification: openSUSE Product: openSUSE Distribution Version: Leap 42.1 Hardware: x86-64 OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Maintenance Assignee: bnc-team-screening@forge.provo.novell.com Reporter: davejplater@gmail.com QA Contact: qa-bugs@suse.de CC: suse-tux@gmx.de Found By: Community User Blocker: --- Created attachment 661828 --> http://bugzilla.novell.com/attachment.cgi?id=661828&action=edit Spec file untouched by osc ci I liked the way that osc ci formated my spec files but now it starting to cause serious problems. I maintain graphics/OpenImageIO, it has the following conditional in the build section : cmake \ %ifarch ppc ppc64 -DNOTHREADS=ON \ %endif -DCMAKE_INSTALL_PREFIX=%{_prefix} \ -DLIB_INSTALL_DIR=%{_libdir} \ -DPYLIB_INSTALL_DIR=%{python_sitearch} \ -DINSTALL_DOCS:BOOL=ON \ -DDOC_INSTALL_DIR=%{_docdir}/%{name} \ -DINSTALL_FONTS:BOOL=ON \ -DBUILDSTATIC:BOOL=OFF \ -DLINKSTATIC:BOOL=OFF \ -DUSE_EXTERNAL_PUGIXML:BOOL=ON \ -DUSE_FFMPEG:BOOL=OFF \ -DUSE_OPENSSL:BOOL=ON \ -DCMAKE_SKIP_RPATH:BOOL=ON \ .. on check in %ifarch ppc ppc64 gets moved to the bottom of the build section. This particular build doesn't work with %cmake either but I keep on getting a NOTE telling me to use it. Lastly I think that : BuildRoot: %{_tmppath}/%{name}-%{version}-build should be after BuildRequires: not in the middle. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=961982
http://bugzilla.novell.com/show_bug.cgi?id=961982#c1
--- Comment #1 from Dave Plater
http://bugzilla.novell.com/show_bug.cgi?id=961982
http://bugzilla.novell.com/show_bug.cgi?id=961982#c2
Marcus Hüwe
I liked the way that osc ci formated my spec files but now it starting to cause serious problems. I maintain graphics/OpenImageIO, it has the following conditional in the build section :
osc does _not_ format the spec file - it is the format_spec_file service, which is configured for the graphics/OpenImageIO package. The best is to file a bug against the obs-service-format_spec_file service (see https://github.com/openSUSE/obs-service-format_spec_file). Hence, I'm closing this bug as "INVALID" (if you don't agree, please reopen:) ). -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=961982
http://bugzilla.novell.com/show_bug.cgi?id=961982#c3
Dave Plater
http://bugzilla.novell.com/show_bug.cgi?id=961982
http://bugzilla.novell.com/show_bug.cgi?id=961982#c4
--- Comment #4 from Dave Plater
http://bugzilla.novell.com/show_bug.cgi?id=961982
Martin Pluskal
http://bugzilla.novell.com/show_bug.cgi?id=961982
http://bugzilla.novell.com/show_bug.cgi?id=961982#c5
Dave Plater
http://bugzilla.novell.com/show_bug.cgi?id=961982
http://bugzilla.novell.com/show_bug.cgi?id=961982#c6
--- Comment #6 from Dave Plater
http://bugzilla.novell.com/show_bug.cgi?id=961982
http://bugzilla.novell.com/show_bug.cgi?id=961982#c7
Tomáš Chvátal
http://bugzilla.novell.com/show_bug.cgi?id=961982
http://bugzilla.novell.com/show_bug.cgi?id=961982#c8
--- Comment #8 from Tomáš Chvátal
http://bugzilla.novell.com/show_bug.cgi?id=961982
http://bugzilla.novell.com/show_bug.cgi?id=961982#c9
--- Comment #9 from Tomáš Chvátal
http://bugzilla.novell.com/show_bug.cgi?id=961982
http://bugzilla.novell.com/show_bug.cgi?id=961982#c10
--- Comment #10 from Dave Plater
3) The commentary added above the cmake call is work-as-designed. Tho I have to >wonder why your package does not compile with the macro...
I'm not sure exactly which of the flags causes the build failure, I suspect it's -DCMAKE_INSTALL_LIBDIR interferes with -DLIB_INSTALL_DIR=%{_libdir} the build doesn't find libraries. I use %cmake where I can, I don't use it for blender as well because blender has so many flags and they change with every release %cmake makes it difficult to read the build log. I didn't realize that spec-file-cleaner-format_spec_file was experimental and I also didn't realise that it worked on osc. You should explain these things in the description. Would you like me to use this bug to report other problems that I find in spec-file-cleaner? I won't use spec-file-cleaner-format_spec_file. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=961982
http://bugzilla.novell.com/show_bug.cgi?id=961982#c11
--- Comment #11 from Dave Plater
http://bugzilla.novell.com/show_bug.cgi?id=961982
http://bugzilla.novell.com/show_bug.cgi?id=961982#c12
--- Comment #12 from Tomáš Chvátal
http://bugzilla.novell.com/show_bug.cgi?id=961982
http://bugzilla.novell.com/show_bug.cgi?id=961982#c13
--- Comment #13 from Tomáš Chvátal
(In reply to Tomáš Chvátal from comment #7)
3) The commentary added above the cmake call is work-as-designed. Tho I have to >wonder why your package does not compile with the macro...
I'm not sure exactly which of the flags causes the build failure, I suspect it's -DCMAKE_INSTALL_LIBDIR interferes with -DLIB_INSTALL_DIR=%{_libdir} the build doesn't find libraries. Hmm seems one of the unfortunate projects that does work with libdir just almost correctly. It should work fine if you override both of these to to relative path (to contain just lib/lib64 using the %_lib.
I didn't realize that spec-file-cleaner-format_spec_file was experimental and I also didn't realise that it worked on osc. You should explain these things in the description.
Not sure, it was not intended to be installed by the user that is why it is written that it is replacement for osc-format_spec_file so user should change it only if he knows what is the former :) But feel free to send update for the description if you figure it out how to word it better. As you are first one actually reporting bugs I would say so far it worked well and people didn't notice it :)
Would you like me to use this bug to report other problems that I find in spec-file-cleaner? I won't use spec-file-cleaner-format_spec_file. Not really, we have github.com/openSUSE/spec-cleaner for tracking issues in it. But if you don't have a github account feel free to open another bugs here.
-- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=961982
http://bugzilla.novell.com/show_bug.cgi?id=961982#c14
--- Comment #14 from Dave Plater
participants (1)
-
bugzilla_noreply@novell.com