[Bug 328546] New: libzypp crashes on non-translated pattern file
https://bugzilla.novell.com/show_bug.cgi?id=328546 Summary: libzypp crashes on non-translated pattern file Product: openSUSE 10.3 Version: RC 2 Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: libzypp AssignedTo: kkaempf@novell.com ReportedBy: visnov@novell.com QAContact: kkaempf@novell.com Found By: --- Created an attachment (id=174868) --> (https://bugzilla.novell.com/attachment.cgi?id=174868) Pattern introducing the crash I've tried to generate add-on product via add-on product creator. The generated product cannot be installed via YaST, because libzypp crash. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c1 --- Comment #1 from Stanislav Visnovsky <visnov@novell.com> 2007-09-26 08:55:37 MST --- Backtrace: #0 0xb7221fe7 in zypp::TranslatedText::setText () from /usr/lib/libzypp.so.324 #1 0xb6f3aa2a in zypp::parser::susetags::PatternFileReader::consume () from /usr/lib/libzypp.so.324 #2 0xb6f9b25e in zypp::parser::TagParser::parse () from /usr/lib/libzypp.so.324 #3 0xb6f3e7d7 in zypp::parser::susetags::RepoParser::Impl::parse () from /usr/lib/libzypp.so.324 #4 0xb6f41196 in zypp::parser::susetags::RepoParser::parse () from /usr/lib/libzypp.so.324 #5 0xb7253e02 in zypp::RepoManager::buildCache () from /usr/lib/libzypp.so.324 #6 0xb5bcdba9 in PkgModuleFunctions::createManagedSource () from /usr/lib/YaST2/plugin/libpy2Pkg.so.2 #7 0xb5bd1e1b in PkgModuleFunctions::SourceScan () from /usr/lib/YaST2/plugin/libpy2Pkg.so.2 #8 0xb5b7d15f in Y2PkgFunction::evaluateCall () from /usr/lib/YaST2/plugin/libpy2Pkg.so.2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c2 --- Comment #2 from Stanislav Visnovsky <visnov@novell.com> 2007-09-26 08:56:48 MST --- Created an attachment (id=174870) --> (https://bugzilla.novell.com/attachment.cgi?id=174870) y2logs -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546 Stanislav Visnovsky <visnov@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|libzypp crashes on non-translated pattern file |libzypp crashes add-on pattern file -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546 Klaus Kämpf <kkaempf@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ma@novell.com AssignedTo|kkaempf@novell.com |dmacvicar@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c3 Duncan Mac-Vicar <dmacvicar@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|dmacvicar@novell.com |ma@novell.com --- Comment #3 from Duncan Mac-Vicar <dmacvicar@novell.com> 2007-09-26 09:32:42 MST --- The pattern is broken: Missing version and pat tag =Ver: 5.0 =Pat: base-32bit 10.3 157 x86_64 However, it should not crash. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546 Stanislav Visnovsky <visnov@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |328816 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c5 Jiří Suchomel <jsuchome@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsuchome@novell.com --- Comment #5 from Jiří Suchomel <jsuchome@novell.com> 2007-09-27 02:12:07 MST --- The Ver and Pat tags _are_ present in the pattern, they're just not at the beginning. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c6 --- Comment #6 from Duncan Mac-Vicar <dmacvicar@novell.com> 2007-09-27 04:16:48 MST --- Which is broken. See http://en.opensuse.org/Libzypp/Metadata/YaST/pattern =Ver: Syntax version Minimal parser version needed to parse this file. Should be set to 5.0 for Code10 =Pat: name version release architecture All four values are mandatory And it is rather obvious that the version should go at the beginning. The version is the information you want to use to modify the behavior of the parser, and you need to know it forehands. It is also obvious that the Pat tag is used to know when the data for a new pattern starts (=Pkg tag is used in packages file) so it _needs_ to be at the beginning. Even if the order for the other tags is not specified in terms of the parser implementation (other tags are interpreted as they are found, comparing the tag names ) why would any pattern writter change the order? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c7 --- Comment #7 from Jiří Suchomel <jsuchome@novell.com> 2007-09-27 04:51:38 MST --- Sorry, this is not obvious. The pattern definition doesn't say anything about the order and _how_ any pattern parser actually parses the file.
why would any pattern writter change the order?
The order was not changed, it was created for new pattern. You can see that the order is aplhabetical. I think it is really strange becasuse add-on-creator uses this order for a while and nobody complained about broken patterns. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c8 Jiří Suchomel <jsuchome@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pnemec@novell.com Status|NEW |NEEDINFO Info Provider| |dmacvicar@novell.com --- Comment #8 from Jiří Suchomel <jsuchome@novell.com> 2007-09-27 05:16:03 MST --- For example SLEPOS team uses Add-On created by yast2-add-on-creator at: http://sleposlab.suse.cz/repository/ and they say it is working. But they base it on SLE10SP1: was the parser changed for openSUSE10.3? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c9 --- Comment #9 from Duncan Mac-Vicar <dmacvicar@novell.com> 2007-09-27 05:20:18 MST --- Yes. All parsers where written from scratch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c10 Jiří Suchomel <jsuchome@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|dmacvicar@novell.com | --- Comment #10 from Jiří Suchomel <jsuchome@novell.com> 2007-09-27 05:23:09 MST --- .. but the pattern definition didn't changed. It seems it is bug of parser than. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c11 --- Comment #11 from Michael Andres <ma@novell.com> 2007-09-27 07:24:41 MST --- (In reply to comment #8 from Jiří Suchomel)
For example SLEPOS team uses Add-On created by yast2-add-on-creator at: http://sleposlab.suse.cz/repository/ and they say it is working.
In fact by chance, not by design. As http://en.opensuse.org/Libzypp/Metadata/YaST/packages says, =Ver: is a header keyword denoting the syntax version used in that file. If not specified at the beginning it's ignored, and you get what the parser guesses. Each data entry is introduced by the NVRA (NameVersionReleaseArch), and ends at the next NVRA (or end of file). This is how susetags works, you can 'cat *pat' and parse it. Fixing the segv. is handling the situation that a tag occurs outside a data entry, but the '+Des:/-Des:' is not associated with the pattern entry. If someone as well requests to legalize the broken pattern files produced by add-on-creator, we must reduce the pattern parser to susetags-light. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c12 --- Comment #12 from Jiří Suchomel <jsuchome@novell.com> 2007-09-27 07:35:40 MST --- Please adapt the page with format description so it is clear what is mandatory for people not writing libzypp parser. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c13 --- Comment #13 from Michael Andres <ma@novell.com> 2007-09-27 09:23:21 MST --- Fixed in libzypp-3.26.3 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c14 --- Comment #14 from Michael Andres <ma@novell.com> 2007-09-27 09:24:56 MST --- Keeping it open until docs are updated. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c15 Michael Andres <ma@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #15 from Michael Andres <ma@novell.com> 2007-09-28 05:17:54 MST --- Updated http://en.opensuse.org/Standards/YaST2_Repository_Metadata/pattern -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c16 --- Comment #16 from Jiří Suchomel <jsuchome@novell.com> 2007-09-28 11:00:16 MST --- Do you think add-on-creator should be also updated in SLE10SP1 or could we rely o n the fact that it works "by chance"? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c17 --- Comment #17 from Jiří Suchomel <jsuchome@novell.com> 2007-10-02 05:00:44 MST --- Ping - Michael, see previous comment... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c18 --- Comment #18 from Michael Andres <ma@novell.com> 2007-10-02 05:05:15 MST --- Update it. IMO the less buggy files exist, the better. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c19 Ruediger Oertel <ro@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ro@novell.com Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #19 from Ruediger Oertel <ro@novell.com> 2007-10-12 08:29:22 MST --- package has been submitted for 10.3. update wanted ? if yes please create a patchinfo -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546 Ruediger Oertel <ro@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ast@novell.com Status|REOPENED |NEEDINFO Info Provider| |coolo@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c20 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |meissner@novell.com --- Comment #20 from Marcus Meissner <meissner@novell.com> 2007-10-13 02:54:48 MST --- patchinfo is there, just has the old swampid. Needs a new one. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c21 Harald Mueller-Ney <hmuelle@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hmuelle@novell.com --- Comment #21 from Harald Mueller-Ney <hmuelle@novell.com> 2007-10-15 09:59:43 MST --- SWAMPID: 14134 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c22 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |REOPENED Info Provider|coolo@novell.com | --- Comment #22 from Stephan Kulow <coolo@novell.com> 2007-10-20 03:58:45 MST --- info is provided -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546 Jiří Suchomel <jsuchome@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|328816 | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c23 Michael Andres <ma@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #23 from Michael Andres <ma@novell.com> 2007-10-31 08:38:12 MST --- done -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=328546#c24 Michael Andres <ma@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |locilka@novell.com --- Comment #24 from Michael Andres <ma@novell.com> 2007-11-06 07:56:54 MST --- *** Bug 331826 has been marked as a duplicate of this bug. *** https://bugzilla.novell.com/show_bug.cgi?id=331826 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com