[Bug 890595] New: xscreensaver (5.22) displays a nag-screen to update it
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c0 Summary: xscreensaver (5.22) displays a nag-screen to update it Classification: openSUSE Product: openSUSE 13.1 Version: Final Platform: x86-64 OS/Version: openSUSE 13.1 Status: NEW Severity: Minor Priority: P5 - None Component: X11 Applications AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: madworm_de.novell@spitzenpfeil.org QAContact: qa-bugs@suse.de Found By: --- Blocker: --- Created an attachment (id=601256) --> (http://bugzilla.novell.com/attachment.cgi?id=601256) image User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 This is annoying. Reproducible: Always Steps to Reproduce: 1. 2. 3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595
https://bugzilla.novell.com/show_bug.cgi?id=890595#c1
Jean Delvare
https://bugzilla.novell.com/show_bug.cgi?id=890595
https://bugzilla.novell.com/show_bug.cgi?id=890595#c
Jean Delvare
https://bugzilla.novell.com/show_bug.cgi?id=890595
https://bugzilla.novell.com/show_bug.cgi?id=890595#c
Stanislav Brabec
https://bugzilla.novell.com/show_bug.cgi?id=890595
https://bugzilla.novell.com/show_bug.cgi?id=890595#c2
James Carter
https://bugzilla.novell.com/show_bug.cgi?id=890595
https://bugzilla.novell.com/show_bug.cgi?id=890595#c3
--- Comment #3 from Jean Delvare
https://bugzilla.novell.com/show_bug.cgi?id=890595
https://bugzilla.novell.com/show_bug.cgi?id=890595#c4
--- Comment #4 from James Carter
https://bugzilla.novell.com/show_bug.cgi?id=890595
https://bugzilla.novell.com/show_bug.cgi?id=890595#c5
--- Comment #5 from Stanislav Brabec
https://bugzilla.novell.com/show_bug.cgi?id=890595
https://bugzilla.novell.com/show_bug.cgi?id=890595#c6
Guido Berhörster
There are three basic ways to deal with it: 1) Each distro cycle will have 1 to 2 version updates. (Not applicable for enterprise distros.)
I see no point in this, it is not our maintenance policy to arbitrarily upgrade packages to a newer upstream releases, rather we usually maintain the packages backporting bugfixes and security updates as necessary with only few exceptional cases. Bugs should also usually filed here first rather than directly upstream.
2) Patch it and modify the message to sync with the life cycle of openSUSE cycle.
Doesn't make sense to nag users about something they cannot fix anyway, it's our package and responsibility.
3) Disable the message at all.
That seems to be the only sensible choice, I've sr'd a patch. If accepted I can take care of a maintenance update as well. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595
https://bugzilla.novell.com/show_bug.cgi?id=890595#c7
Guido Berhörster
https://bugzilla.novell.com/show_bug.cgi?id=890595
https://bugzilla.novell.com/show_bug.cgi?id=890595#c8
--- Comment #8 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=890595
https://bugzilla.novell.com/show_bug.cgi?id=890595#c9
--- Comment #9 from Stanislav Brabec
https://bugzilla.novell.com/show_bug.cgi?id=890595
https://bugzilla.novell.com/show_bug.cgi?id=890595#c10
--- Comment #10 from Guido Berhörster
Created an attachment (id=604475) --> (http://bugzilla.novell.com/attachment.cgi?id=604475) [details] xscreensaver-disable-upgrade-nagging-message.patch
I just prepared a bit larger patch, that completely removes all the code around.
It is cleaner, as it does not keep unused code, but it is larger and easier to break by update. (But I don't think that this code will be changed frequently.)
What do you think about it?
Since we will never be able to upstream this patch I personally prefer potentially less patch maintenance over cleanliness. But it's just a matter of preference, so feel free to revise the patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595
https://bugzilla.novell.com/show_bug.cgi?id=890595#c11
--- Comment #11 from Stanislav Brabec
https://bugzilla.novell.com/show_bug.cgi?id=890595
https://bugzilla.novell.com/show_bug.cgi?id=890595#c13
--- Comment #13 from Jean Delvare
participants (1)
-
bugzilla_noreply@novell.com