[Bug 890595] New: xscreensaver (5.22) displays a nag-screen to update it
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c0 Summary: xscreensaver (5.22) displays a nag-screen to update it Classification: openSUSE Product: openSUSE 13.1 Version: Final Platform: x86-64 OS/Version: openSUSE 13.1 Status: NEW Severity: Minor Priority: P5 - None Component: X11 Applications AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: madworm_de.novell@spitzenpfeil.org QAContact: qa-bugs@suse.de Found By: --- Blocker: --- Created an attachment (id=601256) --> (http://bugzilla.novell.com/attachment.cgi?id=601256) image User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 This is annoying. Reproducible: Always Steps to Reproduce: 1. 2. 3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c1 Jean Delvare <jdelvare@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdelvare@suse.com --- Comment #1 from Jean Delvare <jdelvare@suse.com> 2014-08-06 15:14:39 UTC --- Same problem here. It seems all recent distributions are affected, the warning was added on purpose by the upstream author. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c Jean Delvare <jdelvare@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.linuxquestions.o | |rg/questions/slackware-14/e | |rror-message-when-starting- | |desktop-jwz-screensaver-pac | |kage-too-old-4175512984/#po | |st5213278 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c Stanislav Brabec <sbrabec@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |sbrabec@suse.com AssignedTo|bnc-team-screening@forge.pr |sbrabec@suse.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c2 James Carter <jimc@math.ucla.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jimc@math.ucla.edu --- Comment #2 from James Carter <jimc@math.ucla.edu> 2014-08-07 05:03:18 UTC --- Cross reference to: http://www.linuxquestions.org/questions/slackware-14/error-message-when-star... Their user ljb643 says, it has a 12 month trigger. 5.29 is the latest version. Jamie Zawicki (author) put a comment in the code where it does the 12 month test: "Getting very tired of bug reports of already fixed bugs due to Linux distros shipping multi year old versions." You'll get a laugh out of how the Slackware people dealt with the problem. I agree that 1 year is too short, and a 2 year life fits a lot better into the SuSE release cycle; nonetheless Jamie Zawicki has a good point and it would be a nice cooperative move to do as he asks and update to 5.29. One of the Slackware people says the upgrade is clean. The SuSE Build Service has three packages of xscreensaver-5.29, and I've just downloaded and will install the one from home:openSUSE_user1 (because it has both i586 and x86_64, and I need to support both architectures). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c3 --- Comment #3 from Jean Delvare <jdelvare@suse.com> 2014-08-07 07:51:45 UTC --- Err, no, sorry, Jamie Zawicki doesn't have a point at all. Updating to new versions on a regular basis only makes sense for rolling distributions, which openSUSE 13.1 is not. For non-rolling distributions, we (and all other distribution maintainers) backport bug fixes as needed, we do not update versions. xscreensaver is only one in thousands of packages in the openSUSE distributions, and thankfully nobody else was stupid enough to do what Jamie Zawicki did, otherwise the distribution would become unusable. Jamie has clearly no idea how distributions are maintained. The only sane thing to do here is to drop the warning, as the Slackware folks did it I understand correctly. If Jamie doesn't want to answer support questions related to old versions of xscreensaver, that's fair. But the right want to handle that is to document it properly, and not to force version updates on distribution maintainers. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c4 --- Comment #4 from James Carter <jimc@math.ucla.edu> 2014-08-09 06:09:47 UTC --- Sorry, I misspelled the author's name: it's Jamie Zawinski. I installed xscreensaver-5.29-2.2 from Tumbleweed. There were no dependent packages that needed replacement. The program works normally for me. No nag screen until Summer 2015 :-( People annoyed by the nag screen could deal with it in this way. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c5 --- Comment #5 from Stanislav Brabec <sbrabec@suse.com> 2014-08-11 17:36:17 CEST --- There are three basic ways to deal with it: 1) Each distro cycle will have 1 to 2 version updates. (Not applicable for enterprise distros.) 2) Patch it and modify the message to sync with the life cycle of openSUSE cycle. 3) Disable the message at all. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c6 Guido Berhörster <gber@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gber@opensuse.org --- Comment #6 from Guido Berhörster <gber@opensuse.org> 2014-08-15 18:27:02 UTC --- (In reply to comment #5)
There are three basic ways to deal with it: 1) Each distro cycle will have 1 to 2 version updates. (Not applicable for enterprise distros.)
I see no point in this, it is not our maintenance policy to arbitrarily upgrade packages to a newer upstream releases, rather we usually maintain the packages backporting bugfixes and security updates as necessary with only few exceptional cases. Bugs should also usually filed here first rather than directly upstream.
2) Patch it and modify the message to sync with the life cycle of openSUSE cycle.
Doesn't make sense to nag users about something they cannot fix anyway, it's our package and responsibility.
3) Disable the message at all.
That seems to be the only sensible choice, I've sr'd a patch. If accepted I can take care of a maintenance update as well. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c7 Guido Berhörster <gber@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #7 from Guido Berhörster <gber@opensuse.org> 2014-08-27 10:43:58 UTC --- A fix for Factory and a maintenance update for 13.1 are underway, so closing this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c8 --- Comment #8 from Bernhard Wiedemann <bwiedemann@suse.com> 2014-08-27 13:00:18 CEST --- This is an autogenerated message for OBS integration: This bug (890595) was mentioned in https://build.opensuse.org/request/show/246613 13.1 / xscreensaver -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c9 --- Comment #9 from Stanislav Brabec <sbrabec@suse.com> 2014-09-01 17:02:53 CEST --- Created an attachment (id=604475) --> (http://bugzilla.novell.com/attachment.cgi?id=604475) xscreensaver-disable-upgrade-nagging-message.patch I just prepared a bit larger patch, that completely removes all the code around. It is cleaner, as it does not keep unused code, but it is larger and easier to break by update. (But I don't think that this code will be changed frequently.) What do you think about it? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c10 --- Comment #10 from Guido Berhörster <gber@opensuse.org> 2014-09-01 17:12:34 UTC --- (In reply to comment #9)
Created an attachment (id=604475) --> (http://bugzilla.novell.com/attachment.cgi?id=604475) [details] xscreensaver-disable-upgrade-nagging-message.patch
I just prepared a bit larger patch, that completely removes all the code around.
It is cleaner, as it does not keep unused code, but it is larger and easier to break by update. (But I don't think that this code will be changed frequently.)
What do you think about it?
Since we will never be able to upstream this patch I personally prefer potentially less patch maintenance over cleanliness. But it's just a matter of preference, so feel free to revise the patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c11 --- Comment #11 from Stanislav Brabec <sbrabec@suse.com> 2014-09-02 17:03:41 CEST --- OK. I'll keep your patch as a backup. Also adding a patch with string changes in man page and bug report info. Before reporting any bugs to the upstream, please check it in the latest version. If it is fixed there, please report it to https://bugzilla.novell.com/. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=890595 https://bugzilla.novell.com/show_bug.cgi?id=890595#c13 --- Comment #13 from Jean Delvare <jdelvare@suse.com> 2014-09-03 07:39:06 UTC --- Thanks Guido for taking care of this, this is appreciated. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com