[Bug 714649] New: puppet: use of /var/lock/subsys unsupported
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c0 Summary: puppet: use of /var/lock/subsys unsupported Classification: openSUSE Product: openSUSE 12.1 Version: Factory Platform: All OS/Version: Linux Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: wolfgang.engel@suse.com ReportedBy: lnussel@suse.com QAContact: qa@suse.de Found By: --- Blocker: --- puppet uses /var/lock/subsys which is unsupported on openSUSE. On openSUSE /var/lock is reserved for device lock files and must not be used for other purposes. Due to the use of tmpfs on /var/lock the subsys directory does not exist anymore either so if your package used /var/lock/subsys for any real purpose it might be silently broken already. Please fix your packge to not use /var/lock/subsys. http://en.opensuse.org/openSUSE:Packaging_checks#subsys-unsupported -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c1 Bob Vickers <R.Vickers@cs.rhul.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |R.Vickers@cs.rhul.ac.uk Component|Other |Other Version|Factory |Final AssignedTo|wolfgang.engel@suse.com |bnc-team-screening@forge.pr | |ovo.novell.com Product|openSUSE 12.1 |openSUSE 12.2 --- Comment #1 from Bob Vickers <R.Vickers@cs.rhul.ac.uk> 2012-10-29 16:36:13 UTC --- This problem appears on opensuse 12.2 as well, so I have changed the status. I have done some grepping through the source tree, and the only place where /var/lock appears is in the two files /etc/init.d/puppet and /etc/init.d/puppetmasterd so I believe the fix is simply to set lockfile=/var/run/puppet/puppetmasterd.lock and lockfile=/var/run/puppet/puppet.lock in these two places. This fix at least enables Puppet to start, whereas without it Puppet is dead in the water. Can this fix be included in a patch? I don't see how it can possibly break anything. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c Jiaying ren <jren@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jren@novell.com AssignedTo|bnc-team-screening@forge.pr |vdziewiecki@suse.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c Wojtek Dziewięcki <vdziewiecki@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c2 Lars Heide <itsbo@fz-juelich.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |itsbo@fz-juelich.de --- Comment #2 from Lars Heide <itsbo@fz-juelich.de> 2013-01-17 11:14:38 UTC --- Replacing /var/lock/subsys with /var/run/puppet will not help, as /var/run is also a tmpfs that gets cleared with every reboot and therefore you would also try to write into a subdirectory that does not exist. To be more precise the bug currently does not prevent puppet to start as a client on client systems -but- as it throws an error due to the missing directory, it does not get registered as started and you have a puppet process running in the background that you can not stop with the initscript. see: host# /etc/init.d/puppet start redirecting to systemctl Job failed. See system journal and 'systemctl status' for details. host# ps -ef |grep pupp root 7456 1 57 12:01 ? 00:00:00 /usr/bin/ruby1.9 /usr/sbin/puppetd --logdest=/var/log/puppet/puppe Analysing the initscript and checkproc, I can see no reason for having a lockfile in the first place. a) according to the manpage, "checkproc" does not check for lock files. b) the initscript simply creates and deletes the lockfile but does not check for it (see a) ) c) puppets own lockfile gets created in "/var/lib/puppet/state/" independent of the initscript so removing the references to the lockfile should be cleaner and easier. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c3 --- Comment #3 from Ludwig Nussel <lnussel@suse.com> 2013-01-17 14:39:58 CET --- references to /var/lock/subsys are usually artifacts from Fedora. We never used that on openSUSE. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c4 --- Comment #4 from Wojtek Dziewięcki <vdziewiecki@suse.com> 2013-01-17 13:56:07 UTC --- Well then, if it is never used anyway and it doesn't do any harm then I will just leave it as is and remove the unnecessary stuff with the next puppet update. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c5 --- Comment #5 from Lars Heide <itsbo@fz-juelich.de> 2013-01-17 14:54:02 UTC --- Does that mean there will be a patched version for 12.2 or might this take till 12.3? I would respectfully ask that you consider patching "/var/lock/subsys" to "/var/lock" in the short run at least if you intend to wait till 12.3. for mayor changes. The problem with stopping the client only via "kill" is annoying. If there is going to be an update for 12.2, forget what I said. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c6 --- Comment #6 from Ludwig Nussel <lnussel@suse.com> 2013-01-18 09:31:08 CET --- using /var/lock is just as wrong as /var/lock/subsys. Don't use those directories. Just remove the feature entirely. There is no need for an online update in 12.2 but please fix it for Factory now if not done already so 12.3 is clean. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c7 --- Comment #7 from Wojtek Dziewięcki <vdziewiecki@suse.com> 2013-01-18 14:45:22 UTC --- I altered the init scripts so they don't create or use pid and lock file and submitted to factory as sr#148970. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c8 --- Comment #8 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-01-18 16:00:09 CET --- This is an autogenerated message for OBS integration: This bug (714649) was mentioned in https://build.opensuse.org/request/show/148970 Factory / puppet -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c9 --- Comment #9 from Lars Heide <itsbo@fz-juelich.de> 2013-01-21 13:46:30 UTC ---
There is no need for an online update in 12.2
There isn't? Sorry for asking, I just don't know what policies are in place here. Is there a way to get this fixed in 12.2? Or does this just mean there will be a different kind of update? Puppet in 12.2 is still 2.7.6. btw. So using the current version (3.0.2) might not be an option for everybody. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c10 Ansgar Esztermann <aeszter@gwdg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aeszter@gwdg.de --- Comment #10 from Ansgar Esztermann <aeszter@gwdg.de> 2013-01-23 13:52:59 UTC --- Opened upstream bug: http://projects.puppetlabs.com/issues/18801 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c11 --- Comment #11 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-01-23 16:00:08 CET --- This is an autogenerated message for OBS integration: This bug (714649) was mentioned in https://build.opensuse.org/request/show/149707 Factory / puppet -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c12 --- Comment #12 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-01-23 17:00:08 CET --- This is an autogenerated message for OBS integration: This bug (714649) was mentioned in https://build.opensuse.org/request/show/149711 Factory / puppet -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c13 Matthaus Owens <matthaus@puppetlabs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthaus@puppetlabs.com --- Comment #13 from Matthaus Owens <matthaus@puppetlabs.com> 2013-04-17 00:02:27 UTC --- This patch will have unintended consequences. By removing the pidfile arguments to killproc, startproc, and checkproc those functions now won't be able to differentiate between a master and an agent daemon. The puppetd and puppetmasterd binaries have been deprecated for some time and were fully removed in the 3.0 release, so an agent will be `/usr/bin/puppet agent` and a master will be `/usr/bin/puppet master`. However $puppetd is set to /usr/bin/puppet, as is $puppetmaster, so when the killproc is called, there will be no way to know which process is being killed. If directory creation with tmpfs is the root problem here, would adding a `mkdir -p /var/run/puppet` if the directory doesn't exist be a sufficient fix to the issue? Then both pidfiles and lockfiles could live inside that directory. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c14 Wojtek Dziewięcki <vdziewiecki@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |FIXED --- Comment #14 from Wojtek Dziewięcki <vdziewiecki@suse.com> 2013-04-29 13:09:41 UTC --- Fixed, closing. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c15 --- Comment #15 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-08-29 15:41:50 CEST --- This is an autogenerated message for OBS integration: This bug (714649) was mentioned in https://build.opensuse.org/request/show/196790 12.2,12.3 / puppet -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c16 --- Comment #16 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-08-30 15:00:18 CEST --- This is an autogenerated message for OBS integration: This bug (714649) was mentioned in https://build.opensuse.org/request/show/196882 12.2 / puppet -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c17 --- Comment #17 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-09-03 11:00:19 CEST --- This is an autogenerated message for OBS integration: This bug (714649) was mentioned in https://build.opensuse.org/request/show/197235 12.2 / puppet -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714649 https://bugzilla.novell.com/show_bug.cgi?id=714649#c18 --- Comment #18 from Swamp Workflow Management <swamp@suse.de> 2013-09-09 12:04:23 UTC --- openSUSE-RU-2013:1413-1: An update that has one recommended fix can now be installed. Category: recommended (low) Bug References: 714649 CVE References: Sources used: openSUSE 12.2 (src): puppet-2.7.6-4.8.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com