[Bug 584540] New: yast2-printer: autodetect_print_queues not backward compatible
http://bugzilla.novell.com/show_bug.cgi?id=584540 http://bugzilla.novell.com/show_bug.cgi?id=584540#c0 Summary: yast2-printer: autodetect_print_queues not backward compatible Classification: openSUSE Product: openSUSE 11.3 Version: Factory Platform: All OS/Version: openSUSE 11.3 Status: ASSIGNED Severity: Normal Priority: P5 - None Component: YaST2 AssignedTo: jsmeix@novell.com ReportedBy: jsmeix@novell.com QAContact: jsrain@novell.com CC: mzugec@novell.com Found By: Development Blocker: --- Because of bug #520599 autodetect_print_queues contains now ------------------------------------------------------------------------------ # Since CUPS 1.4 'lpstat -r' results true even when scheduler is not running. # Therefore we must now grep in its output: if $LPSTAT -h $SERVERNAME -r | grep -q 'scheduler is not running' then echo "Cannot access cupsd on '$SERVERNAME'" 1>&2 exit 2 fi ------------------------------------------------------------------------------ But when there is no cupsd running at all (at least with CUPS 1.3) it does no longer detect this error and blindly continues: ------------------------------------------------------------------------------ nelson:/packages/yast/source/printer # rccups stop Shutting down cupsd done nelson:/packages/yast/source/printer # tools/autodetect_print_queues /usr/bin/lpstat: Unable to connect to server /usr/bin/lpstat: Unable to connect to server /usr/bin/lpstat: Unable to connect to server /usr/bin/lpstat: Unable to connect to server [ $[] ] nelson:/packages/yast/source/printer # echo $? 0 ------------------------------------------------------------------------------ For backward compatibility it must also grep for "Unable to connect to server" and to be on the safe side also detect when lpstat exits with non-zero exit code. In all those cases autodetect_print_queues must accordingly exit with non-zero exit code. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=584540 http://bugzilla.novell.com/show_bug.cgi?id=584540#c1 Johannes Meixner <jsmeix@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P4 - Low Severity|Normal |Minor --- Comment #1 from Johannes Meixner <jsmeix@novell.com> 2010-03-02 09:13:43 UTC --- Minor severity because the empty fallback map is o.k. and therefore also low priority. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=584540 http://bugzilla.novell.com/show_bug.cgi?id=584540#c2 --- Comment #2 from Johannes Meixner <jsmeix@novell.com> 2010-03-02 09:17:24 UTC --- Prpbably also to be fixed in src/Printerlib.ycp compare https://bugzilla.novell.com/show_bug.cgi?id=520599#c1 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=584540 http://bugzilla.novell.com/show_bug.cgi?id=584540#c3 Johannes Meixner <jsmeix@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #3 from Johannes Meixner <jsmeix@novell.com> 2010-03-02 10:44:20 UTC --- Actually in src/Printerlib.ycp it was already implemented the right way via test for the positive output "scheduler is running" so that now the same is done in tools/autodetect_print_queues ----------------------------------------------------------------------------- # Since CUPS 1.4 'lpstat -r' results true even when scheduler is not running. # Therefore we must now grep in its output: if ! $LPSTAT -h $SERVERNAME -r | grep -q 'scheduler is running' then echo "Cannot access cupsd on '$SERVERNAME'" 1>&2 exit 2 fi ----------------------------------------------------------------------------- Fixed in YaST SVN Head revision 61091. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com