[Bug 660795] New: mISDN module reference counting is wrong
https://bugzilla.novell.com/show_bug.cgi?id=660795 https://bugzilla.novell.com/show_bug.cgi?id=660795#c0 Summary: mISDN module reference counting is wrong Classification: openSUSE Product: openSUSE 11.3 Version: Final Platform: x86-64 OS/Version: openSUSE 11.3 Status: NEW Severity: Normal Priority: P5 - None Component: Kernel AssignedTo: kernel-maintainers@forge.provo.novell.com ReportedBy: Ralf.Friedl@online.de QAContact: qa@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (Windows; U; Win98; de-AT; rv:1.8.1.24) Gecko/20100228 SeaMonkey/1.1.19 After making a call with the mISDNuser program testcon, the module usage counts are wrong. Hardware driver in this case is hfcsusb, but avmfritz had the same effect. After booting, as expected: hfcsusb 33758 0 mISDN_core 102537 1 hfcsusb During call: hfcsusb 33758 2 mISDN_core 102537 4 hfcsusb After call: hfcsusb 33758 4294967295 mISDN_core 102537 2 hfcsusb During next call: hfcsusb 33758 1 mISDN_core 102537 4 hfcsusb After call: hfcsusb 33758 4294967294 mISDN_core 102537 2 hfcsusb and so on. The hfcsusb reference count decreases with each call. The mISDN_core reference count doesn't return to 1. It's impossible to unload the modules. Kernel: Linux linux-fhz4 2.6.34.7-0.5-desktop #1 SMP PREEMPT 2010-10-25 08:40:12 +0200 x86_64 x86_64 x86_64 GNU/Linux Reproducible: Always Steps to Reproduce: 1. Load mISDN_core, hfcsusb 2. call testcon 3. see lsmod for recerence counts: lsmod | grep hfcsusb Actual Results: hfcsusb 33758 4294967295 mISDN_core 102537 2 hfcsusb Expected Results: hfcsusb 33758 0 mISDN_core 102537 1 hfcsusb -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=660795 https://bugzilla.novell.com/show_bug.cgi?id=660795#c1 Ralf Friedl <Ralf.Friedl@online.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Ralf.Friedl@online.de --- Comment #1 from Ralf Friedl <Ralf.Friedl@online.de> 2010-12-22 16:02:09 UTC --- This trace shows 2 module_get and 3 module_put calls. # echo module > /sys/kernel/debug/tracing/set_event # testcon # grep hfcsusb /sys/kernel/debug/tracing/trace misdntestlayer3-6199 [000] 13187.241478: module_get: hfcsusb call_site=hfc_dctrl refcnt=2 misdntestlayer3-6199 [000] 13187.241489: module_get: hfcsusb call_site=hfc_dctrl refcnt=3 misdntestlayer3-6199 [000] 13188.290824: module_put: hfcsusb call_site=hfc_dctrl refcnt=4 misdntestlayer3-6199 [000] 13188.290850: module_put: hfcsusb call_site=hfc_dctrl refcnt=5 misdntestlayer3-6199 [000] 13188.290853: module_put: hfcsusb call_site=hfc_dctrl refcnt=6 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=660795 https://bugzilla.novell.com/show_bug.cgi?id=660795#c2 Jeff Mahoney <jeffm@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO CC| |jeffm@novell.com InfoProvider| |Ralf.Friedl@online.de --- Comment #2 from Jeff Mahoney <jeffm@novell.com> 2011-02-10 01:06:28 UTC --- Do you see any warnings in the log that contain "cannot get module" ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=660795 https://bugzilla.novell.com/show_bug.cgi?id=660795#c3 Ralf Friedl <Ralf.Friedl@online.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|Ralf.Friedl@online.de | --- Comment #3 from Ralf Friedl <Ralf.Friedl@online.de> 2011-02-10 11:14:10 UTC --- I don't have any such warnings in the log from on or before 2010-12-21 when I reported this. But I have such messages from 2010-12-22. This is most likely from when I used /sys/kernel/debug/tracing and wrote the first comment. Here the messages in context: kernel: [13069.837979] Modular ISDN core version 1.1.21 kernel: [13069.838189] NET: Registered protocol family 34 kernel: [13069.867315] HFC-S_USB driver Rev. Revision: 0.3.3 (socket), 2008-11-05 debug(0x0) poll(128) kernel: [13069.867368] hfcsusb_probe: interface(0) actalt(0) minor(-1) vend_idx(1) kernel: [13069.867387] HFC-S_USB: probe of 1-5.2:1.0 failed with error -5 kernel: [13069.867421] hfcsusb_probe: interface(1) actalt(0) minor(-1) vend_idx(1) kernel: [13069.867447] HFC-S_USB: hfcsusb_probe: detected "DrayTek miniVigor 128 USB ISDN TA" (4 Isochron IN + 3 Isochron OUT, if=1 alt=1) kernel: [13069.868640] HFC-S_USB: registered as 'HFC-S_USB.1' kernel: [13069.868987] usbcore: registered new interface driver HFC-S_USB kernel: [13188.444473] base_sock_release(ffff880139a18a80) sk=ffff880137ceb800 kernel: [13203.775230] base_sock_release(ffff88013f8b45c0) sk=ffff880138dd5000 kernel: [13203.775521] base_sock_release(ffff88013f8b45c0) sk=ffff880138dd5000 kernel: [13203.777685] create_l2entity: ret 1 0 kernel: [13203.777694] create_l2entity: ret 2 0 kernel: [14241.943000] base_sock_release(ffff88013f8b7340) sk=ffff880137e63c00 kernel: [14241.943179] base_sock_release(ffff88013f8b7340) sk=ffff880137e63c00 kernel: [14241.945376] HFC-S_USB.1: open_dchannel: cannot get module kernel: [14241.945383] create_l2entity: ret 1 0 kernel: [14241.945388] HFC-S_USB.1: open_dchannel: cannot get module kernel: [14241.945396] create_l2entity: ret 2 0 kernel: [14353.171808] base_sock_release(ffff88013f817840) sk=ffff880137ccd800 kernel: [14353.171984] base_sock_release(ffff88013f817840) sk=ffff880137ccd800 kernel: [14353.174335] HFC-S_USB.1: open_dchannel: cannot get module kernel: [14353.174343] create_l2entity: ret 1 0 kernel: [14353.174349] HFC-S_USB.1: open_dchannel: cannot get module kernel: [14353.174358] create_l2entity: ret 2 0 kernel: [14354.622794] base_sock_release(ffff880098968d40) sk=ffff880137cc0400 kernel: [14354.622962] base_sock_release(ffff880098968d40) sk=ffff880137cc0400 kernel: [14354.623000] HFC-S_USB.1: open_dchannel: cannot get module kernel: [14354.623007] create_l2entity: ret 1 0 kernel: [14354.623013] HFC-S_USB.1: open_dchannel: cannot get module kernel: [14354.623021] create_l2entity: ret 2 0 kernel: [14359.207614] base_sock_release(ffff88013f8b7840) sk=ffff880137e63c00 kernel: [14359.209237] base_sock_release(ffff88013f8b7840) sk=ffff880137e63c00 kernel: [14359.209502] HFC-S_USB.1: open_dchannel: cannot get module kernel: [14359.209508] create_l2entity: ret 1 0 kernel: [14359.209514] HFC-S_USB.1: open_dchannel: cannot get module kernel: [14359.209520] create_l2entity: ret 2 0 kernel: [14390.151399] base_sock_release(ffff88013f81f5c0) sk=ffff8801378e7400 kernel: [14390.219322] base_sock_release(ffff88013f81f5c0) sk=ffff8801378e7400 kernel: [14390.219384] HFC-S_USB.1: open_dchannel: cannot get module kernel: [14390.219389] create_l2entity: ret 1 0 kernel: [14390.219395] HFC-S_USB.1: open_dchannel: cannot get module kernel: [14390.219403] create_l2entity: ret 2 0 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=660795 https://bugzilla.novell.com/show_bug.cgi?id=660795#c4 Jeff Mahoney <jeffm@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kernel-maintainers@forge.pr |jeffm@novell.com |ovo.novell.com | --- Comment #4 from Jeff Mahoney <jeffm@novell.com> 2011-04-25 19:40:23 UTC --- Ok. Something is definitely hosed there and hasn't been addressed upstream. Guess I'll take a stab at it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=660795 https://bugzilla.novell.com/show_bug.cgi?id=660795#c5 Jeff Mahoney <jeffm@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |Ralf.Friedl@online.de --- Comment #5 from Jeff Mahoney <jeffm@novell.com> 2011-04-25 21:05:21 UTC --- I've checked in a test package against openSUSE 11.4. Please test a kernel from the following URL once it appears. http://download.opensuse.org/repositories/home:/jeff_mahoney:/test-packages:... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=660795 https://bugzilla.novell.com/show_bug.cgi?id=660795#c6 Jeff Mahoney <jeffm@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED InfoProvider|Ralf.Friedl@online.de | Resolution| |NORESPONSE AssignedTo|jeffm@suse.com |bnc-team-screening@forge.pr | |ovo.novell.com --- Comment #6 from Jeff Mahoney <jeffm@suse.com> 2011-11-05 17:31:37 UTC --- Closing as NORESPONSE. If you re-open it will need to be rescreened. I don't have ISDN hardware and never will. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com