[Bug 489198] New: build-compare: ignore POT-Creation-Date from mo files
https://bugzilla.novell.com/show_bug.cgi?id=489198 Summary: build-compare: ignore POT-Creation-Date from mo files Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: coolo@novell.com ReportedBy: vuntz@novell.com QAContact: qa@suse.de Found By: --- Created an attachment (id=282297) --> (https://bugzilla.novell.com/attachment.cgi?id=282297) Patch for build-compare Many packages in GNOME:Factory are always different because of POT-Creation-Date that gets updated in some mo file. If this is the only difference, it can be safely ignored. This is mainly happening because of bug 489139, but it could happen for other reasons. Attaching a patch for build-compare. .. comparing built packages with the former built /usr/lib/build/rpm-check.sh compare /.build.oldpackages/atk-1.26.0-13.3.src.rpm /usr/src/packages/SRPMS/atk-1.26.0-13.4.src.rpm compare /.build.oldpackages/atk-1.26.0-13.3.i586.rpm /usr/src/packages/RPMS/i586/atk-1.26.0-13.4.i586.rpm compare /.build.oldpackages/atk-debuginfo-1.26.0-13.3.i586.rpm /usr/src/packages/RPMS/i586/atk-debuginfo-1.26.0-13.4.i586.rpm compare /.build.oldpackages/atk-debugsource-1.26.0-13.3.i586.rpm /usr/src/packages/RPMS/i586/atk-debugsource-1.26.0-13.4.i586.rpm compare /.build.oldpackages/atk-devel-1.26.0-13.3.i586.rpm /usr/src/packages/RPMS/i586/atk-devel-1.26.0-13.4.i586.rpm compare /.build.oldpackages/atk-doc-1.26.0-13.3.i586.rpm /usr/src/packages/RPMS/i586/atk-doc-1.26.0-13.4.i586.rpm compare /.build.oldpackages/atk-lang-1.26.0-13.3.i586.rpm /usr/src/packages/RPMS/i586/atk-lang-1.26.0-13.4.i586.rpm /usr/share/locale/or/LC_MESSAGES/atk10.mo differs ( GNU message catalog (little endian), revision 0, 127 messages) --- /tmp/tmp.mYt3edvhn5 2009-03-26 12:10:53.000000000 +0000 +++ /tmp/tmp.AEOBk0hJO4 2009-03-26 12:10:53.000000000 +0000 @@ -326,7 +326,7 @@ 00001450 6f 72 74 2d 4d 73 67 69 64 2d 42 75 67 73 2d 54 |ort-Msgid-Bugs-T| 00001460 6f 3a 20 0a 50 4f 54 2d 43 72 65 61 74 69 6f 6e |o: .POT-Creation| 00001470 2d 44 61 74 65 3a 20 32 30 30 39 2d 30 33 2d 32 |-Date: 2009-03-2| -00001480 31 20 31 30 3a 31 32 2b 30 30 30 30 0a 50 4f 2d |1 10:12+0000.PO-| +00001480 36 20 31 32 3a 30 39 2b 30 30 30 30 0a 50 4f 2d |6 12:09+0000.PO-| 00001490 52 65 76 69 73 69 6f 6e 2d 44 61 74 65 3a 20 32 |Revision-Date: 2| 000014a0 30 30 39 2d 30 31 2d 32 38 20 31 35 3a 31 39 2b |009-01-28 15:19+| 000014b0 30 35 33 30 0a 4c 61 73 74 2d 54 72 61 6e 73 6c |0530.Last-Transl| .. build is finished -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=489198 User vuntz@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=489198#c1 Vincent Untz <vuntz@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |pth@novell.com --- Comment #1 from Vincent Untz <vuntz@novell.com> 2009-03-26 09:05:02 MST --- Philipp: darix is suggesting that, if possible, we should just remove the dates from the .mo files. According to http://www.gnu.org/software/hello/manual/gettext/MO-Files.html, the dates are not useful. Do you think we could patch gettext to remove them? Can this break something? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=489198 User pth@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=489198#c2 Philipp Thomas <pth@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pth@novell.com Info Provider|pth@novell.com |bruno@clisp.org --- Comment #2 from Philipp Thomas <pth@novell.com> 2009-03-26 10:15:55 MST --- Bruno, gettext is your child, so do you know of anything depending on POT-Creation-Date? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=489198 User coolo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=489198#c3 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |coolo@novell.com --- Comment #3 from Stephan Kulow <coolo@novell.com> 2009-03-26 11:22:46 MST --- well, you make it impossible to figure what pot file was translated from an installed system. This is of course pretty uninteresting in builds that regenerate the pot file every build. So I'd think (but just MHO) that patching it out in msgfmt would be wrong. I should rather be a xgettext option, that our atk package would use. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=489198 User vuntz@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=489198#c4 --- Comment #4 from Vincent Untz <vuntz@novell.com> 2009-03-26 11:43:03 MST --- (In reply to comment #3)
well, you make it impossible to figure what pot file was translated from an installed system. This is of course pretty uninteresting in builds that regenerate the pot file every build. So I'd think (but just MHO) that patching it out in msgfmt would be wrong. I should rather be a xgettext option, that our atk package would use.
Upstream atk is doing nothing wrong -- the bug would be in translation-update-upstream (see bug 489139), and it affects all packages using translation-update. If you don't think build-compare should ignore this (either directly in build-compare via my patch, or by changing gettext as proposed later on), then we can just close the bug. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=489198 User bruno@clisp.org added comment https://bugzilla.novell.com/show_bug.cgi?id=489198#c5 Bruno Haible <bruno@clisp.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bruno@clisp.org --- Comment #5 from Bruno Haible <bruno@clisp.org> 2009-03-26 17:57:41 MST ---
Many packages in GNOME:Factory are always different because of POT-Creation-Date that gets updated in some mo file.
If "msgmerge --update" was used to update the PO file, followed by "msgfmt" to update the MO file, this would not happen. "msgmerge --update" does not change the PO file if the only difference would be in the POT-Creation-Date. However, if line numbers in the source files have changed, "msgmerge --update" will change the PO file, and it is possible that in this case two MO files differ only by the POT-Creation-Date. The PO files had different line numbers in the source references, but that difference is erased in the MO files. I bet you are in the first case and are not using "msgmerge --update", right? Bruno -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=489198 User coolo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=489198#c6 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|bruno@clisp.org | --- Comment #6 from Stephan Kulow <coolo@novell.com> 2009-03-27 03:51:46 MST --- I have no problem with the patch per se. I just want to avoid having too many hacks in there that can be avoided, so I want to challenge gettext. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com