[Bug 751558] New: mkinitrd: should export $RD_TIMESTAMP
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c0 Summary: mkinitrd: should export $RD_TIMESTAMP Classification: openSUSE Product: openSUSE 12.2 Version: Factory Platform: All OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: mmarek@suse.com ReportedBy: crrodriguez@opensuse.org QAContact: qa@suse.de Found By: --- Blocker: --- Per http://www.freedesktop.org/wiki/Software/systemd/InitrdInterface "In the $RD_TIMESTAMP environment variable the initrd shall pass the monotonic and realtime timestamp when execution of the initrd began. This is then used by systemd to estimate the time that is spent in the kernel initialization, the initrd initialization and the main system initialization at boot. The monotonic and realtime timestamps shall be formatted as ASCII values of usecs, separated by a space character. The /lib/systemd/systemd-timestamp tool will generate a properly formatted timestamp for you, consider adding it to your initrd." -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c1 Olaf Hering <ohering@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO CC| |ohering@suse.com InfoProvider| |crrodriguez@opensuse.org --- Comment #1 from Olaf Hering <ohering@suse.com> 2013-07-11 20:47:01 CEST --- what should the variable contain, how is its content constructed? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c2 Cristian Rodríguez <crrodriguez@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|crrodriguez@opensuse.org | --- Comment #2 from Cristian Rodríguez <crrodriguez@opensuse.org> 2013-07-11 15:09:18 CLT --- (In reply to comment #1)
what should the variable contain, how is its content constructed?
Simply by export RD_TIMESTAMP=$(/usr/lib/systemd/systemd-timestamp) at the beggining of boot process (and of course, including /usr/lib/systemd/systemd-timestamp in the initrd) However we should just switch to dracut by now. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c3 --- Comment #3 from Olaf Hering <ohering@suse.com> 2013-07-12 15:11:04 CEST --- If systemd really is the only consumer, wouldnt be the right fix to package setup-systemd.sh and boot-systemd.sh which include and run the above binary? I think thats a better place than core mkinitrd. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c4 Olaf Hering <ohering@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |crrodriguez@opensuse.org --- Comment #4 from Olaf Hering <ohering@suse.com> 2013-07-15 17:45:53 CEST --- See sr #183132, its actuallly just a single boot-systemd.sh that would be needed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c5 --- Comment #5 from Robert Milasan <rmilasan@suse.com> 2013-07-16 13:24:05 UTC --- Olaf, in your SR, what does this mean: %{_datadir}/polkit-1/actions/org.freedesktop.login1.policy %{_datadir}/systemd +/lib/mkinitrd + %if ! 0%{?bootstrap} # Packaged in sysvinit subpackage What the /lib/mkinitrd suppose to do? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c6 --- Comment #6 from Robert Milasan <rmilasan@suse.com> 2013-07-16 13:25:49 UTC --- Maybe you wanted this: if [ "${YAST_IS_RUNNING}" != "instsys" ]; then if [ -e /var/lib/no_initrd_recreation_by_suspend ]; then echo "Skipping recreation of existing initial ramdisks, due" echo "to presence of /var/lib/no_initrd_recreation_by_suspend" elif [ -x /sbin/mkinitrd ]; then [ -x /sbin/mkinitrd_setup ] && /sbin/mkinitrd_setup /sbin/mkinitrd || : fi fi but not sure. Anyway, if you want mkinitrd to generate a new initrd, then you need to use the above way, as this shouldn't be ran while installing the system. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c7 --- Comment #7 from Olaf Hering <ohering@suse.com> 2013-07-16 15:28:37 CEST --- (In reply to comment #5)
Olaf, in your SR, what does this mean:
%{_datadir}/polkit-1/actions/org.freedesktop.login1.policy %{_datadir}/systemd
+/lib/mkinitrd + %if ! 0%{?bootstrap} # Packaged in sysvinit subpackage
What the /lib/mkinitrd suppose to do?
It packages the /lib/mkinitrd directory? Nothing more. I suppose systemd is installed before udev, which in turn creates an initrd if needed. But anyway, such things can be tuned further once the new functionality was tested for its purpose. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c8 --- Comment #8 from Robert Milasan <rmilasan@suse.com> 2013-07-16 13:30:05 UTC --- (In reply to comment #7)
It packages the /lib/mkinitrd directory? Nothing more.
I don’t understand! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c9 --- Comment #9 from Frederic Crozat <fcrozat@suse.com> 2013-07-16 13:35:20 UTC --- (In reply to comment #8)
(In reply to comment #7)
It packages the /lib/mkinitrd directory? Nothing more.
I don’t understand!
directories shouldn't be owned by multiple packages (it is considered bad policy). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c10 --- Comment #10 from Olaf Hering <ohering@suse.com> 2013-07-16 15:39:08 CEST --- (In reply to comment #9)
(In reply to comment #8)
(In reply to comment #7)
It packages the /lib/mkinitrd directory? Nothing more.
I don’t understand!
directories shouldn't be owned by multiple packages (it is considered bad policy).
Thats news to me, and indeed a bad policy if its enforced. If $pkgA owning $dir and having content in $dir is removed, but $pkgB has also files in $dir but doesnt own $dir then $dir is not removed by rpm. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c11 --- Comment #11 from Robert Milasan <rmilasan@suse.com> 2013-07-16 13:42:13 UTC --- OK, could you guys check https://build.opensuse.org/request/show/183423 ? Hope its better now! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c12 --- Comment #12 from Olaf Hering <ohering@suse.com> 2013-07-16 15:43:00 CEST --- (In reply to comment #10)
If $pkgA owning $dir and having content in $dir is removed, but $pkgB has also files in $dir but doesnt own $dir then $dir is not removed by rpm.
.. if $pkgB is also removed I wanted to say. But its not just about removing, also by moving stuff around during pkg update. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c13 --- Comment #13 from Frederic Crozat <fcrozat@suse.com> 2013-07-16 13:59:14 UTC --- (In reply to comment #11)
OK, could you guys check https://build.opensuse.org/request/show/183423 ?
Hope its better now!
looks ok for me, except we will now end-up regenerating initrd twice when updating systemd package, because it is also generated in udev %post :( -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c14 --- Comment #14 from Robert Milasan <rmilasan@suse.com> 2013-07-16 14:03:34 UTC --- Not really, this is only the setup in systemd package, not the regeneration of the initrd. Or we can drop from systemd pkg the setup and leave it only in udev, as anyway usually when there is an update, we update both systemd and udev. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c15 --- Comment #15 from Frederic Crozat <fcrozat@suse.com> 2013-07-16 14:12:24 UTC --- (In reply to comment #14)
Not really, this is only the setup in systemd package, not the regeneration of the initrd.
Or we can drop from systemd pkg the setup and leave it only in udev, as anyway usually when there is an update, we update both systemd and udev.
Ok -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c16 --- Comment #16 from Olaf Hering <ohering@suse.com> 2013-07-16 17:11:03 CEST --- (In reply to comment #11)
OK, could you guys check https://build.opensuse.org/request/show/183423 ?
Hope its better now!
Except for the missing mkinitrd directories, yes. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c17 --- Comment #17 from Robert Milasan <rmilasan@suse.com> 2013-07-16 17:09:55 UTC --- (In reply to comment #16)
Except for the missing mkinitrd directories, yes.
What do you? In the spec file '%dir ...' missing? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c18 --- Comment #18 from Frederic Crozat <fcrozat@suse.com> 2013-07-17 07:45:59 UTC --- (In reply to comment #17)
(In reply to comment #16)
Except for the missing mkinitrd directories, yes.
What do you? In the spec file '%dir ...' missing?
I don't want to see mkinitrd directories owned by systemd package. They should be owned by mkinitrd package only. There is no point in owning those directories in systemd. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c19 --- Comment #19 from Robert Milasan <rmilasan@suse.com> 2013-07-17 07:50:30 UTC --- Well thats why I did the spec file in that way. That is what I understood. Anyway, should be add to boot-systemd.sh a dependency, like: #%depends: start Not sure if it's need it, but just asking. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c20 --- Comment #20 from Olaf Hering <ohering@suse.com> 2013-07-17 10:15:33 CEST --- (In reply to comment #18)
(In reply to comment #17)
(In reply to comment #16)
Except for the missing mkinitrd directories, yes.
What do you? In the spec file '%dir ...' missing?
I don't want to see mkinitrd directories owned by systemd package. They should be owned by mkinitrd package only. There is no point in owning those directories in systemd.
No idea who came up with such statements that owning dirs is bad, its certainly wrong. As said in comment #10 and comment #12, not owning parent directories is bad. If the dir ever changes or if both packages are removed, systemd will leave a /lib/mkinitrd/setup dir behind because rpm can not know that it has to remove /lib/mkinitrd (if systemd.rpm happens to be the last owner in the chain). And just using "/lib/mkinitrd" will tell rpm to recursivly package that dir and its content. The long form would be "%dir /lib/mkinitrd; %dir /lib/mkinitrd/setup; /lib/mkinitrd/setup/*". The latter just clutters spec files. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c21 --- Comment #21 from Frederic Crozat <fcrozat@suse.com> 2013-07-17 08:23:36 UTC --- (In reply to comment #20)
(In reply to comment #18)
(In reply to comment #17)
(In reply to comment #16)
Except for the missing mkinitrd directories, yes.
What do you? In the spec file '%dir ...' missing?
I don't want to see mkinitrd directories owned by systemd package. They should be owned by mkinitrd package only. There is no point in owning those directories in systemd.
No idea who came up with such statements that owning dirs is bad, its certainly wrong.
Multiple packages owning directories is bad practise (moreover when some have different permissions), in general. And in this particular case, there is no point for systemd to own directories which are owned by mkinitrd already (which will also be installed, since it is required by udev). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c22 --- Comment #22 from Frederic Crozat <fcrozat@suse.com> 2013-07-17 09:43:56 UTC --- We can drop this feature request entirely, it has been removed in systemd upstream (they rely now on using systemd in initramfs to get the information). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=751558 https://bugzilla.novell.com/show_bug.cgi?id=751558#c23 Olaf Hering <ohering@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED InfoProvider|crrodriguez@opensuse.org | Resolution| |UPSTREAM --- Comment #23 from Olaf Hering <ohering@suse.com> 2013-07-17 12:13:18 CEST --- (In reply to comment #22)
... systemd in initramfs ...
LOL -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com