[Bug 907352] New: Bash tab completion does not escape paths (broken in 13.2) - openSUSE Bugs - openSUSE Mailing Lists

newer
[Bug 842938] New: let mailcap open...

[Bug 907352] New: Bash tab completion does not escape paths (broken in 13.2)

older
[Bug 906900] PostgreSQL improper...

bugzilla_noreply＠novell.com

26 Nov 2014 26 Nov '14

16:47

http://bugzilla.opensuse.org/show_bug.cgi?id=907352 Bug ID: 907352 Summary: Bash tab completion does not escape paths (broken in 13.2) Classification: openSUSE Product: openSUSE Distribution Version: 13.2 Hardware: Other OS: openSUSE 13.2 Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: bnc-team-screening@forge.provo.novell.com Reporter: szotsaki@gmail.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- After upgrading from 13.1 to 13.2 I noticed that Bash <TAB> completion doesn't work as before. Let's say I would like to create a file "Test filename.txt" in directory "~/temp/test/" and open it first in vi then in mpv (an mplayer2 alternative video player). Naturally, I also would like to use <TAB> in bash. The following commands I issue. [ ] denotes space - cd - md te<TAB> --> md temp[ ] - backspace, slash, "test", Return - cd te<TAB> --> cd temp/<TAB> --> cd temp/test/ - touch "Test filename.txt" - vi Te<TAB> --> vi Test\ filename.txt - mpv Te<TAB> --> mpv Test filename.txt The bug is that Bash sometimes escapes files and sometimes not. I think it's based on the command but since it's impossible to list all the executables in the Linux world, I would say it's a really annoying behaviour. As you can see it doesn't work well for the built-in alias md (make dir). - When I create a directory (md) I have to clear back but when I change into it, I don't. - When I open a file with vi, I don't have to escape the path but when I open it with an other program, I have to. -- You are receiving this mail because: You are on the CC list for the bug.

Attachments:

attachment.htm (text/html — 3.3 KB)

Reply

Sign in to reply online Use email software

Show replies by date

bugzilla_noreply＠novell.com

27 Nov 27 Nov

07:20

New subject: [Bug 907352] Bash tab completion does not escape paths (broken in 13.2)

http://bugzilla.opensuse.org/show_bug.cgi?id=907352 Bernhard Wiedemann changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arvidjaar@gmail.com, | |bwiedemann@suse.com, | |szotsaki@gmail.com Flags| |needinfo?(szotsaki@gmail.co | |m) --- Comment #1 from Bernhard Wiedemann --- I can not reproduce the md and (packman) mpv completion behaviour. Here it produces (as it should): md temp/ mpv Test\ filename.txt Can you please give the output of rpm -qf /etc/bash_completion.d/* -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

09:31

New subject: [Bug 907352] Bash tab completion does not escape paths (broken in 13.2)

http://bugzilla.opensuse.org/show_bug.cgi?id=907352 --- Comment #2 from Ákos Szőts --- Of course, thank you for the quick reply. rpm -qf /etc/bash_completion.d/* : AdobeReader_enu-9.5.5-1.i486 aria2-1.18.5-2.1.4.x86_64 bzr-2.6.0-2.1.7.x86_64 dbus-1-glib-0.102-2.1.3.x86_64 dracut-037-17.6.1.x86_64 git-core-2.1.2-5.1.x86_64 git-core-2.1.2-5.1.x86_64 grub2-2.02~beta2-20.5.1.x86_64 libreoffice-4.3.3.2-4.1.x86_64 dracut-037-17.6.1.x86_64 mercurial-3.1.2-132.5.x86_64 mpclient-0.23-1.8.x86_64 libreoffice-4.3.3.2-4.1.x86_64 pulseaudio-5.0-4.5.1.x86_64 rpmdevtools-8.3-2.1.noarch scout-0.1.0-58.1.4.noarch tuned-2.3.0-4.1.4.noarch yast2-3.1.109-4.2.x86_64 zypper-1.11.14-2.1.x86_64 ls -1 /etc/bash_completion.d/*: /etc/bash_completion.d/acroread.sh /etc/bash_completion.d/aria2c /etc/bash_completion.d/bzr /etc/bash_completion.d/dbus-bash-completion.sh /etc/bash_completion.d/dracut /etc/bash_completion.d/git-prompt.sh /etc/bash_completion.d/git.sh /etc/bash_completion.d/grub /etc/bash_completion.d/libreoffice.sh /etc/bash_completion.d/lsinitrd /etc/bash_completion.d/mercurial.sh /etc/bash_completion.d/mpc-completion.sh /etc/bash_completion.d/ooffice.sh /etc/bash_completion.d/pulseaudio-bash-completion.sh /etc/bash_completion.d/rpmdevtools.bash-completion /etc/bash_completion.d/scout.sh /etc/bash_completion.d/tuned.bash /etc/bash_completion.d/yast2-completion.sh /etc/bash_completion.d/zypper.sh -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

10:06

New subject: [Bug 907352] Bash tab completion does not escape paths (broken in 13.2)

http://bugzilla.opensuse.org/show_bug.cgi?id=907352 --- Comment #3 from Bernhard Wiedemann --- btw: you should really rpm -e AdobeReader_enu because it likely contains exploitable security bugs. firefox, epdfview and okular are good PDF viewers. I still can not reproduce the problem with all the other packages installed. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

12:05

New subject: [Bug 907352] Bash tab completion does not escape paths (broken in 13.2)

http://bugzilla.opensuse.org/show_bug.cgi?id=907352 --- Comment #4 from Andrei Borzenkov --- Please show output of complete | grep -Ew 'cd|md|vi|-D' rpm -q bash-completion -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

15:53

New subject: [Bug 907352] Bash tab completion does not escape paths (broken in 13.2)

http://bugzilla.opensuse.org/show_bug.cgi?id=907352 --- Comment #5 from Ákos Szőts --- complete | grep -Ew 'cd|md|vi|-D': complete -F _completion_loader -D complete -F _filedir_xspec vi complete -o nospace -F _cd cd rpm -q bash-completion: bash-completion-2.1-5.1.2.noarch zypper se -svi bash-completion: S | Name Version | Architecture | Repository --+-------------------------+----------+--------------+------------------ i | bash-completion 2.1-5.1.2 | noarch | openSUSE-13.2 i | systemd-bash-completion 210-25.5.4 | noarch | openSUSE-13.2 I pasted the whole "complete" command output here in case you need it or you want to compare it: http://paste.opensuse.org/28221409 -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

17:41

New subject: [Bug 907352] Bash tab completion does not escape paths (broken in 13.2)

http://bugzilla.opensuse.org/show_bug.cgi?id=907352 --- Comment #6 from Andrei Borzenkov --- This looks OK. Could you please run completion of e.g. md that does not work correctly under set -x and attach results script set -x md teTAB ^C exit You will get typescript flie in current directory with complete output. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

19:19

New subject: [Bug 907352] Bash tab completion does not escape paths (broken in 13.2)

http://bugzilla.opensuse.org/show_bug.cgi?id=907352 --- Comment #7 from Ákos Szőts --- Created attachment 615287 --> http://bugzilla.opensuse.org/attachment.cgi?id=615287&action=edit script output for "set -x; md te<TAB>; Ctrl+C" with a directory only "temp/" inside I created a new, empty directory called "~/test2", changed into it, created a new "temp" directory inside and after that I started the script..exit command-series: script set -x md teTAB ^C exit -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

20:00

New subject: [Bug 907352] Bash tab completion does not escape paths (broken in 13.2)

http://bugzilla.opensuse.org/show_bug.cgi?id=907352 --- Comment #8 from Andrei Borzenkov --- Something in your environment (re-)defines _filedir function. It resembles very old (12+) years _filedir from bash-completion. Please test with new clean user account - do you still have the same problem? -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

28 Nov 28 Nov

08:46

New subject: [Bug 907352] Bash tab completion does not escape paths (broken in 13.2)

http://bugzilla.opensuse.org/show_bug.cgi?id=907352 --- Comment #9 from Ákos Szőts --- I have this version declared now: declare -f _filedir: _filedir () { local IFS=' ' xspec; xspec=${1:+"!*.$1"}; COMPREPLY=(${COMPREPLY[@]:-} $( compgen -f -X "$xspec" -- "$cur" ) $( compgen -d -- "$cur" )) } And it's declared in the acroread.sh... shopt -s extdebug && declare -F _filedir && shopt -u extdebug: _filedir 3 /etc/bash_completion.d/acroread.sh The interesting thing is that this bug came alive just now, while my AcroReader is installed for years. According to "_blacklist_glob='@(acroread.sh)'" in /usr/share/bash-completion/bash_completion:48 (if that file is still in use), the acroread.sh should have no effect on my system. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

09:16

New subject: [Bug 907352] Bash tab completion does not escape paths (broken in 13.2)

http://bugzilla.opensuse.org/show_bug.cgi?id=907352 Andrei Borzenkov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Flags|needinfo?(szotsaki@gmail.co | |m) | --- Comment #10 from Andrei Borzenkov --- (In reply to Ákos Szőts from comment #9)

shopt -s extdebug && declare -F _filedir && shopt -u extdebug: _filedir 3 /etc/bash_completion.d/acroread.sh

The interesting thing is that this bug came alive just now, while my AcroReader is installed for years.

Before 13.2 bash-completion was usually nor present, so it did not matter. In 13.2 bash-completion is pulled in by systemd-bash-completion, and /etc/bash_completion.d is processed after bash-completion is initialized. acroread.sh should check whether _filedir is already defined; cf. /etc/bash_completion.d/quilt.sh. Closing as not a bug. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

09:21

New subject: [Bug 907352] Bash tab completion does not escape paths (broken in 13.2)

http://bugzilla.opensuse.org/show_bug.cgi?id=907352 --- Comment #11 from Ákos Szőts --- Ah, I see now. Thank you for your effort debugging this issue. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

3506

Age (days ago)

3508

Last active (days ago)

Download

11 comments

1 participants

tags

participants (1)

bugzilla_noreply＠novell.com