[Bug 1139990] New: window-list extension for gnome-shell-classic references convenience.js has been removed.
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990 Bug ID: 1139990 Summary: window-list extension for gnome-shell-classic references convenience.js has been removed. Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: GNOME Assignee: bnc-team-gnome@forge.provo.novell.com Reporter: dgersic@cisus.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.103 Safari/537.36 OPR/60.0.3255.170 Build Identifier: Tumbleweed (VERSION_ID="20190626") with gnome-shell-classic-3.32.1-2.2.noarch The window-list extension does not show up on the desktop like it should. Run journalctl and look for "window-list". It should be reporting an error. Mine was complaining about "Convenience" being undefined. /usr/share/gnome-shell/extensions/window-list@gnome-shell-extensions.gcampax.github.com/extension.js references "Convenience", which looks like it used to be part of this extension, but has been removed in the current builds. Around line 62 of extension.js, change: this._settings = Convenience.getSettings(); to: this._settings = ExtensionUtils.getSettings(); Restart Gnome and window-list shows up correctly. Reproducible: Always Steps to Reproduce: 1. Log in to Gnome desktop using Classic mode 2. Run applications. 3. Notice that the "window-list" extension is not showing applications in the status bar, bottom of the screen. Actual Results: The window-list extension shows no applications. Expected Results: The window-list extension should be showing applications. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990
Yifan Jiang
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990
QK ZHU
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990#c1
--- Comment #1 from QK ZHU
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990#c2
--- Comment #2 from David Gersic
Hi David,
I can't reproduce this on TW-20190703.
Convenience module is now a gnome-shell built-in module(extensionUtils), so all the extensions should update how they import this module for GNOME 3.32. - https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/150
Your error is very likely caused by an extension which is not compatible with 3.32. Could you please check the extensions installed in your system? - Check it in Tweak tools or - gsettings get org.gnome.shell enabled-extensions
I just upgraded to TW-20190704 and reproduced the problem exactly as before. Agreed, all extensions should no longer be using convenience, should be changed to use the extensionUtils module. This one seems to have been missed. The error is here: this._appSystem = Shell.AppSystem.get_default(); this._appStateChangedId = this._appSystem.connect('app-state-changed', this._onAppStateChanged.bind(this)); ==> this._settings = Convenience.getSettings(); <=== // Grouping this._groupingModeChangedId = this._settings.connect('changed::grouping-mode', this._groupingModeChanged.bind(this)); this._grouped = undefined; // NOTE: do NOT `_checkGrouping` here in /usr/share/gnome-shell/extensions/window-list@gnome-shell-extensions.gcampax.github.com/extension.js If I replace: this._settings = Convenience.getSettings(); with: this._settings = ExtensionUtils.getSettings(); then the window-list extension works correctly. I don't see how any other installed extension could be affecting the contents of this file, but here's the output you asked for: dgersic@farfalla:~> gsettings get org.gnome.shell enabled-extensions ['Panel_Favorites@rmy.pobox.com', 'launch-new-instance@gnome-shell-extensions.gcampax.github.com', 'sle-classic@suse.com', 'workspace-indicator@gnome-shell-extensions.gcampax.github.com', 'WindowIconList@whise.com', 'yawl@dbfin.com', 'window-list@gnome-shell-extensions.gcampax.github.com'] -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990#c3
--- Comment #3 from David Gersic
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990#c4
--- Comment #4 from QK ZHU
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990#c5
QK ZHU
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990
http://bugzilla.opensuse.org/show_bug.cgi?id=1139990#c6
--- Comment #6 from OBSbugzilla Bot
participants (2)
-
bugzilla_noreply@novell.com
-
bugzilla_noreply@suse.com