[Bug 820218] New: ibus qt tray icon is not in keeping with KDE monochrome icon look.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c0 Summary: ibus qt tray icon is not in keeping with KDE monochrome icon look. Classification: openSUSE Product: openSUSE 12.3 Version: Final Platform: x86-64 OS/Version: Other Status: NEW Severity: Minor Priority: P5 - None Component: KDE4 Applications AssignedTo: kde-maintainers@suse.de ReportedBy: mrkfbrn@yahoo.co.nz QAContact: qa-bugs@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:20.0) Gecko/20100101 Firefox/20.0 since kde 4.10 the ibus tray icon is not in keeping with the monochrome look of KDE tray icons and looks somewhat out of place in the KDE system tray. - see screen-shot. some other distributions have different icons for ibus to keep the look consistent with the currently used DE. Reproducible: Always Expected Results: re-work ibus icon to be consistent with kde 4.10 openSUSE look (openSUSE theme) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c1 --- Comment #1 from Mark Fairbairn <mrkfbrn@yahoo.co.nz> 2013-05-16 14:08:00 UTC --- Created an attachment (id=539617) --> (http://bugzilla.novell.com/attachment.cgi?id=539617) current ibus qt tray icon -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c2 Hrvoje Senjan <hrvoje.senjan@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |hrvoje.senjan@gmail.com AssignedTo|kde-maintainers@suse.de |hrvoje.senjan@gmail.com --- Comment #2 from Hrvoje Senjan <hrvoje.senjan@gmail.com> 2013-05-16 22:22:53 UTC --- Hi Mark, will check what could be done on this front... (no idea how to theme it, for now) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c3 --- Comment #3 from Mark Fairbairn <mrkfbrn@yahoo.co.nz> 2013-05-17 05:09:50 UTC --- If I recall correctly (and perhaps I don't), earlier versions of ibus were gtk dependant and for whatever reason - in openSUSE we always ended up with a gtk icon in system tray. Now it is no longer dependant on gtk we get the qt icon, but this doesn't seem to have had any work done to it for a very long time. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c4 Marguerite Su <i@marguerite.su> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i@marguerite.su --- Comment #4 from Marguerite Su <i@marguerite.su> 2013-05-20 16:00:19 UTC --- Hi, IBus itself can't be "themed" at all, to any level. You can't make any so-called "theme" for it. openSUSE Chinese community even raised about 1000CNY to find a developer to implement a skin/theme feature for standalone IBus in our 12.2 era, (because upstream developer , our friend @phuang said this is of very low priority for him to do it, he just got his hands a bit full...), but no one is interested in it. Actually this is a feature request starting from Jan. 2009, at the early stage of ibus: https://code.google.com/p/ibus/issues/detail?id=229 then got refactored by other PMs because phuang has his focus changed: https://code.google.com/p/ibus/issues/detail?id=1531 and still not implemented today. So all our artwork team can do is to hardcode this icon file: https://github.com/ibus/ibus/tree/master/data/icons ibus-keyboard.png at build time. But it's still using its own _text_ colors, we can change them this way (also hardcoded): http://imdiot.appspot.com/2010-09-13-31001 And the panel colors are maintained by gtk style, you can just adjust the global gtk style. Then the problem comes to be: We're working hard to let things happen, but after you slightly change a GNOME/KDE theme, everything discords again. BTW, for GNOME shell, you can change the stylesheet.css to give IBus an unique looking, but the original post was in 2011: http://maoyaotang.blog.163.com/blog/static/115524960201173042043310/ So I don't even know if the "IBus indicator" the author mentioned was "ibus-gjs": https://extensions.gnome.org/extension/68/input-method-status-indicator/ All in all, IBus itself isn't quite "theme" friendly but it's still tweakable. So make decision with caution. Greetings Marguerite -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c5 --- Comment #5 from Mark Fairbairn <mrkfbrn@yahoo.co.nz> 2013-05-20 17:48:34 UTC --- Created an attachment (id=540171) --> (http://bugzilla.novell.com/attachment.cgi?id=540171) example Here is an example of how ubuntu have dealt with mono icons for their DE. I'm not suggesting though that these would be the right choice for openSUSE (but would certainly be better than the current choice). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c6 --- Comment #6 from Mark Fairbairn <mrkfbrn@yahoo.co.nz> 2013-05-20 17:53:05 UTC --- Created an attachment (id=540173) --> (http://bugzilla.novell.com/attachment.cgi?id=540173) another example -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c7 --- Comment #7 from Mark Fairbairn <mrkfbrn@yahoo.co.nz> 2013-05-20 17:55:52 UTC --- Created an attachment (id=540174) --> (http://bugzilla.novell.com/attachment.cgi?id=540174) another -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c8 --- Comment #8 from Marguerite Su <i@marguerite.su> 2013-05-21 11:00:05 UTC --- Created an attachment (id=540381) --> (http://bugzilla.novell.com/attachment.cgi?id=540381) ibus-keyboard.svgz please try putting this svgz icon in /usr/share/kde4/apps/desktoptheme/default/icons and see if anything happens to IBus systray icon. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c9 --- Comment #9 from Mark Fairbairn <mrkfbrn@yahoo.co.nz> 2013-05-21 14:29:57 UTC --- thanks, but I am not seeing any change in the icon after following your instructions. I'm testing this in openSUSE 12.2 if that makes any difference. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c10 --- Comment #10 from Marguerite Su <i@marguerite.su> 2013-05-21 14:51:19 UTC --- (In reply to comment #9)
thanks, but I am not seeing any change in the icon
Well...it's something alike the Ubuntu way. To use a system directory with super priority to substitute application's. You must see things like amarok.svgz in that directory. That's the standard KDE implementation. But it failed, so it proved actually IBus has no integration with KDE at all. So, IBus itself can't be themed, and it can't take the KDE's implementation. There's no convenient way we can do it without hardcoding. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c11 --- Comment #11 from Marguerite Su <i@marguerite.su> 2013-05-21 17:34:53 UTC --- Created an attachment (id=540466) --> (http://bugzilla.novell.com/attachment.cgi?id=540466) new ibus systray Hi, Mark, After consulting phuang, I find a `not so dirty` workaround. That is, install our kde-specific icons in /usr/share/icons/oxygen. In openSUSE, only KDE uses oxygen as its icon theme. So this hack will benefit for openSUSE KDE without discording openSUSE GNOME/Xfce4. Is this new icon okay to you? If yes: I need a KDE maintainer to review if polluting oxygen is acceptable And you have to assign the bug to me so I can actually fix it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c12 --- Comment #12 from Hrvoje Senjan <hrvoje.senjan@gmail.com> 2013-05-21 17:39:23 UTC --- (In reply to comment #11)
I need a KDE maintainer to review if polluting oxygen is acceptable
Marguerite that's fine for me. IMHO best solution would be to provide branding package for ibus (upstream vs. openSUSE) What do you think? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c13 --- Comment #13 from Marguerite Su <i@marguerite.su> 2013-05-21 17:45:29 UTC --- (In reply to comment #12)
Marguerite that's fine for me. IMHO best solution would be to provide branding package for ibus (upstream vs. openSUSE) What do you think?
Yes, I can provide a "ibus-branding-openSUSE-KDE" package with these new icons. This package won't override original icons, they're still in /usr/share/icons/hicolor. So no branding-upstream package. They just work for KDE, so no side-effects for GNOME or other DEs. So have to be branding-openSUSE-KDE instead of branding-openSUSE, :-) Please assign it to me. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c14 Hrvoje Senjan <hrvoje.senjan@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|hrvoje.senjan@gmail.com |i@marguerite.su --- Comment #14 from Hrvoje Senjan <hrvoje.senjan@gmail.com> 2013-05-21 18:56:21 UTC --- Sounds good :-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c15 --- Comment #15 from Mark Fairbairn <mrkfbrn@yahoo.co.nz> 2013-05-22 02:43:14 UTC --- yes, icon looks great - although could be a little smaller. Something similar in size to the fcitx icon you(?) created for 12.3. Also, there would need to be an alternative for use with the dark openSUSE theme as the one you have attached above appears to be for a more traditional coloured theme. Thanks for the hard work put into this. :-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c16 --- Comment #16 from Marguerite Su <i@marguerite.su> 2013-05-24 07:24:32 UTC --- Created an attachment (id=541083) --> (http://bugzilla.novell.com/attachment.cgi?id=541083) new ibus systray air Hi, Mark, I didn't quite get what you want me to do. Let me explain a little: 1. we can only have one look for each version of openSUSE. no matter which plasma theme your chose, there's only a fixed ibus systray icon. that is, we can only handle the default look, because there's only on oxygen directory for us to override. 2. the eariler icon is created based on openSUSE 12.3 dark theme. so it has the same color and look as the other 12.3 system icons. And here's one thing I want to make clear: Did you want us to provide monochrome icons for ibus in all released versions of openSUSE, or just for 12.3? (In the means of update, they're different, because all released version has 3 update targets and 12.3 has one.) As I saw, you said in one reply that you were using 12.2. So I took some time and made this icon for 12.2 and below, because at that time we're still using Air theme. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c17 --- Comment #17 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-05-24 12:00:09 CEST --- This is an autogenerated message for OBS integration: This bug (820218) was mentioned in https://build.opensuse.org/request/show/176477 Maintenance / -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c18 --- Comment #18 from Mark Fairbairn <mrkfbrn@yahoo.co.nz> 2013-05-24 11:26:12 UTC ---
1. we can only have one look for each version of openSUSE.
no matter which plasma theme your chose, there's only a fixed ibus systray icon. that is, we can only handle the default look, because there's only on oxygen directory for us to override.
Yes, sorry. I think that was my misunderstanding.
Did you want us to provide monochrome icons for ibus in all released versions of openSUSE, or just for 12.3? (In the means of update, they're different, because all released version has 3 update targets and 12.3 has one.)
As I saw, you said in one reply that you were using 12.2.
So I took some time and made this icon for 12.2 and below, because at that time we're still using Air theme.
I am using 12.2 but with kde 4.10.3 and the same openSUSE theme as that used in 12.3. I understand the difficulties in adding this to 12.2 though as most people are probably still using air and it would not be possible to add the new icon to the KDE repo. To get the 12.3 icon working in 12.2 can I just copy the earlier attached icon to /usr/share/icons/oxygen or are there other steps required? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c19 --- Comment #19 from Mark Fairbairn <mrkfbrn@yahoo.co.nz> 2013-05-24 11:27:37 UTC --- btw - the air icon you attached does look quite good. :-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c20 --- Comment #20 from Mark Fairbairn <mrkfbrn@yahoo.co.nz> 2013-05-24 12:19:14 UTC --- Created an attachment (id=541156) --> (http://bugzilla.novell.com/attachment.cgi?id=541156) kde 4.10 on 12.2 what I have done is get a hold of your rpm for 12.3 and installed it into 12.2 ignoring the dependency conflicts and it is looking great!! Thanks again for the hard work. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c21 --- Comment #21 from Benjamin Brunner <bbrunner@suse.com> 2013-05-27 14:02:43 CEST --- Hi Marguerite, thanks for your submission. Do we need this fix in the devel-project M17N, too? Additionally, I will remove the 12.1 package from the running update, after it has reached end of maintenance, since May, 15th. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c22 --- Comment #22 from Marguerite Su <i@marguerite.su> 2013-05-27 12:54:31 UTC --- Hi, Benjamin, Yes, we need it. and I plan to. but one thing hold me back is: I can't decide 13.1/12.4 artwork style. it's not shaped yet. I usually make brandings for CJK packages till our main artwork is decided. But yes, I can just push the old one for 12.3 for the moment. Okay, thanks for the help, I didn't noticed that and mbranch gave them by default. Next time I'll branch one by one. Greetings Marguerite -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c23 --- Comment #23 from Benjamin Brunner <bbrunner@suse.com> 2013-05-27 15:06:51 CEST --- Hm, strange. mbranch shouldn't branch 12.1 anymore. Good to know, I'll talk to the BuildService-guys ;) And thanks for clarify with Factory/13.1. I already started the update for 12.2 and 12.3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c24 --- Comment #24 from Benjamin Brunner <bbrunner@suse.com> 2013-05-27 15:22:52 CEST --- I removed 12.1 now, Future mbranches shouldn't contain 12.1-packages. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c25 --- Comment #25 from Mark Fairbairn <mrkfbrn@yahoo.co.nz> 2013-05-28 14:22:21 UTC --- been thinking about this and wondering if it is a good idea to tie the icon set to a release. Might it perhaps be a better idea to tie the icon set to a theme instead. Of course you cannot create an icon set for every KDE theme - but by far the most common theme used in openSUSE is either the dark openSUSE theme or Air. I believe there are many users of both of these themes in both 12.2 and 12.3. Would it perhaps be a better idea to have both sets of icons available for each release maybe with the naming convention ibus-branding-openSUSE-KDE ibus-branding-Air-KDE setting up a conflict so that only one set of icons can be installed at one time. I feel like I am not being very clear here but perhaps you can get the gist of my meaning? :-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c26 --- Comment #26 from Benjamin Brunner <bbrunner@suse.com> 2013-06-03 05:04:49 CEST --- I released the update for openSUSE 12.2 and 12.3 for now, but I'll leave the bug open for further discussions. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c27 --- Comment #27 from Swamp Workflow Management <swamp@suse.de> 2013-06-03 04:04:21 UTC --- openSUSE-OU-2013:0854-1: An update that has one optional fix can now be installed. Category: optional (low) Bug References: 820218 CVE References: Sources used: openSUSE 12.2 (src): ibus-1.4.1-3.5.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c28 --- Comment #28 from Swamp Workflow Management <swamp@suse.de> 2013-06-10 10:20:26 UTC --- openSUSE-OU-2013:0958-1: An update that has one optional fix can now be installed. Category: optional (low) Bug References: 820218 CVE References: Sources used: openSUSE 12.3 (src): ibus-1.4.2-4.10.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=820218 https://bugzilla.novell.com/show_bug.cgi?id=820218#c29 Marguerite Su <i@marguerite.su> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #29 from Marguerite Su <i@marguerite.su> 2013-06-22 02:46:05 UTC --- (In reply to comment #25)
I feel like I am not being very clear here but perhaps you can get the gist of my meaning? :-)
I get it, but it's not technically possible. KDE theme uses such directory scheme: /usr/share/kde4/apps/desktoptheme/%{name} it means there's one specific directory for each theme. But it's not the case for ibus. No matter which theme, it declares ownerships of /usr/share/icons/oxygen/*x*/apps/ibus-keyboard.* But in packaging, we can't, eg: 1. install air icons to those paths, generate a sub-package. 2. override those paths with dark icons, generate another sub-package. Package generation is the last step. Before that, you have to have all icons installed. That is, icons need different directories. Unless, we create a separate package for one of them. But, maintenance request doesn't allow _new_ package. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com