https://bugzilla.novell.com/show_bug.cgi?id=306697 Arvin Schnell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=306697#c3 --- Comment #3 from Arvin Schnell 2007-11-28 06:42:02 MST --- Created an attachment (id=185074) --> (https://bugzilla.novell.com/attachment.cgi?id=185074) patch for zypper -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=306697 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=306697#c5 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jkupec@novell.com Status|NEEDINFO |ASSIGNED Info Provider|jkupec@novell.com | --- Comment #5 from Ján Kupec 2008-01-15 08:29:29 MST --- Thanx, i used the patch, but still: (In reply to comment #2 from Arvin Schnell)

I have discussed the issue with ma:

1) About parsing XML-files: We can make the INI-parser more strict by requiring: - Lines that are not empty, comments or sections must contain a "=". - No spaces in keys.

This is good!

2) The parser should only throw on real parsing errors but not on missing, empty or even invalid keys and values.

I agree for the IniParser, but why not RepoFileReader? It could throw an InvalidRepoFile exception for missing URL or mandatory key (like the 'baseurl'). Or even a NotARepoFile exception if there is something upon which we can decide that it is not. Uhm.. well, a minor problem could be that we support multiple repos per file, but still.. what do you think?

This would make it impossible to modify those repos with libzypp.

I don't see your point here.. Currently we do modifications to .repo files by completely rewriting them.

So the check for a missing URL should be done inside zypper.

Doing the validation in the libzypp user code asks for duplication of code. Zypper will validate, yast will validate, ... It makes no sense for the RepoFileReader to return invalid RepoInfos. Anyway.. we probably don't have to do a thorough validation, checking for non-empty alias and URL in zypper as you suggested is probably enough. I just want to check this idea with you a bit further. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=306697 User aschnell@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=306697#c7 Arvin Schnell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #7 from Arvin Schnell 2008-02-19 05:36:31 MST --- Ok, closed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.