[Bug 1224285] New: 6.9 broke pidfd
https://bugzilla.suse.com/show_bug.cgi?id=1224285 Bug ID: 1224285 Summary: 6.9 broke pidfd Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Kernel Assignee: kernel-bugs@opensuse.org Reporter: jslaby@suse.com QA Contact: qa-bugs@suse.de Target Milestone: --- Found By: --- Blocker: --- https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:K... https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:K... commit cb12fd8e0dabb9a1c8aef55a6a41e2c255fcdf4b Author: Christian Brauner <brauner@kernel.org> Date: Mon Feb 12 16:32:38 2024 +0100 pidfd: add pidfs Without the commit, lsof shows: systemd ... 59 [pidfd:899] With the commit: systemd ... 1187 pidfd For util-linux, its test fail with:
[ 125s] --- tests/expected/lsfd/column-name-pidfd 2024-05-06 07:20:54.655845940 +0000 [ 125s] +++ tests/output/lsfd/column-name-pidfd 2024-05-15 01:04:15.406666666 +0000 [ 125s] @@ -1,2 +1,2 @@ [ 125s] -3 anon_inode:[pidfd] pid=1 comm= nspid=1 [ 125s] +3 pidfd:[INODENUM] pidfd:[INODENUM] [ 125s] pidfd:ASSOC,KNAME,NAME: 0 [ 125s] lsfd: NAME and KNAME column: [02] pidfd ... FAILED (lsfd/column-name-pidfd)
And:
[ 125s] --- tests/expected/lsfd/column-type-pidfd 2024-05-06 07:20:54.655845940 +0000 [ 125s] +++ tests/output/lsfd/column-type-pidfd 2024-05-15 01:04:15.573333333 +0000 [ 125s] @@ -1,2 +1,2 @@ [ 125s] -3 UNKN pidfd [ 125s] +3 REG REG [ 125s] pidfd:ASSOC,STTYPE,TYPE: 0 [ 125s] lsfd: TYPE and STTYPE column: [02] pidfd ... FAILED (lsfd/column-type-pidfd) -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1224285 https://bugzilla.suse.com/show_bug.cgi?id=1224285#c1 Jiri Slaby <jslaby@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kernel-bugs@opensuse.org |jslaby@suse.com Status|NEW |IN_PROGRESS --- Comment #1 from Jiri Slaby <jslaby@suse.com> --- Reported: https://lore.kernel.org/all/210098f9-1e71-48c9-be08-7e8074ec33c1@kernel.org/ -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1224285 Jiri Slaby <jslaby@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkubecek@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1224285 https://bugzilla.suse.com/show_bug.cgi?id=1224285#c2 --- Comment #2 from Jiri Slaby <jslaby@suse.com> --- util-linux is supposed to be fixed by: commit 04db2ba9008e9635286b1aafc8ecd9533a0a91bf Author: Xi Ruoyao <xry111@xry111.site> Date: Thu Mar 28 04:01:02 2024 +0800 lsfd: test: Adapt test cases for pidfs https://github.com/util-linux/util-linux/commit/04db2ba9008e9635286b1aafc8ec... Backporting whole PR: https://github.com/util-linux/util-linux/pull/2866 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1224285 https://bugzilla.suse.com/show_bug.cgi?id=1224285#c3 Jiri Slaby <jslaby@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danilo.spinella@suse.com, | |sbrabec@suse.com --- Comment #3 from Jiri Slaby <jslaby@suse.com> --- (In reply to Jiri Slaby from comment #2)
Backporting whole PR: https://github.com/util-linux/util-linux/pull/2866
https://build.opensuse.org/request/show/1174396 lsof to be fixed yet. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1224285 Jiri Slaby <jslaby@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/lsof-org | |/lsof/issues/317 | |https://github.com/util-lin | |ux/util-linux/issues/2865 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1224285 https://bugzilla.suse.com/show_bug.cgi?id=1224285#c4 Jiri Slaby <jslaby@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|IN_PROGRESS |RESOLVED --- Comment #4 from Jiri Slaby <jslaby@suse.com> --- I think we are done as lsof was fixed via https://github.com/lsof-org/lsof/issues/317 in SR#1174912. And the kernel via: commit db3d841ac9edb0b98cc002e3b27c0b266ecfe5ba Author: Linus Torvalds <torvalds@linux-foundation.org> Date: Tue May 21 14:34:43 2024 +0200 fs/pidfs: make 'lsof' happy with our inode changes -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1224285 https://bugzilla.suse.com/show_bug.cgi?id=1224285#c5 --- Comment #5 from Stanislav Brabec <sbrabec@suse.com> --- Do we need to backport of these lsof and lsfd changes to older products like SLE15 SP5, SLE15 SP6, SLE Micro 6.0, or SLFO and Factory are sufficient? -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1224285 https://bugzilla.suse.com/show_bug.cgi?id=1224285#c6 --- Comment #6 from Jiri Slaby <jslaby@suse.com> --- (In reply to Stanislav Brabec from comment #5)
Do we need to backport of these lsof and lsfd changes to older products like SLE15 SP5, SLE15 SP6, SLE Micro 6.0, or SLFO and Factory are sufficient?
Whatever distro is going to use kernel 6.9+, needs updates of the above. (I.e. none of the SL above. Dunno what SLFO is.) -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com