[Bug 781687] New: DISPLAYMANAGER_KDM_THEME isn't updated in 12.1 to 12.2 upgrade causing generic KDM theme
https://bugzilla.novell.com/show_bug.cgi?id=781687 https://bugzilla.novell.com/show_bug.cgi?id=781687#c0 Summary: DISPLAYMANAGER_KDM_THEME isn't updated in 12.1 to 12.2 upgrade causing generic KDM theme Classification: openSUSE Product: openSUSE 12.2 Version: Final Platform: x86-64 OS/Version: openSUSE 12.2 Status: NEW Severity: Minor Priority: P5 - None Component: YaST2 AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: jdmulloy@gmail.com QAContact: jsrain@suse.com Found By: --- Blocker: --- Created an attachment (id=506691) --> (http://bugzilla.novell.com/attachment.cgi?id=506691) Screenshot of the KDM theme that you get after upgrading to 12.2 User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.81 Safari/537.1 After upgrading my laptop from 12.1 to 12.2 via a USB stick with the DVD image on it, I got a KDM theme that was very nice, but generic. It turns out that from 12.1 to 12.2 the default theme was renamed from "SUSE" to "openSUSE". Changing the DISPLAYMANAGER_KDM_THEME parameter in /etc/sysconfig via YaST (/etc/sysconfig editor -> Desktop -> Display manager) from "SUSE" to "openSUSE" fixes the problem. The upgrade scripts should check to see if this value is set to "SUSE" and if it is, change it to "openSUSE". Reproducible: Always Steps to Reproduce: 1. Upgrade 12.1 to 12.2 with the DVD installer (Possibly happens with other upgrade procedures) 2. 3. Actual Results: KDM has generic theme Expected Results: KDM has nice new openSUSE Theme -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781687 https://bugzilla.novell.com/show_bug.cgi?id=781687#c kk zhang <kkzhang@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkzhang@suse.com AssignedTo|bnc-team-screening@forge.pr |yast2-maintainers@suse.de |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781687 https://bugzilla.novell.com/show_bug.cgi?id=781687#c1 Gabriele Mohr <gs@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO CC| |gs@suse.com InfoProvider| |coolo@suse.com --- Comment #1 from Gabriele Mohr <gs@suse.com> 2012-09-25 11:40:29 UTC --- Who/which script or program is responsible for changing the KDE theme in /etc/sysconfig/displaymanager to "openSUSE" during upgrade? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781687 https://bugzilla.novell.com/show_bug.cgi?id=781687#c2 Joseph Mulloy <jdmulloy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|coolo@suse.com | --- Comment #2 from Joseph Mulloy <jdmulloy@gmail.com> 2012-09-25 14:30:09 UTC --- (In reply to comment #1)
Who/which script or program is responsible for changing the KDE theme in /etc/sysconfig/displaymanager to "openSUSE" during upgrade?
The kdm-branding-openSUSE package is responsible for updating /etc/sysconfig/displaymanager. The config file is updated on line 372 in branding-openSUSE.spec. branding-openSUSE.spec lines 371-372 371 %post -n kdm-branding-openSUSE 372 %{fillup_only -n displaymanager -s kdm} Because there is already a value fillup doesn't change it. I've created a branch to work on a fix. My current fix is to add the following on line 373. 373 sed -i 's/DISPLAYMANAGER_KDM_THEME="SUSE"/DISPLAYMANAGER_KDM_THEME="openSUSE"/' /etc/sysconfig/displaymanager #Fix theme for users upgrading from <= 12.1 (bnc #781687) My branch is home:jdmulloy:branches:openSUSE:12.2:Update/branding-openSUSE.openSUSE_12.2_Update https://build.opensuse.org/package/show?package=branding-openSUSE.openSUSE_12.2_Update&project=home%3Ajdmulloy%3Abranches%3AopenSUSE%3A12.2%3AUpdate This will fix the problem for anyone who has already upgraded, and anyone doing a fresh live upgrade. Anyone who does an upgrade using the regular install media will still see this issue, but this will fix it when they update their system. If this is an acceptable solution I will submit it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781687 https://bugzilla.novell.com/show_bug.cgi?id=781687#c3 Gabriele Mohr <gs@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|yast2-maintainers@suse.de |coolo@suse.com --- Comment #3 from Gabriele Mohr <gs@suse.com> 2012-09-27 12:03:56 UTC --- Coolo, please have a look at the solution provided by Joseph. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781687 https://bugzilla.novell.com/show_bug.cgi?id=781687#c4 --- Comment #4 from Joseph Mulloy <jdmulloy@gmail.com> 2012-10-06 18:18:24 UTC --- Since I haven't heard anything back on this bug I've submitted my fix. OBS Request 137325. https://build.opensuse.org/request/show/137325 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781687 https://bugzilla.novell.com/show_bug.cgi?id=781687#c5 Benjamin Brunner <bbrunner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #5 from Benjamin Brunner <bbrunner@suse.com> 2012-10-15 10:52:44 CEST --- Update released for 12.2. Resolved fixed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781687 https://bugzilla.novell.com/show_bug.cgi?id=781687#c6 --- Comment #6 from Swamp Workflow Management <swamp@suse.de> 2012-10-15 09:08:41 UTC --- openSUSE-RU-2012:1337-1: An update that has one recommended fix can now be installed. Category: recommended (low) Bug References: 781687 CVE References: Sources used: openSUSE 12.2 (src): branding-openSUSE-12.2-11.12.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com