[Bug 299626] New: kpowersave: set changes to what is changed
https://bugzilla.novell.com/show_bug.cgi?id=299626 Summary: kpowersave: set changes to what is changed Product: openSUSE 10.2 Version: Final Platform: i586 OS/Version: Other Status: NEW Severity: Minor Priority: P5 - None Component: Mobile Devices AssignedTo: behlert@novell.com ReportedBy: bluedzins@wp.pl QAContact: qa@suse.de Found By: --- Current implementation sets all values, no matter if user even saw given option. This leads to problems, like integration with KDE. Consider (CPU policy is powersave): user runs KControl, go to Display settings, configures it via kpowersave, set the display to go to stanby after 15 minutes, clicks ok and... CPU is not in dynamic mode. Reason: there is such option in kpowersave as "set CPU policy to" but user didn't even see it, she/he only configured display PS management. Such behaviour is counterintuitive. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299626#c1 --- Comment #1 from Maciej Pilichowski <bluedzins@wp.pl> 2007-08-12 01:38:54 MST --- "CPU is not in dynamic mode." --> "CPU is _NOW_ in dynamic mode.". Sorry for the typo. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299626#c2 Danny Kukawka <dkukawka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dkukawka@novell.com --- Comment #2 from Danny Kukawka <dkukawka@novell.com> 2007-08-13 11:47:56 MST --- Sorry but I don't understand what your problem is? If you change a scheme in KPowersave and save this changes (doesn't matter what you change) KPowersave have to apply the changes. This mean KPowersave have to apply the current scheme. There is no way around this and the user has to live with this behavior. I don't see a problem here and we don't start to add a high complex logic to monitor the changes the user do, to apply on these changes. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299626#c3 --- Comment #3 from Maciej Pilichowski <bluedzins@wp.pl> 2007-08-13 12:09:29 MST ---
There is no way around this
There is.
and the user has to live with this behavior.
You can say the user can live with exploding computers, but nevertheless it is still a bad design.
I don't see a problem here
I see. User was changing monitor settings and all of the sudden all data are resetted.
we don't start to add a high complex logic to monitor the changes the user do, to apply on these changes.
It is not rocket science -- simply set as current values not the default ones, but current (quite obvious IMHO). In this example, if the CPU is powersave do not offer to switch it to dynamic but powersave. This way changes are transparent for the user. Otherwise each time user will be surprised with random changes. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299626#c4 Danny Kukawka <dkukawka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX --- Comment #4 from Danny Kukawka <dkukawka@novell.com> 2007-08-13 12:30:05 MST ---
You can say the user can live with exploding computers, but nevertheless it is still a bad design.
Don't be silly!
I see. User was changing monitor settings and all of the sudden all data are resetted.
There is nothing resetted, only the _actual_ Scheme is applied to the running process. This is what the normal user await.
It is not rocket science -- simply set as current values not the default ones, but current (quite obvious IMHO).
No this is not what a user assume if he change something in the config dialog. Nobody assume he have to switch to an other scheme and back to the current only to get the changes to the running KPowersave instance. Everything else is intransparent for the user and it is as it is currently in KPowersave because this was what user reported in the past. It's the same as if you change the scheme or remove the AC plug: your extra current settings of CPU freq get lost (same for brightness). Nobody would assume something other. As the maintainer of KPowersave I don't change this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299626#c5 --- Comment #5 from Maciej Pilichowski <bluedzins@wp.pl> 2007-08-13 13:13:12 MST ---
There is nothing resetted,
It is.
only the _actual_ Scheme is applied to the running process. This is what the normal user await.
Nope.
No this is not what a user assume if he change something in the config dialog.
Be she/he DID NOT. Why in hell do you opt to change the current CPU to dynamic while the user explictly set it to powersave? It is not just giving user option, it is insisting the user will use the only one, true, right, mode. It is like the dialogue: user: I like powersave computer: ok user: and turn the monitor off after 10 minutes computer: ok, but I also change cpu back to dynamic. Yes, it makes perfect sense in some surreal world. But not mine.
As the maintainer of KPowersave I don't change this.
Suit yourself. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299626#c6 Andreas Jaeger <aj@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aj@novell.com Status|RESOLVED |REOPENED Resolution|WONTFIX | --- Comment #6 from Andreas Jaeger <aj@novell.com> 2007-08-13 13:26:06 MST --- I'd like to understand the problem better, so let's reopen this for now: Maciej, are you doing all these changes in kpowersave? Or some in kcontrol? Does kcontrol interacts with kpowersave? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299626#c7 --- Comment #7 from Maciej Pilichowski <bluedzins@wp.pl> 2007-08-13 13:50:19 MST --- Andreas, all changes are made in kpowersave. I used originally KControl but since it just calls kpowersave you can ignore this step and use KPowersave directly. To summarize -- my concern is that you can (and I do) change some things directly from popup menu. But you can also go to configuration and change (like in this example) monitor settings and _nothing_ else. But when you commit it, you see that all options, even those you didn't see are changed! 1) this is simply bad UI/design -- compare it to KControl, only those things which you changed are changed (well, by definition almost) 2) I would suggest to fix the UI because it is the root of the problem -- either by providing commit on every tab/page or by changing only this what was change 3) or reading current values and suggesting them, so you could skip any changes in UI 4) or don't change current option after scheme changes if they differ 5) or ... :-) Simply put -- problem is Kpowersave mixes (with bad result) settings "for now" with settings "for scheme". Problem exists and it would be good to solve it. Of course Danny can say he is maintainer and I am just a user of no importance and he is right (no irony here) -- but I am familiar with a good design principles and the principle of the least surprise is one of them. KPowersave does not follow it. Thank you for listening. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299626#c8 --- Comment #8 from Danny Kukawka <dkukawka@novell.com> 2007-08-13 14:01:42 MST ---
Simply put -- problem is Kpowersave mixes (with bad result) settings "for now" with settings "for scheme".
This is not correct. KPowersave mix nothing. The rule is very simple: if you change a scheme the complete scheme setting get applied again to the running KPowersave instance. There get nothing mixed up. I don't plan to blow up the code of the configure dialog by +50 or more procent because of this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299626#c9 --- Comment #9 from Maciej Pilichowski <bluedzins@wp.pl> 2007-08-13 14:40:19 MST ---
The rule is very simple: if you change a scheme the complete scheme setting get applied again to the running KPowersave instance.
Well, with each app you can come up with your own rules and you can call such cases as above all the time features (after all, "the rule", right?). But my point is -- it has nothing do with good design and it has nothing to do what user could guess/expect either. Compare it to KControl, KMail, Konqueror, hmm, I cannot recall any other app which does such thing as KPowersave. Btw. "the rule" makes integration with KDE more difficult because user was changing just monitor settings.
I don't plan to blow up the code of the configure dialog by +50 or more procent because of this.
Yes, you made that clear on several other occasions. It is attitude difference -- in my opinion, quality first, implementation goes second. In anything, not only software. Danny, it is not my intention to argue with you -- I hope I explained my point of view, so if I could help in something, please let me know, if not -- I am out. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299626#c10 --- Comment #10 from Danny Kukawka <dkukawka@novell.com> 2007-08-13 14:46:25 MST --- There are no other tools like KPowersave. They all have no schemes, this is something complete different to Kcontrol or what ever. And if you start to compare KMail with KPowersave: they do complete other things. I can't see stuff you can change in the KMail config dialog _and_ via a menu entry temporary. You compare apples and oranges. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299626 Stefan Behlert <behlert@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|behlert@novell.com |dkukawka@novell.com Status|REOPENED |NEW -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299626#c11 Danny Kukawka <dkukawka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX --- Comment #11 from Danny Kukawka <dkukawka@novell.com> 2007-08-21 05:02:45 MST --- As already explained, I don't plan to change this also because we have othere cases where we have to go this way as e.g. on inactive session handling. We can't monitor all changes and differ betwenn them and user things the user may set beforevia the applet. The scheme settings have a higher priority than the changes in the applet. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=299626#c12 --- Comment #12 from Maciej Pilichowski <bluedzins@wp.pl> 2007-08-21 07:33:48 MST --- Some people handle the problem, some people pretend there is none. So remember all KControl users -- if you change anything in your monitor settings don't forget to check all major/minor/whatever options available in KPowersave -- all of them. After all, people do not matter, the rules do. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com